User Details
- User Since
- Aug 16 2021, 1:01 PM (110 w, 2 d)
Tue, Sep 19
(friendly ping)
Apr 29 2023
Apr 28 2023
(ping) Does this make sense or are more adjustments needed?
Use ArrayRef instead of SmallVector to avoid copy (also fix 2 typos in the comment below)
Apr 8 2023
(Note that this diff is stacked on D147846)
Feb 18 2023
- Move to free function in CodeCompletionStrings.h
- Add back comment markers before parsing (Index stores comments without markers, but the comment lexer expects them)
Feb 9 2023
Thanks for reviewing!
Feb 8 2023
Feb 1 2023
Move EnclosingNamespace logic to scopesForIndexQuery, add FIXME
Jan 29 2023
Address review comments, add regression test
Jan 23 2023
Jan 18 2023
Jan 15 2023
Factor out logic into helper function
Jan 14 2023
Address review comment: Introduce new AccessibleScopes variable
Jan 8 2023
Jan 4 2023
Jan 3 2023
Add test for expression, improve presentation for signature with unnamed parameter
Jan 2 2023
Jan 1 2023
Dec 31 2022
Thanks both of you for reviewing!
Refactor getHoverContents to add CalleeArgInfo for all kinds of expression
Dec 30 2022
Dec 28 2022
s/llvm::Optional/std::optional/ for containerName field
LGTM!
Rebase, fix review comments
Dec 16 2022
Dec 13 2022
Thanks for the detailed feedback! Unfortunately, I’m sick right now, so I probably won’t be able to give a detailed answer until after Christmas.
Nov 29 2022
Nov 23 2022
Add end-to-end test
Nov 21 2022
Address comments
Nov 18 2022
Thanks again! Landed this with your suggestions incorporated.
Nov 17 2022
No problem! I wasn't quite happy yet with the previous version of this patch either, really appreciate the continuous feedback!
Use std::pair for returning payloads along with points/ranges. Also, refactor internal logic.
Nov 16 2022
Fix clangd::Annotations interface, now also has pointWithPayload etc.
Keep name syntax, add optional payload instead
Nov 15 2022
Fix one test I missed
${} instead of $()
LGTM, but I'll give @kadircet a chance to review as well
Nov 14 2022
Nov 13 2022
Clean up test
Nov 11 2022
Fix test
This looks really cool :)
Nov 10 2022
Nov 9 2022
Hmm I added the test for the flag to Sema, but now we kinda have the same test case duplicated in sema and clangd tests - I guess for clangd we now actually only have to test that the SnippetSuffix is cleared when FunctionCanBeCall is true, but I don't see an easy way to somehow inject fake Sema results into CodeComplete.cpp
Add test to sema
Nov 8 2022
Would be cool if in the future we could instead transform something like
Nov 6 2022
Thanks for the fix, LGTM! Do you want me to commit this for you?
Nov 5 2022
Did a quick test on my machine, seems to work! Can you add a regression test to clang-tools-extra/clangd/unittests/tweaks/RemoveUsingNamespaceTests.cpp though?
The test in clangd/unittests/CodeCompleteTests.cpp still passes. We now probably also need a unit test for Sema that tests the new flag, right?
Move logic to SemaCodeComplete.cpp