User Details
- User Since
- Aug 16 2021, 1:01 PM (51 w, 5 d)
Wed, Aug 10
Sun, Jul 17
Sorry, meant to make this a draft
Jul 10 2022
@sammccall I think you can merge this for me now (and also https://reviews.llvm.org/D128202)
Jun 29 2022
- Remove obsolete comment
- Return empty vector when type isNull()
- Add comment about why we don't deduplicate results
- Use out-parameter in unwrapFindType to make structure more consistent
Hmm, is the distinction that the type is written in the declaration (not auto)? I'm not sure it's worth specializing behavior for that scenario too much, when it's not too hard to go-to-definition on the specific token you want.
The chance of guessing right has to be weighed against keeping the behavior predictable and comprehensible...
Yes that's what I meant, but I agree with you here.
(Interesting, I'm using the same and find it annoying: it focuses the quickfix window and that's disruptive enough that I never noticed the cursor also moved. But https://github.com/neovim/neovim/pull/14878 lists some workarounds)
(Ah, I also forgot that I'm not actually using quickfix, but rather https://github.com/folke/trouble.nvim, which also gets focused but has a preview feature)
Jun 28 2022
Check for FinalAttr instead of using isEffectivelyFinal()
Jun 20 2022
Sep 8 2021
I’d say commit as is and have a look at the SmallVector -> unit32_t thing together with the std::map issue afterwards
Sep 7 2021
Yeah, I‘d need someone to commit this for me.
Aug 28 2021
- Use llvm::SmallVector, add more FIXME, remove old commented out test
Aug 23 2021
@sammccall @nridge Thanks for the positive feedback, let me know if I missed any of your suggestions!
- clang-format once again
- Remove accidentally added empty line
- Apply suggested renaming and fix nits
- Use a map for extra modifiers instead of abusing conflict resolution
- Use ArrayRef instead of callback
- Add FIXME for handling CXXOperatorCallExpr
- Use getLocation() instead of getBeginLoc()
- Add FIXME for unwrapping operators
- Iterate over FunctionProtoType instead of FunctionDecl
- Adjust highlighting condition and revise test cases