Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

tom-anders (Tom Praschan)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 16 2021, 1:01 PM (110 w, 2 d)

Recent Activity

Tue, Sep 19

tom-anders added a comment to D141800: [clangd] Fix qualifier not being dropped for using declaration referring to scoped enum.

(friendly ping)

Tue, Sep 19, 1:48 AM · Restricted Project, Restricted Project

Apr 29 2023

tom-anders committed rGcb133a4629a5: [clangd] Hover: Add CalleeArgInfo for constructor expressions (authored by tom-anders).
[clangd] Hover: Add CalleeArgInfo for constructor expressions
Apr 29 2023, 3:37 AM · Restricted Project, Restricted Project
tom-anders closed D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions.
Apr 29 2023, 3:37 AM · Restricted Project, Restricted Project

Apr 28 2023

tom-anders added a comment to D143112: [clang] Support parsing comments without ASTContext.

(ping) Does this make sense or are more adjustments needed?

Apr 28 2023, 10:57 AM · Restricted Project, Restricted Project, Restricted Project
tom-anders added inline comments to D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions.
Apr 28 2023, 10:53 AM · Restricted Project, Restricted Project
tom-anders updated the diff for D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions.

Use ArrayRef instead of SmallVector to avoid copy (also fix 2 typos in the comment below)

Apr 28 2023, 10:52 AM · Restricted Project, Restricted Project
tom-anders committed rGa7b4fd953f44: [clangd] Hover: resolve forwarding parameters for CalleeArgInfo (authored by tom-anders).
[clangd] Hover: resolve forwarding parameters for CalleeArgInfo
Apr 28 2023, 10:49 AM · Restricted Project, Restricted Project
tom-anders closed D147846: [clangd] Hover: resolve forwarding parameters for CalleeArgInfo.
Apr 28 2023, 10:48 AM · Restricted Project, Restricted Project

Apr 8 2023

tom-anders added a comment to D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions.

(Note that this diff is stacked on D147846)

Apr 8 2023, 4:03 AM · Restricted Project, Restricted Project
tom-anders added inline comments to D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions.
Apr 8 2023, 4:02 AM · Restricted Project, Restricted Project
tom-anders requested review of D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions.
Apr 8 2023, 3:59 AM · Restricted Project, Restricted Project
tom-anders requested review of D147846: [clangd] Hover: resolve forwarding parameters for CalleeArgInfo.
Apr 8 2023, 3:06 AM · Restricted Project, Restricted Project

Feb 18 2023

tom-anders added inline comments to D143112: [clang] Support parsing comments without ASTContext.
Feb 18 2023, 6:29 AM · Restricted Project, Restricted Project, Restricted Project
tom-anders updated the diff for D143112: [clang] Support parsing comments without ASTContext.
  • Move to free function in CodeCompletionStrings.h
  • Add back comment markers before parsing (Index stores comments without markers, but the comment lexer expects them)
Feb 18 2023, 6:23 AM · Restricted Project, Restricted Project, Restricted Project

Feb 9 2023

tom-anders committed rGce87b0314370: [clangd] Fix getQueryScopes for using-directive with inline namespace (authored by tom-anders).
[clangd] Fix getQueryScopes for using-directive with inline namespace
Feb 9 2023, 10:54 AM · Restricted Project, Restricted Project
tom-anders closed D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace.
Feb 9 2023, 10:53 AM · Restricted Project, Restricted Project
tom-anders added a comment to D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace.

Thanks for reviewing!

Feb 9 2023, 10:40 AM · Restricted Project, Restricted Project

Feb 8 2023

tom-anders added a comment to D142014: [clangd] fix wrong CalleeArgInfo in the hover.

Thanks for the review! @kadircet

Would you mind having a look at if there're any concerns about the current code change, @nridge, @tom-anders, and @adamcz? Thanks a lot!

Feb 8 2023, 2:53 PM · Restricted Project, Restricted Project

Feb 1 2023

tom-anders added inline comments to D143112: [clang] Support parsing comments without ASTContext.
Feb 1 2023, 2:37 PM · Restricted Project, Restricted Project, Restricted Project
tom-anders requested review of D143112: [clang] Support parsing comments without ASTContext.
Feb 1 2023, 2:33 PM · Restricted Project, Restricted Project, Restricted Project
tom-anders added inline comments to D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace.
Feb 1 2023, 2:30 PM · Restricted Project, Restricted Project
tom-anders updated the diff for D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace.

Move EnclosingNamespace logic to scopesForIndexQuery, add FIXME

Feb 1 2023, 2:29 PM · Restricted Project, Restricted Project

Jan 29 2023

tom-anders added inline comments to D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace.
Jan 29 2023, 7:54 AM · Restricted Project, Restricted Project
tom-anders updated the diff for D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace.

Address review comments, add regression test

Jan 29 2023, 7:51 AM · Restricted Project, Restricted Project

Jan 23 2023

tom-anders awarded D142014: [clangd] fix wrong CalleeArgInfo in the hover a Like token.
Jan 23 2023, 10:39 PM · Restricted Project, Restricted Project
tom-anders added inline comments to D142014: [clangd] fix wrong CalleeArgInfo in the hover.
Jan 23 2023, 10:46 AM · Restricted Project, Restricted Project
tom-anders added inline comments to D142014: [clangd] fix wrong CalleeArgInfo in the hover.
Jan 23 2023, 10:35 AM · Restricted Project, Restricted Project

Jan 18 2023

tom-anders added inline comments to D141800: [clangd] Fix qualifier not being dropped for using declaration referring to scoped enum.
Jan 18 2023, 10:50 AM · Restricted Project, Restricted Project
tom-anders added inline comments to D141800: [clangd] Fix qualifier not being dropped for using declaration referring to scoped enum.
Jan 18 2023, 10:48 AM · Restricted Project, Restricted Project

Jan 15 2023

tom-anders updated the diff for D141800: [clangd] Fix qualifier not being dropped for using declaration referring to scoped enum.

Factor out logic into helper function

Jan 15 2023, 1:04 PM · Restricted Project, Restricted Project
tom-anders requested review of D141800: [clangd] Fix qualifier not being dropped for using declaration referring to scoped enum.
Jan 15 2023, 10:54 AM · Restricted Project, Restricted Project

Jan 14 2023

tom-anders committed rG343b1ae3622a: [clangd] Hover: show CalleeArgInfo for literals and expressions (authored by tom-anders).
[clangd] Hover: show CalleeArgInfo for literals and expressions
Jan 14 2023, 1:21 PM · Restricted Project, Restricted Project
tom-anders closed D140775: [clangd] Hover: show CalleeArgInfo for literals.
Jan 14 2023, 1:21 PM · Restricted Project, Restricted Project
tom-anders added inline comments to D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace.
Jan 14 2023, 11:15 AM · Restricted Project, Restricted Project
tom-anders updated the diff for D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace.

Address review comment: Introduce new AccessibleScopes variable

Jan 14 2023, 10:55 AM · Restricted Project, Restricted Project

Jan 8 2023

tom-anders added inline comments to D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace.
Jan 8 2023, 10:19 AM · Restricted Project, Restricted Project

Jan 4 2023

tom-anders added inline comments to D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace.
Jan 4 2023, 10:55 AM · Restricted Project, Restricted Project

Jan 3 2023

tom-anders updated the summary of D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace.
Jan 3 2023, 11:59 AM · Restricted Project, Restricted Project
tom-anders requested review of D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace.
Jan 3 2023, 11:58 AM · Restricted Project, Restricted Project
tom-anders updated the diff for D140775: [clangd] Hover: show CalleeArgInfo for literals.

Add test for expression, improve presentation for signature with unnamed parameter

Jan 3 2023, 11:26 AM · Restricted Project, Restricted Project

Jan 2 2023

tom-anders added a comment to D140775: [clangd] Hover: show CalleeArgInfo for literals.

Do you want to add a simple test case for a non-literal expression? Something like hovering over the + in 2 + 3 should work.

Jan 2 2023, 10:58 AM · Restricted Project, Restricted Project

Jan 1 2023

tom-anders committed rGd408c34d1f58: [clangd] Add extension for adding context (enclosing function or class) in… (authored by tom-anders).
[clangd] Add extension for adding context (enclosing function or class) in…
Jan 1 2023, 5:30 AM · Restricted Project, Restricted Project
tom-anders closed D137894: [clangd] Add extension for adding context (enclosing function or class) in references results.
Jan 1 2023, 5:30 AM · Restricted Project, Restricted Project

Dec 31 2022

tom-anders added a comment to D137894: [clangd] Add extension for adding context (enclosing function or class) in references results.

Thanks both of you for reviewing!

Dec 31 2022, 6:23 AM · Restricted Project, Restricted Project
tom-anders added inline comments to D140775: [clangd] Hover: show CalleeArgInfo for literals.
Dec 31 2022, 2:57 AM · Restricted Project, Restricted Project
tom-anders updated the diff for D140775: [clangd] Hover: show CalleeArgInfo for literals.

Refactor getHoverContents to add CalleeArgInfo for all kinds of expression

Dec 31 2022, 2:52 AM · Restricted Project, Restricted Project

Dec 30 2022

tom-anders added inline comments to D140775: [clangd] Hover: show CalleeArgInfo for literals.
Dec 30 2022, 2:36 AM · Restricted Project, Restricted Project
tom-anders requested review of D140775: [clangd] Hover: show CalleeArgInfo for literals.
Dec 30 2022, 2:32 AM · Restricted Project, Restricted Project

Dec 28 2022

tom-anders committed rG46575f60380b: [clangd] Fix action `RemoveUsingNamespace` for inline namespace (authored by v1nh1shungry).
[clangd] Fix action `RemoveUsingNamespace` for inline namespace
Dec 28 2022, 3:50 AM · Restricted Project, Restricted Project
tom-anders closed D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace.
Dec 28 2022, 3:50 AM · Restricted Project, Restricted Project
tom-anders updated the diff for D137894: [clangd] Add extension for adding context (enclosing function or class) in references results.

s/llvm::Optional/std::optional/ for containerName field

Dec 28 2022, 3:29 AM · Restricted Project, Restricted Project
tom-anders accepted D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace.

LGTM!

Dec 28 2022, 3:29 AM · Restricted Project, Restricted Project
tom-anders added inline comments to D137894: [clangd] Add extension for adding context (enclosing function or class) in references results.
Dec 28 2022, 3:23 AM · Restricted Project, Restricted Project
tom-anders updated the diff for D137894: [clangd] Add extension for adding context (enclosing function or class) in references results.

Rebase, fix review comments

Dec 28 2022, 3:23 AM · Restricted Project, Restricted Project

Dec 16 2022

tom-anders awarded D139998: [clangd] Remove ReferenceFinder::Reference::Target a Like token.
Dec 16 2022, 2:07 AM · Restricted Project, Restricted Project

Dec 13 2022

tom-anders added a comment to D134130: [clangd] Add doxygen parsing for Hover [1/3].

Thanks for the detailed feedback! Unfortunately, I’m sick right now, so I probably won’t be able to give a detailed answer until after Christmas.

Dec 13 2022, 8:47 AM · Restricted Project, Restricted Project, Restricted Project

Nov 29 2022

tom-anders added inline comments to D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace.
Nov 29 2022, 10:32 PM · Restricted Project, Restricted Project
tom-anders added a comment to D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace.

A gentle ping? Sorry if it bothers you.

Nov 29 2022, 1:08 PM · Restricted Project, Restricted Project

Nov 23 2022

tom-anders updated the diff for D137894: [clangd] Add extension for adding context (enclosing function or class) in references results.

Add end-to-end test

Nov 23 2022, 11:08 AM · Restricted Project, Restricted Project

Nov 21 2022

tom-anders added a comment to D138425: [clangd] Parameter hints for template specialization.

Yes, there is a common situation where people use a meaningless template parameter name, but I think the same for functions.

I don't think it's the same: my wild guess would be 30% of function params have useless names, and 90% of template params do.
If this were accurate, it seems function param hints are usually (potentially) useful, while template params are almost always useless.

Nov 21 2022, 1:19 PM · Restricted Project, Restricted Project
tom-anders added a comment to D137894: [clangd] Add extension for adding context (enclosing function or class) in references results.

Since this is a protocol extension, you might want to add an end-to-end test: variant of clang-tools-extra/clangd/test/xrefs.test (xrefs-container.test? to avoid complicating all the existing tests).

Nov 21 2022, 8:33 AM · Restricted Project, Restricted Project
tom-anders updated the diff for D137894: [clangd] Add extension for adding context (enclosing function or class) in references results.

Address comments

Nov 21 2022, 8:31 AM · Restricted Project, Restricted Project

Nov 18 2022

tom-anders added inline comments to D137894: [clangd] Add extension for adding context (enclosing function or class) in references results.
Nov 18 2022, 5:35 AM · Restricted Project, Restricted Project
tom-anders added reviewers for D137894: [clangd] Add extension for adding context (enclosing function or class) in references results: nridge, sammccall.
Nov 18 2022, 5:34 AM · Restricted Project, Restricted Project
tom-anders published D137894: [clangd] Add extension for adding context (enclosing function or class) in references results for review.
Nov 18 2022, 5:33 AM · Restricted Project, Restricted Project
tom-anders added a comment to D137909: [Support] Allow complex names for annotation points and ranges via ${}.

Thanks again! Landed this with your suggestions incorporated.

Nov 18 2022, 5:02 AM · Restricted Project, Restricted Project, Restricted Project
tom-anders committed rG3cf14a7bdce0: [Support] Add support for attaching payloads to points and ranges (authored by tom-anders).
[Support] Add support for attaching payloads to points and ranges
Nov 18 2022, 5:01 AM · Restricted Project, Restricted Project, Restricted Project
tom-anders closed D137909: [Support] Allow complex names for annotation points and ranges via ${}.
Nov 18 2022, 5:00 AM · Restricted Project, Restricted Project, Restricted Project

Nov 17 2022

tom-anders added a comment to D137909: [Support] Allow complex names for annotation points and ranges via ${}.

Thanks! sorry about continuing to drift this patch, but this looks like a great improvement.

No problem! I wasn't quite happy yet with the previous version of this patch either, really appreciate the continuous feedback!

Nov 17 2022, 1:53 PM · Restricted Project, Restricted Project, Restricted Project
tom-anders updated the diff for D137909: [Support] Allow complex names for annotation points and ranges via ${}.

Use std::pair for returning payloads along with points/ranges. Also, refactor internal logic.

Nov 17 2022, 1:53 PM · Restricted Project, Restricted Project, Restricted Project

Nov 16 2022

tom-anders added inline comments to D137909: [Support] Allow complex names for annotation points and ranges via ${}.
Nov 16 2022, 3:44 PM · Restricted Project, Restricted Project, Restricted Project
tom-anders updated the diff for D137909: [Support] Allow complex names for annotation points and ranges via ${}.

Fix clangd::Annotations interface, now also has pointWithPayload etc.

Nov 16 2022, 3:41 PM · Restricted Project, Restricted Project, Restricted Project
tom-anders committed rG0e00611cbc2b: [clangd] Add heuristic for dropping snippet when completing member function… (authored by tom-anders).
[clangd] Add heuristic for dropping snippet when completing member function…
Nov 16 2022, 2:38 PM · Restricted Project, Restricted Project, Restricted Project
tom-anders closed D137040: [clangd] Add heuristic for dropping snippet when completing member function pointer.
Nov 16 2022, 2:38 PM · Restricted Project, Restricted Project, Restricted Project
tom-anders added a comment to D137909: [Support] Allow complex names for annotation points and ranges via ${}.

What do you think about $name(payload)^ for the general case, with $(payload)^, $name, and ^ as abbreviated forms? I don't think the lack of brackets on names hurts a lot if they stay simple, and if they're "just labels" that don't have to carry arbitrary payloads then they can be simple.

Nov 16 2022, 2:32 PM · Restricted Project, Restricted Project, Restricted Project
tom-anders updated the diff for D137909: [Support] Allow complex names for annotation points and ranges via ${}.

Keep name syntax, add optional payload instead

Nov 16 2022, 2:25 PM · Restricted Project, Restricted Project, Restricted Project

Nov 15 2022

tom-anders updated the diff for D137909: [Support] Allow complex names for annotation points and ranges via ${}.

Fix one test I missed

Nov 15 2022, 11:15 AM · Restricted Project, Restricted Project, Restricted Project
tom-anders retitled D137909: [Support] Allow complex names for annotation points and ranges via ${} from [Support] Allow complex names for annotation points and ranges via $() to [Support] Allow complex names for annotation points and ranges via ${}.
Nov 15 2022, 11:14 AM · Restricted Project, Restricted Project, Restricted Project
tom-anders updated the diff for D137909: [Support] Allow complex names for annotation points and ranges via ${}.

${} instead of $()

Nov 15 2022, 11:13 AM · Restricted Project, Restricted Project, Restricted Project
tom-anders added inline comments to D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace.
Nov 15 2022, 11:09 AM · Restricted Project, Restricted Project
tom-anders added a comment to D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals.

LGTM, but I'll give @kadircet a chance to review as well

Nov 15 2022, 10:39 AM · Restricted Project, Restricted Project

Nov 14 2022

tom-anders added a comment to D137909: [Support] Allow complex names for annotation points and ranges via ${}.

This seems pretty nice (I do find foo$long_word^bar a bit hard to read). I think I'm in favor, my concerns would be that for a small benefit we're:

  • adding some extra complexity people have to understand
  • providing more ways to write something, so more bikeshedding opportunities
  • encouraging people to embed structured information in the annotations, in a way that won't be very readable *and* isn't well-supported by the API

Can you give examples of where you want to use this?
(I think we should *probably* accept this regardless, but tests want to iterate over payload-name pairs or things like that we should think a couple of steps ahead)

Nov 14 2022, 5:16 AM · Restricted Project, Restricted Project, Restricted Project
tom-anders added a comment to D137040: [clangd] Add heuristic for dropping snippet when completing member function pointer.

Thanks!

Nov 14 2022, 12:37 AM · Restricted Project, Restricted Project, Restricted Project

Nov 13 2022

tom-anders requested review of D137909: [Support] Allow complex names for annotation points and ranges via ${}.
Nov 13 2022, 7:52 AM · Restricted Project, Restricted Project, Restricted Project
tom-anders updated the diff for D137040: [clangd] Add heuristic for dropping snippet when completing member function pointer.

Clean up test

Nov 13 2022, 3:47 AM · Restricted Project, Restricted Project, Restricted Project

Nov 11 2022

tom-anders updated the diff for D137040: [clangd] Add heuristic for dropping snippet when completing member function pointer.

Fix test

Nov 11 2022, 11:26 AM · Restricted Project, Restricted Project, Restricted Project
tom-anders added a comment to D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals.

This looks really cool :)

Nov 11 2022, 9:49 AM · Restricted Project, Restricted Project

Nov 10 2022

tom-anders added a comment to D137650: [clangd] Implement hover for string literals.

sure i am happy to land, @tom-anders do you have anything else to add ?

Nov 10 2022, 3:05 AM · Restricted Project, Restricted Project

Nov 9 2022

tom-anders added a comment to D137040: [clangd] Add heuristic for dropping snippet when completing member function pointer.

Hmm I added the test for the flag to Sema, but now we kinda have the same test case duplicated in sema and clangd tests - I guess for clangd we now actually only have to test that the SnippetSuffix is cleared when FunctionCanBeCall is true, but I don't see an easy way to somehow inject fake Sema results into CodeComplete.cpp

Nov 9 2022, 2:04 PM · Restricted Project, Restricted Project, Restricted Project
tom-anders updated the diff for D137040: [clangd] Add heuristic for dropping snippet when completing member function pointer.

Add test to sema

Nov 9 2022, 2:00 PM · Restricted Project, Restricted Project, Restricted Project
tom-anders committed rG82ca918b5755: [clangd] Fix the code action `RemoveUsingNamespace` (authored by v1nh1shungry).
[clangd] Fix the code action `RemoveUsingNamespace`
Nov 9 2022, 11:05 AM · Restricted Project, Restricted Project
tom-anders closed D137550: [clangd] Fix the code action `RemoveUsingNamespace`.
Nov 9 2022, 11:05 AM · Restricted Project, Restricted Project

Nov 8 2022

tom-anders added inline comments to D137650: [clangd] Implement hover for string literals.
Nov 8 2022, 11:01 AM · Restricted Project, Restricted Project
tom-anders accepted D137550: [clangd] Fix the code action `RemoveUsingNamespace`.

Would be cool if in the future we could instead transform something like

Nov 8 2022, 10:54 AM · Restricted Project, Restricted Project

Nov 6 2022

tom-anders committed rGf5a2ef80fa47: [clangd] Fix the code action `RemoveUsingNamespace` (authored by v1nh1shungry).
[clangd] Fix the code action `RemoveUsingNamespace`
Nov 6 2022, 8:32 AM · Restricted Project, Restricted Project
tom-anders closed D137494: [Clangd] Fix the code action `RemoveUsingNamespace`.
Nov 6 2022, 8:32 AM · Restricted Project, Restricted Project
tom-anders accepted D137494: [Clangd] Fix the code action `RemoveUsingNamespace`.

Thanks for the fix, LGTM! Do you want me to commit this for you?

Nov 6 2022, 1:16 AM · Restricted Project, Restricted Project

Nov 5 2022

tom-anders requested changes to D137494: [Clangd] Fix the code action `RemoveUsingNamespace`.

Did a quick test on my machine, seems to work! Can you add a regression test to clang-tools-extra/clangd/unittests/tweaks/RemoveUsingNamespaceTests.cpp though?

Nov 5 2022, 11:47 AM · Restricted Project, Restricted Project
tom-anders added a comment to D137040: [clangd] Add heuristic for dropping snippet when completing member function pointer.

The test in clangd/unittests/CodeCompleteTests.cpp still passes. We now probably also need a unit test for Sema that tests the new flag, right?

Nov 5 2022, 2:29 AM · Restricted Project, Restricted Project, Restricted Project
tom-anders updated the diff for D137040: [clangd] Add heuristic for dropping snippet when completing member function pointer.

Move logic to SemaCodeComplete.cpp

Nov 5 2022, 2:25 AM · Restricted Project, Restricted Project, Restricted Project