- User Since
- Nov 13 2022, 2:44 PM (55 w, 6 d)
Nov 1 2023
Rebase, fix tests, and rerun CI before relanding.
This was reverted due to an issue fixed by https://github.com/llvm/llvm-project/pull/68840 and should now be ready to reland.
Sep 28 2023
Fix broken test.
Add suggested comment + Rebase.
Sep 27 2023
Sep 25 2023
Sep 12 2023
Aug 31 2023
Aug 30 2023
Aug 29 2023
Jun 23 2023
Jun 22 2023
Jun 21 2023
Address comments. Thanks for the suggestions. I think the ifs and switches cleaned up quite nicely using the new helper classes.
My original train of thought behind the switch in emitCarryIn was that if anyone wanted to add support for carry-in setting of other instructions they would have to explicitly add their instruction and think about if they needed a negated carry and could opt-in to the optimizations only if they wanted to. I can't think of any other usecase though, so emitting the carry as-is also seems like a sane default.
Jun 17 2023
Update commit summary to include fixed issue. Thanks.
Address comments. Thanks.
Jun 16 2023
I fixed these same issues here https://reviews.llvm.org/D153164 2 minutes earlier. I do generate better code though, because I generate less instructions for carry-in setting and optimize these instructions away whenever possible. For >O0 I generate identical code to SelectionDag. I also have higher test coverage.