Page MenuHomePhabricator

to268 (Guillot Tony)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 7 2022, 9:24 AM (22 w, 7 h)

Recent Activity

Today

to268 updated the diff for D133289: [C2X] N3007 Type inference for object definitions.

Removed compound literal diagnostic in ParseExpr

Thu, Dec 8, 9:44 AM · Unknown Object (Project), Restricted Project

Sun, Nov 27

to268 updated the diff for D133289: [C2X] N3007 Type inference for object definitions.

Added test cases and added an explicit auto* diagnostic

Sun, Nov 27, 11:18 AM · Unknown Object (Project), Restricted Project

Sun, Nov 13

to268 added a comment to D133289: [C2X] N3007 Type inference for object definitions.

This is a status update of the patch.

Sun, Nov 13, 10:43 PM · Unknown Object (Project), Restricted Project

Fri, Nov 11

to268 accepted D137724: [CMake] Warn when the version is older than 3.20.0..

LGTM

Fri, Nov 11, 8:02 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project

Oct 28 2022

to268 added a comment to D133289: [C2X] N3007 Type inference for object definitions.

Also i'm not sure if must add C2x to this condition just in case (falling back or add an assertion)

Oct 28 2022, 6:52 AM · Unknown Object (Project), Restricted Project
to268 updated the diff for D133289: [C2X] N3007 Type inference for object definitions.

Reworked the parsing side of the patch

Oct 28 2022, 6:48 AM · Unknown Object (Project), Restricted Project

Oct 5 2022

to268 updated the diff for D133289: [C2X] N3007 Type inference for object definitions.

Added a check to not diagnose a missing type specifier in C2x mode

Oct 5 2022, 1:02 AM · Unknown Object (Project), Restricted Project

Oct 4 2022

to268 updated the diff for D133289: [C2X] N3007 Type inference for object definitions.
Oct 4 2022, 10:30 PM · Unknown Object (Project), Restricted Project

Sep 27 2022

to268 added a comment to D133289: [C2X] N3007 Type inference for object definitions.

Here are all the details that i've said earlier

Sep 27 2022, 10:14 PM · Unknown Object (Project), Restricted Project
to268 updated the diff for D133289: [C2X] N3007 Type inference for object definitions.

I've fixed the diagnostic message and all of the bad TODOs comments from the Sema test.
I've explained in details why i'm only able to handle auto in compound literals.

Sep 27 2022, 10:12 PM · Unknown Object (Project), Restricted Project

Sep 20 2022

to268 added a comment to D133289: [C2X] N3007 Type inference for object definitions.

Also i have found that we don't parse the compound literal with the auto keyword correctly in ParseExpr.cpp between line 939 to 973 which is the beginning of Parser::ParseCastExpression(...)

int test_cl = (int){12};      // Compound literal is detected
auto test_cl2 = (auto){12};   // Compound literal is not detected

I've haven't dig deeper yet but maybe it's because we are not including auto when trying to guess if it's a compound literal due to the fact that auto is a storage-class-specifier

Sep 20 2022, 10:34 PM · Unknown Object (Project), Restricted Project
to268 updated the diff for D133289: [C2X] N3007 Type inference for object definitions.

I've added more test cases, added a diagnostic when using auto in compound literals and advised fixes

Sep 20 2022, 10:19 PM · Unknown Object (Project), Restricted Project

Sep 13 2022

to268 added a comment to D133289: [C2X] N3007 Type inference for object definitions.
auto auto k = 12; // 99% this is intended to be accepted; first `auto` is the storage class specifier, second `auto` is a redundant storage class specifier
Sep 13 2022, 10:24 PM · Unknown Object (Project), Restricted Project

Sep 6 2022

to268 added a comment to D133289: [C2X] N3007 Type inference for object definitions.

Also @aaron.ballman said me that he was thinking about maybe adding an extension to add support for auto in a function return or in a parameter list.

Sep 6 2022, 10:11 PM · Unknown Object (Project), Restricted Project
to268 updated the diff for D133289: [C2X] N3007 Type inference for object definitions.

I've added a test case with scopes.

Sep 6 2022, 10:08 PM · Unknown Object (Project), Restricted Project

Sep 5 2022

to268 updated the diff for D133289: [C2X] N3007 Type inference for object definitions.

Fixed DeclSpec.cpp formatting

Sep 5 2022, 9:41 PM · Unknown Object (Project), Restricted Project
to268 updated the diff for D133289: [C2X] N3007 Type inference for object definitions.

I have fixed my CodeGen test with the windows platform.
(Linux uses an i64 for the long type instead windows is using an i32)

Sep 5 2022, 9:04 PM · Unknown Object (Project), Restricted Project
to268 updated the summary of D133289: [C2X] N3007 Type inference for object definitions.
Sep 5 2022, 4:39 AM · Unknown Object (Project), Restricted Project
to268 requested review of D133289: [C2X] N3007 Type inference for object definitions.
Sep 5 2022, 4:30 AM · Unknown Object (Project), Restricted Project