- User Since
- Sep 12 2013, 2:59 PM (337 w, 14 h)
Jul 30 2019
Jul 29 2019
Sync to HEAD to prepare for commit.
Jul 26 2019
Apologies about D59963; I should have waited longer to make sure things were resolved. My submission raced with a flip from being approved to land to not approved to land.
Jul 25 2019
Synchronize the documentation, as requested.
Sync'ing to the latest HEAD commit on master.
Jun 20 2019
Jun 19 2019
I can confirm that this fixes the clang-tidy crash I observed in trying to analyze the kernel.
Apr 23 2019
Remove an unnecessary header and fix the error text.
Thanks to everyone for the comments. I've answered them as best I can, and I'm definitely open to changes or to scrapping this entirely.
Apr 22 2019
Fix a line-length issue in the check code and rewrite the doc text.
Actually add the documentation in the release notes.
Updated with an initial check.
Mar 29 2019
Changed the module name to linuxkernel as suggested and updated the files to match.
Mar 28 2019
Not sure if you are the right reviewers; I just looked back in the commit history to see who reviewed clang-tidy changes recently.
Feb 26 2019
I'm going to submit this patch again, since that I believe I understand the problem, and I have tested this version on Win10 with the latest MSVC (other than the expectation that I just added, but that test wasn't a problem on the Windows builders, and the new expectation passes on my Linux dev box). I'll watch the Windows build at http://lab.llvm.org:8011/builders/clang-x64-windows-msvc and revert if there are problems.
Added the other expectation, as suggested.
Feb 25 2019
Dropped the C++ part of the ImportChooseExpr test entirely.
Updating after switching to the git monorepo model.
Changed to use llvm::find.
Feb 22 2019
Fixed a minor style typo.
Added more unit tests.
Feb 21 2019
Reverted to the original semantics of CondIsTrue
Fix a mistake in the comment.
Changed the CondIsTrue RHS as suggested.
Feb 19 2019
Thanks for the review and the suggestions for improving the tests.
Feb 15 2019
Updated Registry.cpp, regenerated the documentation, and added direct tests for the matcher.
Dec 3 2018
I found a better way to do this in the Linux kernel build.
Nov 19 2018
Change CompilationDatabase to not output entries that use -E.
Nov 16 2018
This is an old revision that is no longer needed (the implementation of CFI moved on long ago).
This is very old and doesn't need to be open anymore.
Nov 2 2018
LGTM. With the looser condition, the tests pass for me.
I can confirm that this version of the revision also fixes the bug I observed. I patched it in and built and re-ran the build step that failed.
Nov 1 2018
Use the ValueInfo for the name of an external node if the ValueInfo is not empty.
Jan 9 2015
Dec 5 2014
Nov 26 2014
Nov 13 2014
Committed in r221708
Nov 10 2014
This patch addresses the most recent comments in the review.
Oct 27 2014
Forgot to remove "XFAIL win32" in the previous patch.
This patch addresses the most recent set of comments.
Oct 24 2014
Here's a diff that fixes the outstanding comments and removes ARM support for now, as discussed in previous comments.
Oct 22 2014
Oct 21 2014
I just realized that there are two independent concerns here, and I'd like to separate them.
Jul 29 2014
Jul 28 2014
This version of the patch adds another virtual call to TargetInstrInfo to get a bound on the size of a jumptable entry, as discussed on llvmdev. This is used stored in JumpInstrTableInfo and used by ForwardControlFlowIntegrity to generate masks for jumps to jumptable entries. PTAL.
Jul 17 2014
This fixes comments from the recent review
Jul 15 2014
Jul 14 2014
Jul 10 2014
Abandoning after it was decided that this problem would be address by a flag in clang.
This patch addresses the latest set of comments on the FCFI code.
Comments on the current set of comments. I'm also about to update this with a patch that handles the other comments.
Jul 1 2014
Thanks for the comments. After the recent discussion with Nick about this issue on llvm-commits, I'm dropping -jump-table-all and will submit a patch to clang that adds support for an -ffcfi flag that will add unnamed_addr and jumptable to all functions instead. Please see D4167 for the FCFI LLVM side.
Jun 30 2014
This changes the FCFI code to drop all mention of JumpTableAll, as per the discussion on D4128 on llvm-commits; it will be up to the front end to set jumptable and unnamed_addr on functions that should be transformed by CFI.