Page MenuHomePhabricator

tmroeder (Tom Roeder)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 12 2013, 2:59 PM (337 w, 14 h)

Recent Activity

Jul 30 2019

tmroeder committed rG61493df7c654: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs. (authored by tmroeder).
[clang-tidy] Fix the documentation for linuxkernel-must-use-errs.
Jul 30 2019, 9:52 AM
tmroeder committed rL367333: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs..
[clang-tidy] Fix the documentation for linuxkernel-must-use-errs.
Jul 30 2019, 9:49 AM
tmroeder closed D65343: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs..
Jul 30 2019, 9:49 AM · Restricted Project, Restricted Project, Restricted Project

Jul 29 2019

tmroeder updated the diff for D65343: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs..

Sync to HEAD to prepare for commit.

Jul 29 2019, 11:13 AM · Restricted Project, Restricted Project, Restricted Project

Jul 26 2019

tmroeder added inline comments to D59963: [clang-tidy] Add a module for the Linux kernel..
Jul 26 2019, 2:46 PM · Restricted Project, Restricted Project, Restricted Project
tmroeder added a comment to D65343: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs..

Apologies about D59963; I should have waited longer to make sure things were resolved. My submission raced with a flip from being approved to land to not approved to land.

Jul 26 2019, 2:46 PM · Restricted Project, Restricted Project, Restricted Project
tmroeder added a project to D65343: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs.: Restricted Project.
Jul 26 2019, 12:14 PM · Restricted Project, Restricted Project, Restricted Project
tmroeder added inline comments to D59963: [clang-tidy] Add a module for the Linux kernel..
Jul 26 2019, 12:10 PM · Restricted Project, Restricted Project, Restricted Project
tmroeder created D65343: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs..
Jul 26 2019, 12:09 PM · Restricted Project, Restricted Project, Restricted Project
tmroeder added inline comments to D59963: [clang-tidy] Add a module for the Linux kernel..
Jul 26 2019, 10:03 AM · Restricted Project, Restricted Project, Restricted Project
tmroeder added inline comments to D59963: [clang-tidy] Add a module for the Linux kernel..
Jul 26 2019, 9:44 AM · Restricted Project, Restricted Project, Restricted Project
tmroeder added inline comments to D59963: [clang-tidy] Add a module for the Linux kernel..
Jul 26 2019, 9:42 AM · Restricted Project, Restricted Project, Restricted Project

Jul 25 2019

tmroeder committed rGfc8c65b2e11d: [clang-tidy] Add a module for the Linux kernel. (authored by tmroeder).
[clang-tidy] Add a module for the Linux kernel.
Jul 25 2019, 3:34 PM
tmroeder committed rL367071: [clang-tidy] Add a module for the Linux kernel..
[clang-tidy] Add a module for the Linux kernel.
Jul 25 2019, 3:34 PM
tmroeder closed D59963: [clang-tidy] Add a module for the Linux kernel..
Jul 25 2019, 3:34 PM · Restricted Project, Restricted Project, Restricted Project
tmroeder added inline comments to D59963: [clang-tidy] Add a module for the Linux kernel..
Jul 25 2019, 3:26 PM · Restricted Project, Restricted Project, Restricted Project
tmroeder updated the diff for D59963: [clang-tidy] Add a module for the Linux kernel..

Synchronize the documentation, as requested.

Jul 25 2019, 3:26 PM · Restricted Project, Restricted Project, Restricted Project
tmroeder updated the diff for D59963: [clang-tidy] Add a module for the Linux kernel..

Sync'ing to the latest HEAD commit on master.

Jul 25 2019, 9:48 AM · Restricted Project, Restricted Project, Restricted Project

Jun 20 2019

tmroeder added inline comments to D59963: [clang-tidy] Add a module for the Linux kernel..
Jun 20 2019, 11:55 AM · Restricted Project, Restricted Project, Restricted Project

Jun 19 2019

tmroeder added a comment to D63533: [analyzer] Fix clang-tidy crash on GCCAsmStmt.

I can confirm that this fixes the clang-tidy crash I observed in trying to analyze the kernel.

Jun 19 2019, 3:45 PM · Restricted Project, Restricted Project

Apr 23 2019

tmroeder updated the diff for D59963: [clang-tidy] Add a module for the Linux kernel..

Remove an unnecessary header and fix the error text.

Apr 23 2019, 9:49 AM · Restricted Project, Restricted Project, Restricted Project
tmroeder added a comment to D59963: [clang-tidy] Add a module for the Linux kernel..

Thanks to everyone for the comments. I've answered them as best I can, and I'm definitely open to changes or to scrapping this entirely.

Apr 23 2019, 9:19 AM · Restricted Project, Restricted Project, Restricted Project

Apr 22 2019

tmroeder added inline comments to D59963: [clang-tidy] Add a module for the Linux kernel..
Apr 22 2019, 4:04 PM · Restricted Project, Restricted Project, Restricted Project
tmroeder updated the diff for D59963: [clang-tidy] Add a module for the Linux kernel..

Fix a line-length issue in the check code and rewrite the doc text.

Apr 22 2019, 4:03 PM · Restricted Project, Restricted Project, Restricted Project
tmroeder updated the diff for D59963: [clang-tidy] Add a module for the Linux kernel..

Actually add the documentation in the release notes.

Apr 22 2019, 3:55 PM · Restricted Project, Restricted Project, Restricted Project
tmroeder updated the diff for D59963: [clang-tidy] Add a module for the Linux kernel..

Updated with an initial check.

Apr 22 2019, 3:48 PM · Restricted Project, Restricted Project, Restricted Project

Mar 29 2019

tmroeder retitled D59963: [clang-tidy] Add a module for the Linux kernel. from [clang-tidy] Add module for the Linux kernel. to [clang-tidy] Add a module for the Linux kernel..
Mar 29 2019, 10:40 AM · Restricted Project, Restricted Project, Restricted Project
tmroeder added a comment to D59963: [clang-tidy] Add a module for the Linux kernel..

Looks reasonable in general, but we usually add modules with at least one check. Let's do the same here.

Mar 29 2019, 10:40 AM · Restricted Project, Restricted Project, Restricted Project
tmroeder updated the diff for D59963: [clang-tidy] Add a module for the Linux kernel..

Changed the module name to linuxkernel as suggested and updated the files to match.

Mar 29 2019, 10:40 AM · Restricted Project, Restricted Project, Restricted Project

Mar 28 2019

tmroeder added reviewers for D59963: [clang-tidy] Add a module for the Linux kernel.: aaron.ballman, gribozavr.

Not sure if you are the right reviewers; I just looked back in the commit history to see who reviewed clang-tidy changes recently.

Mar 28 2019, 3:05 PM · Restricted Project, Restricted Project, Restricted Project
tmroeder created D59963: [clang-tidy] Add a module for the Linux kernel..
Mar 28 2019, 2:58 PM · Restricted Project, Restricted Project, Restricted Project

Feb 26 2019

tmroeder committed rG521f004e99c7: [ASTImporter] Add support for importing ChooseExpr AST nodes. (authored by tmroeder).
[ASTImporter] Add support for importing ChooseExpr AST nodes.
Feb 26 2019, 11:27 AM
tmroeder committed rC354916: [ASTImporter] Add support for importing ChooseExpr AST nodes..
[ASTImporter] Add support for importing ChooseExpr AST nodes.
Feb 26 2019, 11:27 AM
tmroeder committed rL354916: [ASTImporter] Add support for importing ChooseExpr AST nodes..
[ASTImporter] Add support for importing ChooseExpr AST nodes.
Feb 26 2019, 11:26 AM
tmroeder closed D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes..
Feb 26 2019, 11:26 AM · Restricted Project, Restricted Project
tmroeder added a comment to D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes..

I'm going to submit this patch again, since that I believe I understand the problem, and I have tested this version on Win10 with the latest MSVC (other than the expectation that I just added, but that test wasn't a problem on the Windows builders, and the new expectation passes on my Linux dev box). I'll watch the Windows build at http://lab.llvm.org:8011/builders/clang-x64-windows-msvc and revert if there are problems.

Feb 26 2019, 11:17 AM · Restricted Project, Restricted Project
tmroeder updated the diff for D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes..

Added the other expectation, as suggested.

Feb 26 2019, 9:33 AM · Restricted Project, Restricted Project

Feb 25 2019

tmroeder updated the summary of D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes..
Feb 25 2019, 9:42 PM · Restricted Project, Restricted Project
tmroeder updated the diff for D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes..

Dropped the C++ part of the ImportChooseExpr test entirely.

Feb 25 2019, 9:39 PM · Restricted Project, Restricted Project
tmroeder created D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes..
Feb 25 2019, 9:18 PM · Restricted Project, Restricted Project
tmroeder committed rG9a7287012239: [ASTImporter] Add support for importing ChooseExpr AST nodes. (authored by tmroeder).
[ASTImporter] Add support for importing ChooseExpr AST nodes.
Feb 25 2019, 3:25 PM
tmroeder committed rC354832: [ASTImporter] Add support for importing ChooseExpr AST nodes..
[ASTImporter] Add support for importing ChooseExpr AST nodes.
Feb 25 2019, 3:25 PM
tmroeder committed rL354832: [ASTImporter] Add support for importing ChooseExpr AST nodes..
[ASTImporter] Add support for importing ChooseExpr AST nodes.
Feb 25 2019, 3:24 PM
tmroeder closed D58292: Add support for importing ChooseExpr AST nodes..
Feb 25 2019, 3:24 PM · Restricted Project, Restricted Project
tmroeder updated the diff for D58292: Add support for importing ChooseExpr AST nodes..

Updating after switching to the git monorepo model.

Feb 25 2019, 3:17 PM · Restricted Project, Restricted Project
tmroeder updated the diff for D58292: Add support for importing ChooseExpr AST nodes..

Changed to use llvm::find.

Feb 25 2019, 11:05 AM · Restricted Project, Restricted Project

Feb 22 2019

tmroeder updated the diff for D58292: Add support for importing ChooseExpr AST nodes..

Fixed a minor style typo.

Feb 22 2019, 2:36 PM · Restricted Project, Restricted Project
tmroeder updated the diff for D58292: Add support for importing ChooseExpr AST nodes..

Added more unit tests.

Feb 22 2019, 2:32 PM · Restricted Project, Restricted Project

Feb 21 2019

tmroeder added inline comments to D58292: Add support for importing ChooseExpr AST nodes..
Feb 21 2019, 3:48 PM · Restricted Project, Restricted Project
tmroeder added inline comments to D58292: Add support for importing ChooseExpr AST nodes..
Feb 21 2019, 3:44 PM · Restricted Project, Restricted Project
tmroeder added inline comments to D58292: Add support for importing ChooseExpr AST nodes..
Feb 21 2019, 2:16 PM · Restricted Project, Restricted Project
tmroeder added inline comments to D58292: Add support for importing ChooseExpr AST nodes..
Feb 21 2019, 11:02 AM · Restricted Project, Restricted Project
tmroeder updated the diff for D58292: Add support for importing ChooseExpr AST nodes..

Reverted to the original semantics of CondIsTrue

Feb 21 2019, 11:02 AM · Restricted Project, Restricted Project
tmroeder updated the diff for D58292: Add support for importing ChooseExpr AST nodes..

Fix a mistake in the comment.

Feb 21 2019, 10:43 AM · Restricted Project, Restricted Project
tmroeder updated the diff for D58292: Add support for importing ChooseExpr AST nodes..

Changed the CondIsTrue RHS as suggested.

Feb 21 2019, 10:36 AM · Restricted Project, Restricted Project

Feb 19 2019

tmroeder updated the diff for D58292: Add support for importing ChooseExpr AST nodes..

Thanks for the review and the suggestions for improving the tests.

Feb 19 2019, 9:29 AM · Restricted Project, Restricted Project
tmroeder added inline comments to D58292: Add support for importing ChooseExpr AST nodes..
Feb 19 2019, 9:29 AM · Restricted Project, Restricted Project

Feb 15 2019

tmroeder added a comment to D58292: Add support for importing ChooseExpr AST nodes..

This looks reasonable, I will wait for @martong and/or @a_sidorin to review.

FYI LLDB is the other big user of ASTImpoter so it is helpful if you can run check-lldb especially on MacOS so you can to catch regressions before committing. After committing please make sure to monitor the GreenDragon build bots:

Feb 15 2019, 4:50 PM · Restricted Project, Restricted Project
tmroeder updated the diff for D58292: Add support for importing ChooseExpr AST nodes..

Updated Registry.cpp, regenerated the documentation, and added direct tests for the matcher.

Feb 15 2019, 4:50 PM · Restricted Project, Restricted Project
tmroeder created D58292: Add support for importing ChooseExpr AST nodes..
Feb 15 2019, 10:43 AM · Restricted Project, Restricted Project

Dec 3 2018

tmroeder abandoned D54657: [clang] Do not dump compilation-database entries for -E..

I found a better way to do this in the Linux kernel build.

Dec 3 2018, 9:46 AM

Nov 19 2018

tmroeder retitled D54657: [clang] Do not dump compilation-database entries for -E. from [clang] Add -MJJ for appending to compilation databases. to [clang] Do not dump compilation-database entries for -E..
Nov 19 2018, 2:10 PM
tmroeder added a comment to D54657: [clang] Do not dump compilation-database entries for -E..

I'm sorry, but it still sounds to me like you want to address badly written build rules by making the driver more complicated. I don't see that is a reasonable goal forward.

Nov 19 2018, 1:42 PM
tmroeder updated the diff for D54657: [clang] Do not dump compilation-database entries for -E..

Change CompilationDatabase to not output entries that use -E.

Nov 19 2018, 1:15 PM
tmroeder added a comment to D54657: [clang] Do not dump compilation-database entries for -E..

I don't understand the point here. Why would you want to include pre-processing-only commands in the compilation database?

Nov 19 2018, 8:37 AM

Nov 16 2018

tmroeder abandoned D2873: An analysis to find external function pointers and trace their data flow.

This is an old revision that is no longer needed (the implementation of CFI moved on long ago).

Nov 16 2018, 4:00 PM
tmroeder abandoned D6425: Link jumptable attributes consistently with unnamed_addr.

This is very old and doesn't need to be open anymore.

Nov 16 2018, 3:56 PM
tmroeder created D54657: [clang] Do not dump compilation-database entries for -E..
Nov 16 2018, 3:54 PM

Nov 2 2018

tmroeder accepted D53986: [LTO] Fix a crash caused by accessing an empty ValueInfo.

LGTM. With the looser condition, the tests pass for me.

Nov 2 2018, 4:49 PM
tmroeder added a comment to D53986: [LTO] Fix a crash caused by accessing an empty ValueInfo.

I can confirm that this version of the revision also fixes the bug I observed. I patched it in and built and re-ran the build step that failed.

Nov 2 2018, 4:08 PM
tmroeder added a comment to D53986: [LTO] Fix a crash caused by accessing an empty ValueInfo.

The change looks ok to me now, but we really need a test case for this. I tried unsuccessfully so far to induce the error. Was this produced when using the save-temps plugin-opt during your ThinLTO link? Can you go into the debugger and see what the value of E.Dst is?

I'm also at Google so feel free to reach out to me internally if your reproducer can't be shared upstream.

Via the test case Tom provided me, I can see what is going on. This is from an aliasee, where the aliasee is internal linkage, and because it has internal linkage and there are multiple internal symbols with the same name and internal linkage we are not able to get the GUID from the original GUID. I have a more robust fix, and can create a test case. Mind if I commandeer this patch?

Nov 2 2018, 12:00 PM

Nov 1 2018

tmroeder added inline comments to D53986: [LTO] Fix a crash caused by accessing an empty ValueInfo.
Nov 1 2018, 1:19 PM
tmroeder updated the diff for D53986: [LTO] Fix a crash caused by accessing an empty ValueInfo.

Use the ValueInfo for the name of an external node if the ValueInfo is not empty.

Nov 1 2018, 1:17 PM
tmroeder added a comment to D53986: [LTO] Fix a crash caused by accessing an empty ValueInfo.

Can you please post the *.index.bc file? It is saved before dot, so it should be there

Nov 1 2018, 11:38 AM
tmroeder created D53986: [LTO] Fix a crash caused by accessing an empty ValueInfo.
Nov 1 2018, 10:45 AM

Jan 9 2015

tmroeder added a comment to D6425: Link jumptable attributes consistently with unnamed_addr.

ping

Jan 9 2015, 10:36 AM

Dec 5 2014

tmroeder added a comment to D6425: Link jumptable attributes consistently with unnamed_addr.

ping

Dec 5 2014, 3:56 PM

Nov 26 2014

tmroeder retitled D6425: Link jumptable attributes consistently with unnamed_addr from to Link jumptable attributes consistently with unnamed_addr.
Nov 26 2014, 1:33 PM

Nov 13 2014

tmroeder closed D4167: Add Forward-Edge Control-Flow Integrity support.

Committed in r221708

Nov 13 2014, 8:32 AM

Nov 10 2014

tmroeder added inline comments to D4167: Add Forward-Edge Control-Flow Integrity support.
Nov 10 2014, 11:32 AM
tmroeder updated the diff for D4167: Add Forward-Edge Control-Flow Integrity support.

This patch addresses the most recent comments in the review.

Nov 10 2014, 11:30 AM

Oct 27 2014

tmroeder updated the diff for D4167: Add Forward-Edge Control-Flow Integrity support.

Forgot to remove "XFAIL win32" in the previous patch.

Oct 27 2014, 5:04 PM
tmroeder updated the diff for D4167: Add Forward-Edge Control-Flow Integrity support.

This patch addresses the most recent set of comments.

Oct 27 2014, 5:00 PM

Oct 24 2014

tmroeder updated the diff for D4167: Add Forward-Edge Control-Flow Integrity support.

Here's a diff that fixes the outstanding comments and removes ARM support for now, as discussed in previous comments.

Oct 24 2014, 11:19 AM

Oct 22 2014

tmroeder added a comment to D4167: Add Forward-Edge Control-Flow Integrity support.
In D4167#35, @jfb wrote:

Are the reviewers amenable to me splitting this into two pieces: one that deals with CFI and the x86 backend code, and one that deals with ARM?

Yes, as long as we figure out a nice way to point out that ARM support isn't there at the moment.

Oct 22 2014, 4:53 PM

Oct 21 2014

tmroeder added a comment to D4167: Add Forward-Edge Control-Flow Integrity support.

I just realized that there are two independent concerns here, and I'd like to separate them.

Oct 21 2014, 11:55 AM

Jul 29 2014

tmroeder added inline comments to D4167: Add Forward-Edge Control-Flow Integrity support.
Jul 29 2014, 10:02 AM

Jul 28 2014

tmroeder updated the diff for D4167: Add Forward-Edge Control-Flow Integrity support.

This version of the patch adds another virtual call to TargetInstrInfo to get a bound on the size of a jumptable entry, as discussed on llvmdev. This is used stored in JumpInstrTableInfo and used by ForwardControlFlowIntegrity to generate masks for jumps to jumptable entries. PTAL.

Jul 28 2014, 2:31 PM

Jul 17 2014

tmroeder updated the diff for D2873: An analysis to find external function pointers and trace their data flow.

This fixes comments from the recent review

Jul 17 2014, 10:08 AM

Jul 15 2014

tmroeder added inline comments to D4167: Add Forward-Edge Control-Flow Integrity support.
Jul 15 2014, 11:44 AM

Jul 14 2014

tmroeder added inline comments to D4167: Add Forward-Edge Control-Flow Integrity support.
Jul 14 2014, 2:34 PM

Jul 10 2014

tmroeder closed D3361: Add a jumptable attribute and support for creating jump-instruction tables.
Jul 10 2014, 2:47 PM
tmroeder accepted D3361: Add a jumptable attribute and support for creating jump-instruction tables.
Jul 10 2014, 2:46 PM
tmroeder abandoned D3292: Add a jumptable attribute + intrinsic + IR transform for jump-instruction tables.
Jul 10 2014, 2:45 PM
tmroeder abandoned D4127: Add an option to allow JumpInstrTables to set unnamed_addr and jumptable on all address-taken functions.
Jul 10 2014, 2:44 PM
tmroeder abandoned D4128: Add an option to allow JumpInstrTables to set unnamed_addr and jumptable on all address-taken functions.

Abandoning after it was decided that this problem would be address by a flag in clang.

Jul 10 2014, 2:44 PM
tmroeder updated the diff for D4167: Add Forward-Edge Control-Flow Integrity support.

This patch addresses the latest set of comments on the FCFI code.

Jul 10 2014, 2:42 PM
tmroeder added a comment to D4167: Add Forward-Edge Control-Flow Integrity support.

Comments on the current set of comments. I'm also about to update this with a patch that handles the other comments.

Jul 10 2014, 2:41 PM

Jul 1 2014

tmroeder added a comment to D4128: Add an option to allow JumpInstrTables to set unnamed_addr and jumptable on all address-taken functions.

Thanks for the comments. After the recent discussion with Nick about this issue on llvm-commits, I'm dropping -jump-table-all and will submit a patch to clang that adds support for an -ffcfi flag that will add unnamed_addr and jumptable to all functions instead. Please see D4167 for the FCFI LLVM side.

Jul 1 2014, 11:33 AM

Jun 30 2014

tmroeder updated the diff for D4167: Add Forward-Edge Control-Flow Integrity support.

This changes the FCFI code to drop all mention of JumpTableAll, as per the discussion on D4128 on llvm-commits; it will be up to the front end to set jumptable and unnamed_addr on functions that should be transformed by CFI.

Jun 30 2014, 10:06 AM