Page MenuHomePhabricator

tinloaf (Lukas Barth)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 31 2020, 7:28 AM (23 w, 2 d)

Recent Activity

May 4 2021

tinloaf updated the diff for D101748: Add inclusion filename filters to llvm-cov.
  • Suppress clang-tidy diagnostics for push_back
May 4 2021, 2:22 AM · Restricted Project

May 3 2021

tinloaf updated the diff for D101748: Add inclusion filename filters to llvm-cov.
  • Reformat
May 3 2021, 8:34 AM · Restricted Project
tinloaf updated the diff for D101748: Add inclusion filename filters to llvm-cov.
  • Fix logic for empty test sets
May 3 2021, 6:39 AM · Restricted Project
tinloaf added a comment to D101748: Add inclusion filename filters to llvm-cov.

I tested this locally and it seems to work; however, I would feel better if I had some tests for this (and the ignore-regex filters, too).

May 3 2021, 3:36 AM · Restricted Project
tinloaf requested review of D101748: Add inclusion filename filters to llvm-cov.
May 3 2021, 3:29 AM · Restricted Project

Jan 25 2021

tinloaf added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Fixed!

Jan 25 2021, 1:15 AM · Restricted Project, Restricted Project

Jan 24 2021

tinloaf added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

I did not re-accept this, because of the script change. I'm okay with it, but I never looked really at the script. I think it should be changed afterwards to error or warn again, but not on this enum. Maybe one could annotate enums which don't have to be fully documented?

Jan 24 2021, 1:15 PM · Restricted Project, Restricted Project
tinloaf added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Do you have commit access?

Jan 24 2021, 10:07 AM · Restricted Project, Restricted Project
tinloaf added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

If I understand the LLVM mailing list correctly, everything in the repo by the 26th will still go into LLVM 12, right? Any chance we could get this in by then?

Jan 24 2021, 5:02 AM · Restricted Project, Restricted Project

Jan 22 2021

tinloaf added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Jan 22 2021, 3:35 AM · Restricted Project, Restricted Project

Jan 21 2021

tinloaf accepted D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Jan 21 2021, 9:10 AM · Restricted Project, Restricted Project
tinloaf updated the diff for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Fix error introduced by rebase

Jan 21 2021, 7:17 AM · Restricted Project, Restricted Project
tinloaf accepted D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Jan 21 2021, 6:53 AM · Restricted Project, Restricted Project
tinloaf updated the diff for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Of course there was another merge conflict in the release notes. Mental note to self: Put release note changes in separate commit.

Jan 21 2021, 6:46 AM · Restricted Project, Restricted Project
tinloaf accepted D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Fixed the last spelling issues in the documentation. If the automated checks pass, this is ready for takeoff from my side. Thanks for your reviews!

Jan 21 2021, 6:43 AM · Restricted Project, Restricted Project
tinloaf updated the diff for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Fix spelling issues in doc

Jan 21 2021, 6:41 AM · Restricted Project, Restricted Project
tinloaf added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Jan 21 2021, 6:41 AM · Restricted Project, Restricted Project

Jan 20 2021

tinloaf added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

How is it going? I would like to add some new alignment options and it would be stupid not to do it on top of this.

Jan 20 2021, 1:13 AM · Restricted Project, Restricted Project

Jan 16 2021

tinloaf updated the diff for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Fixed documentation for the AlignConsecutive* options. I have used the suggested approach: Remove all documentation from AlignConsecutiveStyle and instead put the documentation of the possible values and what they do in the AlignConsecutive* options' docs.

Jan 16 2021, 4:33 AM · Restricted Project, Restricted Project

Jan 12 2021

tinloaf updated the diff for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Fixed formatting issue.

Jan 12 2021, 5:27 AM · Restricted Project, Restricted Project

Jan 10 2021

tinloaf added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Apart from my inline comment and the pre merge check this is superb. (I will not accept it, until we have reached a conclusion for the documentation.)

Jan 10 2021, 3:05 PM · Restricted Project, Restricted Project
tinloaf updated the diff for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Fix merge conflict in the release notes.

Jan 10 2021, 7:20 AM · Restricted Project, Restricted Project
tinloaf added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

This is now an all-in-one revision, including bit fields, assignments, declarations and macros. I did not reproduce the full "across empty lines, across comments, across empty lines *and* comments" test suite for all four of them, since they all use the same logic (and code, mostly). AlignConsecutiveAssignments is tested extensively, AlignConsecutiveBitFields and AlignConsecutiveDeclarations only have tests for AlignAcrossEmptyLinesAndComments (since they delegate to the same AlignTokens method), and AlignConsecutiveMacros has its own set of tests, since it uses a different implementation (of the same logic, basically).

Jan 10 2021, 7:16 AM · Restricted Project, Restricted Project
tinloaf added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Ideally we should add a comment to the release notes, (which you could do via a separate NFC commit if you wanted)

Thank, I'll do that. But before that, I will create a revision that adds the same feature for the other three alignment types.

I think it should happen in this revision so that it is atomically.

Jan 10 2021, 7:10 AM · Restricted Project, Restricted Project
tinloaf updated the diff for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
  • Unify the type of the options for AlignConsecutive{BitFields, Declarations, Assignments, Macros}
  • Implement across-alignment for bit fields, declarations, assignments and macros
  • Add tests for across-alignment for bit fields, declarations, assignments and macros
  • Add changelog entry
Jan 10 2021, 7:10 AM · Restricted Project, Restricted Project

Jan 5 2021

tinloaf added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Jan 5 2021, 3:32 AM · Restricted Project, Restricted Project

Jan 4 2021

tinloaf added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Jan 4 2021, 3:22 PM · Restricted Project, Restricted Project
tinloaf added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Ideally we should add a comment to the release notes, (which you could do via a separate NFC commit if you wanted)

Jan 4 2021, 9:23 AM · Restricted Project, Restricted Project
tinloaf updated the diff for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Fix bogus default case reported by clang-tidy.

Jan 4 2021, 7:22 AM · Restricted Project, Restricted Project
tinloaf added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Jan 4 2021, 5:01 AM · Restricted Project, Restricted Project
tinloaf updated the diff for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Address reviewer comments, noteworthy changes:

Jan 4 2021, 4:58 AM · Restricted Project, Restricted Project

Jan 3 2021

tinloaf added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Jan 3 2021, 12:46 PM · Restricted Project, Restricted Project
tinloaf added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Jan 3 2021, 10:21 AM · Restricted Project, Restricted Project
tinloaf updated the diff for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Address MyDeveloperDay's review comments.

Jan 3 2021, 10:19 AM · Restricted Project, Restricted Project
tinloaf updated the diff for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Fix formatting issue resulting from ancient clang-format.

Jan 3 2021, 7:43 AM · Restricted Project, Restricted Project
tinloaf added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Two remarks, first: I made the change only for AlignConsecutiveAssignments, but I think it should be consistent for AlignConsecutiveMacros, AlignConsecutiveBitFields and AlignConsecutiveDeclarations, as well. If this change is accepted, I will make corresponding changes to the other three.

Jan 3 2021, 4:35 AM · Restricted Project, Restricted Project
tinloaf requested review of D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Jan 3 2021, 4:33 AM · Restricted Project, Restricted Project