User Details
- User Since
- Dec 31 2020, 7:28 AM (9 w, 2 d)
Jan 25 2021
Jan 24 2021
If I understand the LLVM mailing list correctly, everything in the repo by the 26th will still go into LLVM 12, right? Any chance we could get this in by then?
Jan 22 2021
Jan 21 2021
Fix error introduced by rebase
Of course there was another merge conflict in the release notes. Mental note to self: Put release note changes in separate commit.
Fixed the last spelling issues in the documentation. If the automated checks pass, this is ready for takeoff from my side. Thanks for your reviews!
Fix spelling issues in doc
Jan 20 2021
Jan 16 2021
Fixed documentation for the AlignConsecutive* options. I have used the suggested approach: Remove all documentation from AlignConsecutiveStyle and instead put the documentation of the possible values and what they do in the AlignConsecutive* options' docs.
Jan 12 2021
Fixed formatting issue.
Jan 10 2021
Fix merge conflict in the release notes.
This is now an all-in-one revision, including bit fields, assignments, declarations and macros. I did not reproduce the full "across empty lines, across comments, across empty lines *and* comments" test suite for all four of them, since they all use the same logic (and code, mostly). AlignConsecutiveAssignments is tested extensively, AlignConsecutiveBitFields and AlignConsecutiveDeclarations only have tests for AlignAcrossEmptyLinesAndComments (since they delegate to the same AlignTokens method), and AlignConsecutiveMacros has its own set of tests, since it uses a different implementation (of the same logic, basically).
- Unify the type of the options for AlignConsecutive{BitFields, Declarations, Assignments, Macros}
- Implement across-alignment for bit fields, declarations, assignments and macros
- Add tests for across-alignment for bit fields, declarations, assignments and macros
- Add changelog entry
Jan 5 2021
Jan 4 2021
Fix bogus default case reported by clang-tidy.
Address reviewer comments, noteworthy changes:
Jan 3 2021
Address MyDeveloperDay's review comments.
Fix formatting issue resulting from ancient clang-format.
Two remarks, first: I made the change only for AlignConsecutiveAssignments, but I think it should be consistent for AlignConsecutiveMacros, AlignConsecutiveBitFields and AlignConsecutiveDeclarations, as well. If this change is accepted, I will make corresponding changes to the other three.