Page MenuHomePhabricator

timotheecour (Timothee Cour)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 26 2018, 8:49 PM (139 w, 1 d)

Recent Activity

Mar 14 2018

timotheecour updated the diff for D44321: Support demangling for D symbols via dlopen.
  • fix assert fail when plugin.language.D.pluginfile empty
Mar 14 2018, 4:59 PM · Restricted Project
timotheecour added a comment to D44321: Support demangling for D symbols via dlopen.

When druntime is initialized, a number of resources are allocated (e.g. memory and mutex). Yes you initialize druntime once, I can see that. You don't deinitialize druntime at all: that's the resource leak.

Mar 14 2018, 4:38 PM · Restricted Project
timotheecour added inline comments to D44321: Support demangling for D symbols via dlopen.
Mar 14 2018, 4:38 PM · Restricted Project
timotheecour updated the summary of D44321: Support demangling for D symbols via dlopen.
Mar 14 2018, 4:17 PM · Restricted Project
timotheecour added a comment to D44321: Support demangling for D symbols via dlopen.
Mar 14 2018, 4:15 PM · Restricted Project
timotheecour updated the diff for D44321: Support demangling for D symbols via dlopen.
  • added d_terminate
  • format
Mar 14 2018, 4:08 PM · Restricted Project

Mar 13 2018

timotheecour added a comment to D44321: Support demangling for D symbols via dlopen.

Actually, this is not the correct interface is it? The returned pointer should point to newly allocated memory using malloc, right?
Good to document that somewhere.

Mar 13 2018, 7:11 PM · Restricted Project
timotheecour updated the diff for D44321: Support demangling for D symbols via dlopen.
  • document C interface
Mar 13 2018, 7:11 PM · Restricted Project

Mar 10 2018

timotheecour added a comment to D44321: Support demangling for D symbols via dlopen.

Note that the D plugin is not loaded by default (so default behavior is not affected) ; it's only loaded if user adds to his .lldbinit:
settings set plugin.language.D.pluginfile "path_to/liblldbdplugin.dylib"

Mar 10 2018, 8:22 PM · Restricted Project
timotheecour added a comment to D44321: Support demangling for D symbols via dlopen.

It's a little more complicated for D because it's an out-of-tree compiler so it poses interesting challenges.

Mar 10 2018, 8:21 PM · Restricted Project
timotheecour updated the summary of D44321: Support demangling for D symbols via dlopen.
Mar 10 2018, 8:19 PM · Restricted Project
timotheecour updated the diff for D44321: Support demangling for D symbols via dlopen.
  • added doc
Mar 10 2018, 8:15 PM · Restricted Project
timotheecour added a comment to D44321: Support demangling for D symbols via dlopen.

update: we can now set lldbdplugin in .lldbinit via settings set plugin.language.D.pluginfile so this avoids hardcoding that file

Mar 10 2018, 8:11 PM · Restricted Project
timotheecour updated the diff for D44321: Support demangling for D symbols via dlopen.
  • format
  • use llvm::sys::DynamicLibrary
  • added DLanguageProperties
Mar 10 2018, 8:08 PM · Restricted Project
timotheecour added a comment to D44321: Support demangling for D symbols via dlopen.

This patch has no testcase. It shouldn't be particularly hard to write one, you can take inspiration from the one in lit/.

Thanks!

Mar 10 2018, 3:23 PM · Restricted Project
timotheecour added inline comments to D44321: Support demangling for D symbols via dlopen.
Mar 10 2018, 2:24 PM · Restricted Project
timotheecour updated the diff for D44321: Support demangling for D symbols via dlopen.
  • use llvm::sys::DynamicLibrary
  • format
Mar 10 2018, 2:22 PM · Restricted Project
timotheecour added inline comments to D44321: Support demangling for D symbols via dlopen.
Mar 10 2018, 1:54 PM · Restricted Project
timotheecour updated the diff for D44321: Support demangling for D symbols via dlopen.
  • format
  • format
  • fixup
Mar 10 2018, 1:54 PM · Restricted Project

Mar 9 2018

timotheecour updated the summary of D44321: Support demangling for D symbols via dlopen.
Mar 9 2018, 1:17 PM · Restricted Project
timotheecour updated the summary of D44321: Support demangling for D symbols via dlopen.
Mar 9 2018, 1:13 PM · Restricted Project
timotheecour updated the summary of D44321: Support demangling for D symbols via dlopen.
Mar 9 2018, 12:51 PM · Restricted Project
timotheecour updated the summary of D44321: Support demangling for D symbols via dlopen.
Mar 9 2018, 12:41 PM · Restricted Project
timotheecour updated the summary of D44321: Support demangling for D symbols via dlopen.
Mar 9 2018, 12:41 PM · Restricted Project
timotheecour created D44321: Support demangling for D symbols via dlopen.
Mar 9 2018, 12:28 PM · Restricted Project