Page MenuHomePhabricator

tiagoma (Tiago Macarios)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 12 2020, 4:48 PM (123 w, 17 h)

Recent Activity

Feb 3 2022

tiagoma accepted D118902: [libc++] Fix chrono::duration constructor constraint.
Feb 3 2022, 8:56 AM · Restricted Project
tiagoma added a comment to D118902: [libc++] Fix chrono::duration constructor constraint.

Thanks for your patch!

Can you please add a test for this? The correct file seems like it should be libcxx/test/std/utilities/time/time.duration/time.duration.cons/rep.pass.cpp.

Also, if you need someone to commit this for you, please provide Author Name <email@domain> for commit attribution.

Feb 3 2022, 7:18 AM · Restricted Project
tiagoma updated the diff for D118902: [libc++] Fix chrono::duration constructor constraint.
Feb 3 2022, 7:17 AM · Restricted Project
tiagoma requested review of D118902: [libc++] Fix chrono::duration constructor constraint.
Feb 3 2022, 6:50 AM · Restricted Project

Oct 12 2021

tiagoma added a comment to D95168: [clang-format] Add Insert/Remove Braces option.

go for it

Oct 12 2021, 8:01 PM · Restricted Project, Restricted Project

Aug 23 2021

tiagoma added a comment to D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables.

thanks for your testing! i will look at the __unaligned issue, not sure if clang supports it, its an MSVC extension, is it?

Aug 23 2021, 1:56 PM · Restricted Project, Restricted Project, Restricted Project

Aug 19 2021

tiagoma added a comment to D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables.

I am getting false positives with

Aug 19 2021, 4:19 PM · Restricted Project, Restricted Project, Restricted Project
tiagoma added inline comments to D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables.
Aug 19 2021, 7:18 AM · Restricted Project, Restricted Project, Restricted Project

Aug 18 2021

tiagoma updated subscribers of D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables.

I applied the patch on top of the clang13 RC and It seems not to be
generating any replacements. I haven't had the time to dig and understand
why. Diagnostics seem to be correct.

Aug 18 2021, 11:35 PM · Restricted Project, Restricted Project, Restricted Project

Mar 17 2021

tiagoma added a comment to D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables.

Can we get this in? I work in Microsoft Office and we have been using this checker and it works great! There are a couple of issues with it and I would like to contribute fixes.

Mar 17 2021, 6:18 PM · Restricted Project, Restricted Project, Restricted Project

Feb 8 2021

tiagoma updated the diff for D95168: [clang-format] Add Insert/Remove Braces option.

Add support for do/while

Feb 8 2021, 4:33 PM · Restricted Project, Restricted Project

Feb 4 2021

tiagoma added inline comments to D95168: [clang-format] Add Insert/Remove Braces option.
Feb 4 2021, 4:35 PM · Restricted Project, Restricted Project
tiagoma updated the diff for D95168: [clang-format] Add Insert/Remove Braces option.

Add more tests

Feb 4 2021, 4:28 PM · Restricted Project, Restricted Project

Jan 22 2021

tiagoma updated the diff for D95168: [clang-format] Add Insert/Remove Braces option.

Update comments

Jan 22 2021, 10:09 AM · Restricted Project, Restricted Project
tiagoma added inline comments to D95168: [clang-format] Add Insert/Remove Braces option.
Jan 22 2021, 9:56 AM · Restricted Project, Restricted Project

Jan 21 2021

tiagoma added a comment to D95168: [clang-format] Add Insert/Remove Braces option.

Some background might be useful. I work at Microsoft (Office to be precise). We have our own fork of LLVM internally and I am starting to upstream some of the changes in our fork.

Jan 21 2021, 3:30 PM · Restricted Project, Restricted Project
tiagoma added a reviewer for D95168: [clang-format] Add Insert/Remove Braces option: curdeius.
Jan 21 2021, 1:26 PM · Restricted Project, Restricted Project
tiagoma added a reviewer for D95168: [clang-format] Add Insert/Remove Braces option: MyDeveloperDay.
Jan 21 2021, 1:24 PM · Restricted Project, Restricted Project
tiagoma requested review of D95168: [clang-format] Add Insert/Remove Braces option.
Jan 21 2021, 1:22 PM · Restricted Project, Restricted Project