In D118902#3293588, @ldionne wrote:

Thanks for your patch!

Can you please add a test for this? The correct file seems like it should be libcxx/test/std/utilities/time/time.duration/time.duration.cons/rep.pass.cpp.

Also, if you need someone to commit this for you, please provide Author Name <email@domain> for commit attribution.

go for it

In D54943#2959546, @JonasToth wrote:

thanks for your testing! i will look at the __unaligned issue, not sure if clang supports it, its an MSVC extension, is it?

I am getting false positives with

I applied the patch on top of the clang13 RC and It seems not to be
generating any replacements. I haven't had the time to dig and understand
why. Diagnostics seem to be correct.

Can we get this in? I work in Microsoft Office and we have been using this checker and it works great! There are a couple of issues with it and I would like to contribute fixes.

Add support for do/while

Add more tests

Update comments

Some background might be useful. I work at Microsoft (Office to be precise). We have our own fork of LLVM internally and I am starting to upstream some of the changes in our fork.