Page MenuHomePhabricator

thrimbor (Stefan Schmidt)
User

Projects

User does not belong to any projects.

User Details

User Since
May 20 2019, 12:58 AM (104 w, 1 d)

Recent Activity

Oct 8 2019

thrimbor added a comment to D68352: [lld] Don't create hints-section if Hint/Name Table is empty.

Without the -debug parameter the test can be false positive as it won't reach the assert in the PDB code (in addLinkerModuleCoffGroup) then

Oct 8 2019, 11:43 PM · Restricted Project
thrimbor updated the diff for D68352: [lld] Don't create hints-section if Hint/Name Table is empty.
Oct 8 2019, 11:25 PM · Restricted Project
thrimbor added a comment to D68352: [lld] Don't create hints-section if Hint/Name Table is empty.

but I'd like to understand what is going on. Are you at the repo head?

Oct 8 2019, 11:25 PM · Restricted Project
thrimbor added a comment to D68352: [lld] Don't create hints-section if Hint/Name Table is empty.

The output on my Arch Linux machine matches the strings the test checks for - is it normal for these values to change? Should we ignore them?

Oct 8 2019, 10:35 PM · Restricted Project
thrimbor updated the diff for D68352: [lld] Don't create hints-section if Hint/Name Table is empty.
Oct 8 2019, 9:41 PM · Restricted Project
thrimbor added a comment to D68352: [lld] Don't create hints-section if Hint/Name Table is empty.

I updated the patch to add --match-full-lines as requested. Can you commit the patch for me, as I don't have commit access?

Oct 8 2019, 9:41 PM · Restricted Project
thrimbor added a comment to D68352: [lld] Don't create hints-section if Hint/Name Table is empty.

So, you are creating an executable that has an import table that has only ordinals. Is my understanding correct? Indeed, that condition is rare and I've thought of that case before when I implemented this part.

Yes, that's what we were having issues with.

Oct 8 2019, 2:31 AM · Restricted Project
thrimbor added inline comments to D68352: [lld] Don't create hints-section if Hint/Name Table is empty.
Oct 8 2019, 2:31 AM · Restricted Project
thrimbor updated the diff for D68352: [lld] Don't create hints-section if Hint/Name Table is empty.
Oct 8 2019, 2:13 AM · Restricted Project

Oct 7 2019

thrimbor added a comment to D68352: [lld] Don't create hints-section if Hint/Name Table is empty.

I updated the patch and included a test case. I ran the test case before and after the change to make sure it behaves and tests correctly.

Oct 7 2019, 8:59 PM · Restricted Project
thrimbor updated the diff for D68352: [lld] Don't create hints-section if Hint/Name Table is empty.
Oct 7 2019, 8:57 PM · Restricted Project
thrimbor retitled D68352: [lld] Don't create hints-section if Hint/Name Table is empty from [lld] Handle sections without chunks during PDB generation to [lld] Don't create hints-section if Hint/Name Table is empty.
Oct 7 2019, 8:56 PM · Restricted Project

Oct 6 2019

thrimbor added a comment to D68352: [lld] Don't create hints-section if Hint/Name Table is empty.

Thanks for taking the time to give me some suggestions.

Oct 6 2019, 11:34 PM · Restricted Project

Oct 3 2019

thrimbor added a reviewer for D68352: [lld] Don't create hints-section if Hint/Name Table is empty: aganea.
Oct 3 2019, 5:01 PM · Restricted Project

Oct 2 2019

thrimbor added a comment to D68352: [lld] Don't create hints-section if Hint/Name Table is empty.

To be honest, I know almost nothing about PDB. I'm only changing this because I traced my own build problems to it (Xbox-specific, we're creating xbe-files from relocatable PE files including DWARF-4 debug info generated by clang - log can be found here.
This patch resolves the issues we've encountered when building on platforms that updated to LLD 9, but I don't know whether this is an appropriate (or correct) solution. I also don't know how I would construct a test case for this.

Oct 2 2019, 12:04 PM · Restricted Project
thrimbor added a reviewer for D68352: [lld] Don't create hints-section if Hint/Name Table is empty: ruiu.
Oct 2 2019, 11:55 AM · Restricted Project
thrimbor created D68352: [lld] Don't create hints-section if Hint/Name Table is empty.
Oct 2 2019, 11:55 AM · Restricted Project

Aug 31 2019

thrimbor added a comment to D66986: [libc++] Fix directory_iterator compilation on Win32.

Thanks for accepting! Can you commit the patch for me? I don't have commit access myself.

Aug 31 2019, 3:49 PM · Restricted Project

Aug 29 2019

thrimbor created D66986: [libc++] Fix directory_iterator compilation on Win32.
Aug 29 2019, 5:41 PM · Restricted Project

May 21 2019

thrimbor updated the summary of D62175: [llvm-dlltool] Respect NONAME keyword.
May 21 2019, 12:53 AM · Restricted Project
thrimbor updated the diff for D62124: [LLD][COFF] Implement /filealign parameter.

I updated the patch to include a power-of-two check.

May 21 2019, 12:33 AM · Restricted Project

May 20 2019

thrimbor created D62175: [llvm-dlltool] Respect NONAME keyword.
May 20 2019, 11:50 PM · Restricted Project
thrimbor added a comment to D62124: [LLD][COFF] Implement /filealign parameter.

Did you personally need this? Or are you adding this just for completeness?

Either case is fine, but I'd like to know what is a use case of this feature.

May 20 2019, 9:55 PM · Restricted Project
thrimbor updated the summary of D62124: [LLD][COFF] Implement /filealign parameter.
May 20 2019, 6:35 PM · Restricted Project
thrimbor updated the diff for D62124: [LLD][COFF] Implement /filealign parameter.

Changed Config member name, added a test.

May 20 2019, 6:29 PM · Restricted Project
thrimbor created D62124: [LLD][COFF] Implement /filealign parameter.
May 20 2019, 1:11 AM · Restricted Project