Page MenuHomePhabricator

thomasjohns (Thomas Johnson)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 17 2021, 8:37 AM (24 w, 6 d)

Recent Activity

Aug 24 2021

thomasjohns requested review of D108672: [ARC] Add ADC (addition with carry) and SBC (subtraction with carry) instructions.
Aug 24 2021, 4:12 PM · Restricted Project
thomasjohns updated the diff for D108598: [ARC] Add codegen for the readcyclecounter intrinsic along with disassembly for associated instructions.

Separate S12 and U6 single operand decoding into different methods. Check legality of i64 in ARCISelLowering.

Aug 24 2021, 9:09 AM · Restricted Project
thomasjohns added inline comments to D108598: [ARC] Add codegen for the readcyclecounter intrinsic along with disassembly for associated instructions.
Aug 24 2021, 8:40 AM · Restricted Project

Aug 23 2021

thomasjohns added inline comments to D108598: [ARC] Add codegen for the readcyclecounter intrinsic along with disassembly for associated instructions.
Aug 23 2021, 4:58 PM · Restricted Project
thomasjohns requested review of D108598: [ARC] Add codegen for the readcyclecounter intrinsic along with disassembly for associated instructions.
Aug 23 2021, 4:53 PM · Restricted Project

Aug 10 2021

thomasjohns updated the diff for D107828: [ARC] Add codegen for count trailing zeros intrinsic for the ARC backend.

Attempt to fix clang-tidy lints in ARCExpandPseudos.cpp.

Aug 10 2021, 9:43 AM · Restricted Project
thomasjohns requested review of D107828: [ARC] Add codegen for count trailing zeros intrinsic for the ARC backend.
Aug 10 2021, 7:50 AM · Restricted Project

Aug 6 2021

thomasjohns updated the diff for D107611: [ARC] Add codegen for llvm.ctlz intrinsic for the ARC backend.

Thanks for the feedback, Mark.

Aug 6 2021, 11:33 AM · Restricted Project, Restricted Project
thomasjohns updated the diff for D107611: [ARC] Add codegen for llvm.ctlz intrinsic for the ARC backend.

llvm clang-tidy rule: prefer Register over unsinged int.

Aug 6 2021, 8:33 AM · Restricted Project, Restricted Project

Aug 5 2021

thomasjohns updated the diff for D107611: [ARC] Add codegen for llvm.ctlz intrinsic for the ARC backend.

Fix missing } after bad merge. Move CTLZ next to other pseudo instructions.

Aug 5 2021, 5:05 PM · Restricted Project, Restricted Project
thomasjohns added inline comments to D107611: [ARC] Add codegen for llvm.ctlz intrinsic for the ARC backend.
Aug 5 2021, 4:51 PM · Restricted Project, Restricted Project
thomasjohns added inline comments to D107611: [ARC] Add codegen for llvm.ctlz intrinsic for the ARC backend.
Aug 5 2021, 4:48 PM · Restricted Project, Restricted Project
thomasjohns requested review of D107611: [ARC] Add codegen for llvm.ctlz intrinsic for the ARC backend.
Aug 5 2021, 4:21 PM · Restricted Project, Restricted Project

Jul 29 2021

thomasjohns accepted D107118: [ARC] Add norm/normh instructions with disassembly tests.
Jul 29 2021, 5:15 PM · Restricted Project
thomasjohns added a comment to D107118: [ARC] Add norm/normh instructions with disassembly tests.

Looks good to me

Jul 29 2021, 5:15 PM · Restricted Project
thomasjohns updated the diff for D107088: [ARC] Add additional mov immediate instruction formats with a fix for u6 decoding.

Make register numbers and immediate values more varied in decoder tests.

Jul 29 2021, 1:37 PM · Restricted Project
thomasjohns added inline comments to D107088: [ARC] Add additional mov immediate instruction formats with a fix for u6 decoding.
Jul 29 2021, 12:13 PM · Restricted Project
thomasjohns added inline comments to D107088: [ARC] Add additional mov immediate instruction formats with a fix for u6 decoding.
Jul 29 2021, 10:40 AM · Restricted Project
thomasjohns requested review of D107088: [ARC] Add additional mov immediate instruction formats with a fix for u6 decoding.
Jul 29 2021, 10:32 AM · Restricted Project

Jul 22 2021

thomasjohns requested review of D106602: Add tablegen definition for the Find Leading Set (FLS) instruction for the ARC backend.
Jul 22 2021, 2:52 PM · Restricted Project

Jul 21 2021

thomasjohns updated the diff for D106497: Add disassembly for the conditioned RSUB immediate instruction for the ARC backend.

Annotate that _cc_f_rru6 uses STATUS32 flag.

Jul 21 2021, 4:17 PM · Restricted Project
thomasjohns added inline comments to D106497: Add disassembly for the conditioned RSUB immediate instruction for the ARC backend.
Jul 21 2021, 3:22 PM · Restricted Project
thomasjohns requested review of D106497: Add disassembly for the conditioned RSUB immediate instruction for the ARC backend.
Jul 21 2021, 2:27 PM · Restricted Project

Jul 8 2021

thomasjohns added inline comments to D105560: Add disassembly for the conditioned move immediate instruction for the ARC backend.
Jul 8 2021, 10:14 AM · Restricted Project
thomasjohns added inline comments to D105560: Add disassembly for the conditioned move immediate instruction for the ARC backend.
Jul 8 2021, 10:03 AM · Restricted Project
thomasjohns updated the diff for D105560: Add disassembly for the conditioned move immediate instruction for the ARC backend.

Fix the straightforward clang-tidy lints.

Jul 8 2021, 9:03 AM · Restricted Project

Jul 7 2021

thomasjohns added a comment to D105560: Add disassembly for the conditioned move immediate instruction for the ARC backend.

Do we also need a LIT testcase for this under llvm/test/CodeGen/ARC?

Jul 7 2021, 1:14 PM · Restricted Project
thomasjohns added a comment to D105560: Add disassembly for the conditioned move immediate instruction for the ARC backend.

Could you fix the issues reported by clang-tidy?

Jul 7 2021, 1:09 PM · Restricted Project
thomasjohns requested review of D105560: Add disassembly for the conditioned move immediate instruction for the ARC backend.
Jul 7 2021, 9:50 AM · Restricted Project

Jun 18 2021

thomasjohns requested review of D104558: Add norm sub-target feature to table gen for ARC.
Jun 18 2021, 11:07 AM · Restricted Project