Page MenuHomePhabricator

thomasfinch (Thomas Finch)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 26 2019, 12:31 PM (126 w, 5 h)

Recent Activity

Apr 3 2020

thomasfinch accepted D76512: [YAMLParser] Scanner::setError - ensure we use the StringRef::iterator argument (PR45043).
Apr 3 2020, 10:15 AM · Restricted Project

Nov 7 2019

thomasfinch created D69974: Fix null dereference in yaml::Document::skip.
Nov 7 2019, 3:14 PM · Restricted Project

Nov 4 2019

thomasfinch updated the diff for D61608: YAML parser robustness improvements.
  • Revert uses of dyn_cast_or_null
Nov 4 2019, 6:02 PM · Restricted Project
thomasfinch updated the diff for D61608: YAML parser robustness improvements.

Rebasing on monorepo

Nov 4 2019, 11:07 AM · Restricted Project

Oct 30 2019

thomasfinch added a comment to D61608: YAML parser robustness improvements.

@Bigcheese Thanks! Could you please merge this, I don't have commit access.

Oct 30 2019, 2:49 PM · Restricted Project

Sep 12 2019

thomasfinch updated the diff for D61608: YAML parser robustness improvements.

Remove trailing spaces in KeyValueNode::getValue

Sep 12 2019, 12:45 PM · Restricted Project
thomasfinch updated the diff for D61608: YAML parser robustness improvements.

Update diff based on feedback.

  • Update error message in Scanner::consume
  • Update error message in ScalarNode::unescapeDoubleQuoted
  • Remove setError call when failing to find a SimpleKey in the token queue
Sep 12 2019, 12:41 PM · Restricted Project

Sep 5 2019

thomasfinch abandoned D67243: Add crash-triggering test case and more null checks in YAML parser.

Accidental push...

Sep 5 2019, 3:44 PM · Restricted Project
thomasfinch created D67243: Add crash-triggering test case and more null checks in YAML parser.
Sep 5 2019, 3:41 PM · Restricted Project
thomasfinch updated the diff for D61608: YAML parser robustness improvements.

Split test cases apart, added a few more bug fixes

Sep 5 2019, 10:28 AM · Restricted Project

Jun 10 2019

thomasfinch updated the diff for D61608: YAML parser robustness improvements.

Move error checking to Document::parseBlockNode, make sure Document::skip doesn't crash if getRoot returns null.

Jun 10 2019, 2:43 PM · Restricted Project

May 6 2019

thomasfinch added a reviewer for D61608: YAML parser robustness improvements: Bigcheese.
May 6 2019, 2:50 PM · Restricted Project
thomasfinch updated the summary of D61608: YAML parser robustness improvements.
May 6 2019, 1:23 PM · Restricted Project
thomasfinch created D61608: YAML parser robustness improvements.
May 6 2019, 1:18 PM · Restricted Project