Page MenuHomePhabricator

thebolt (Marten Svanfeldt)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 18 2017, 4:29 AM (87 w, 2 d)

Recent Activity

Feb 20 2018

thebolt added a comment to D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations.

As before, I don't have any commit access so would appreciate if someone else picks it up.

Feb 20 2018, 6:18 AM

Feb 19 2018

thebolt updated the diff for D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations.

Updated coding style as per feedback from @rogfer01

Feb 19 2018, 2:59 AM
thebolt added inline comments to D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations.
Feb 19 2018, 1:37 AM
thebolt added a comment to D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations.

Ping? As this revision now has been tested to not break in the same way the first (accepted) version did, could someone please re-review? If the current subscribers are not right, who should I add as reviewer?

Feb 19 2018, 12:57 AM

Feb 7 2018

thebolt updated the diff for D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations.

Updated with fixes for the misspelled comments.
Also added two test-cases to catch invalid transformations (such as the ones causing problems earlier).

Feb 7 2018, 2:39 AM

Feb 6 2018

thebolt added a comment to D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations.

@yroux did the entire build and verification pass? If so I will tomorrow (when I have my work computer) upload a new version of the diff with the comment fixes, and then hope it can be approved/commited without breaking anything this time.

Feb 6 2018, 11:41 AM

Feb 2 2018

thebolt added a comment to D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations.

I have corrected the typos in my code, I will however await further functional testing before submitting a new (hopefully final) version

Feb 2 2018, 2:20 AM
thebolt requested review of D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations.
Feb 2 2018, 12:32 AM
thebolt reopened D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations.
Feb 2 2018, 12:31 AM
thebolt updated the diff for D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations.

This update hopefully solves the issues found by @eugenis

Feb 2 2018, 12:30 AM

Feb 1 2018

thebolt added a comment to D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations.

I'm looking into it right now.

Feb 1 2018, 3:58 AM

Jan 29 2018

thebolt added a comment to D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations.

I don't have any commit rights so would be happy if someone else picks it up

Jan 29 2018, 8:00 AM
thebolt updated the diff for D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations.

Incorporated changes based on comment from Roger Ferrer regarding unnecessary KVal variable.

Jan 29 2018, 2:28 AM

Jan 28 2018

thebolt updated the diff for D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations.

Updated variable names to conform with coding style as per comments

Jan 28 2018, 10:41 PM

Jan 26 2018

thebolt added reviewers for D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations: fhahn, pbarrio.
Jan 26 2018, 4:55 AM
thebolt created D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations.
Jan 26 2018, 4:37 AM

Dec 19 2017

thebolt added a comment to D41348: [ARM] Lower unsigned saturation to USAT .

I don't have any commit rights so would be happy if someone else picks it up

Dec 19 2017, 12:37 PM
thebolt updated the diff for D41348: [ARM] Lower unsigned saturation to USAT .

Add tests for ARMv6 (non-thumb)

Dec 19 2017, 6:03 AM

Dec 18 2017

thebolt added a comment to D41348: [ARM] Lower unsigned saturation to USAT .

I've updated the diff based on the comments, also regenerated the diff with more context as per the instructions on llvm site.

Dec 18 2017, 12:36 PM
thebolt updated the diff for D41348: [ARM] Lower unsigned saturation to USAT .

Updated based on review.
Removed extra white space changes, extra braces and left-in debug code.

Dec 18 2017, 5:40 AM
thebolt created D41348: [ARM] Lower unsigned saturation to USAT .
Dec 18 2017, 4:49 AM