Page MenuHomePhabricator

tekknolagi (Max Bernstein)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2018, 3:30 PM (106 w, 3 d)

Recent Activity

Oct 29 2018

tekknolagi updated the diff for D53206: Allow padding checker to traverse simple class hierarchies.

Skip non-definitions in VisitRecord

Oct 29 2018, 1:55 PM · Restricted Project

Oct 26 2018

tekknolagi added inline comments to D53206: Allow padding checker to traverse simple class hierarchies.
Oct 26 2018, 11:47 AM · Restricted Project

Oct 25 2018

tekknolagi added a comment to D53206: Allow padding checker to traverse simple class hierarchies.

@NoQ I think @alexshap will be committing this. Thanks

Oct 25 2018, 7:57 PM · Restricted Project
tekknolagi updated the diff for D53206: Allow padding checker to traverse simple class hierarchies.

Add comments suggested by @NoQ and @bcraig

Oct 25 2018, 5:52 PM · Restricted Project
tekknolagi added inline comments to D53206: Allow padding checker to traverse simple class hierarchies.
Oct 25 2018, 5:32 PM · Restricted Project

Oct 24 2018

tekknolagi added a comment to D53206: Allow padding checker to traverse simple class hierarchies.

Ping @NoQ @george.karpenkov

Oct 24 2018, 11:05 AM · Restricted Project

Oct 22 2018

tekknolagi updated the diff for D53206: Allow padding checker to traverse simple class hierarchies.

Make the test case a little easier to read

Oct 22 2018, 12:29 PM · Restricted Project
tekknolagi added inline comments to D53206: Allow padding checker to traverse simple class hierarchies.
Oct 22 2018, 12:28 PM · Restricted Project
tekknolagi updated the summary of D53206: Allow padding checker to traverse simple class hierarchies.
Oct 22 2018, 12:26 PM · Restricted Project
tekknolagi updated the summary of D53206: Allow padding checker to traverse simple class hierarchies.
Oct 22 2018, 11:48 AM · Restricted Project
tekknolagi updated the diff for D53206: Allow padding checker to traverse simple class hierarchies.

Remove useless test case in padding_cpp.cpp

Oct 22 2018, 11:46 AM · Restricted Project
tekknolagi added inline comments to D53206: Allow padding checker to traverse simple class hierarchies.
Oct 22 2018, 11:33 AM · Restricted Project

Oct 12 2018

tekknolagi updated the diff for D53206: Allow padding checker to traverse simple class hierarchies.

Fix confusing & wrong if-statements, add new test suggested by @bcraig

Oct 12 2018, 3:08 PM · Restricted Project
tekknolagi added inline comments to D53206: Allow padding checker to traverse simple class hierarchies.
Oct 12 2018, 2:47 PM · Restricted Project
tekknolagi edited reviewers for D53206: Allow padding checker to traverse simple class hierarchies, added: dcoughlin; removed: malcolm.parsons.

Sorry @malcolm.parsons -- I misunderstood code owners. Should not have just looked at a blame of the file...

Oct 12 2018, 2:43 PM · Restricted Project
tekknolagi added a reviewer for D53206: Allow padding checker to traverse simple class hierarchies: malcolm.parsons.
Oct 12 2018, 1:59 PM · Restricted Project
tekknolagi created D53206: Allow padding checker to traverse simple class hierarchies.
Oct 12 2018, 9:58 AM · Restricted Project