Page MenuHomePhabricator

tabloid.adroit (Yuanfang Chen)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
Nov 19 2013, 9:02 PM (287 w, 13 m)

Recent Activity

Fri, May 3

tabloid.adroit added a comment to D57646: [libcxx] Specify unwind lib before other system libraries..

Hi ldionne, I definitely agree install_name_tool is not a desired solution. I've also added some comments so people realize the issue when modifying the code.

Fri, May 3, 2:25 PM · Restricted Project
tabloid.adroit updated the diff for D57646: [libcxx] Specify unwind lib before other system libraries..
  • add comment
Fri, May 3, 2:21 PM · Restricted Project
tabloid.adroit added a comment to D57646: [libcxx] Specify unwind lib before other system libraries..

I'll admit that I find it very brittle that ordering matters. We can do this, however it would be better to find another solution that doesn't require depending on the ordering of -l parameters. I don't know what that would be, though.

Fri, May 3, 11:21 AM · Restricted Project
tabloid.adroit updated the diff for D57646: [libcxx] Specify unwind lib before other system libraries..

rebase

Fri, May 3, 10:56 AM · Restricted Project

Apr 9 2019

tabloid.adroit added inline comments to D60488: [AsmPrinter] refactor to remove remove AsmVariant. NFC.
Apr 9 2019, 3:28 PM · Restricted Project

Mar 27 2019

tabloid.adroit added a reviewer for D59707: On Mac, try use commandline tools first instead of 'open' for dot files: anemet.
Mar 27 2019, 8:06 AM · Restricted Project

Mar 22 2019

tabloid.adroit created D59707: On Mac, try use commandline tools first instead of 'open' for dot files.
Mar 22 2019, 10:37 AM · Restricted Project

Mar 1 2019

tabloid.adroit added a comment to D57646: [libcxx] Specify unwind lib before other system libraries..

Could you please commit this for me? Thanks.

Mar 1 2019, 3:36 PM · Restricted Project

Feb 28 2019

tabloid.adroit updated the diff for D57496: Specify unwind lib before other system libraries..
  • rebase
Feb 28 2019, 6:38 PM · Restricted Project

Feb 3 2019

tabloid.adroit updated the diff for D57646: [libcxx] Specify unwind lib before other system libraries..
  • update
Feb 3 2019, 1:50 AM · Restricted Project
tabloid.adroit created D57646: [libcxx] Specify unwind lib before other system libraries..
Feb 3 2019, 1:46 AM · Restricted Project

Feb 2 2019

Herald added a project to D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer=': Restricted Project.

ping

Feb 2 2019, 6:19 PM · Restricted Project
tabloid.adroit added a comment to D57496: Specify unwind lib before other system libraries..

Could you please commit this for me? Thank you!

Feb 2 2019, 6:18 PM · Restricted Project

Feb 1 2019

tabloid.adroit added a comment to D57496: Specify unwind lib before other system libraries..

address comment

Feb 1 2019, 9:39 PM · Restricted Project
tabloid.adroit updated the diff for D57496: Specify unwind lib before other system libraries..
  • also change static lib linking order for consistency
Feb 1 2019, 9:39 PM · Restricted Project

Jan 30 2019

tabloid.adroit updated the summary of D57496: Specify unwind lib before other system libraries..
Jan 30 2019, 8:43 PM · Restricted Project
tabloid.adroit created D57496: Specify unwind lib before other system libraries..
Jan 30 2019, 8:17 PM · Restricted Project

Jan 17 2019

tabloid.adroit added inline comments to D55877: [LIR] Add CTTZ support part2.
Jan 17 2019, 4:39 AM
tabloid.adroit updated the diff for D55877: [LIR] Add CTTZ support part2.
  • update
Jan 17 2019, 4:39 AM

Jan 16 2019

tabloid.adroit added inline comments to D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='.
Jan 16 2019, 10:58 PM · Restricted Project
tabloid.adroit updated the diff for D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='.

Thanks for the review!

  • address comments
Jan 16 2019, 10:55 PM · Restricted Project
tabloid.adroit retitled D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer=' from Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer=' to Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='.
Jan 16 2019, 8:26 PM · Restricted Project

Jan 11 2019

tabloid.adroit added a comment to D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='.

gentle ping

Jan 11 2019, 5:58 PM · Restricted Project
tabloid.adroit added a comment to D56351: Replace function attributes "no-frame-pointer-elim" and "no-frame-pointer-elim-non-leaf" with "frame-pointer".

Thanks! Comment addressed. Could you help me check in this?

Jan 11 2019, 5:56 PM
tabloid.adroit updated the diff for D56351: Replace function attributes "no-frame-pointer-elim" and "no-frame-pointer-elim-non-leaf" with "frame-pointer".
  • update comment
Jan 11 2019, 5:45 PM
tabloid.adroit added inline comments to D55877: [LIR] Add CTTZ support part2.
Jan 11 2019, 5:53 AM
tabloid.adroit updated the diff for D55877: [LIR] Add CTTZ support part2.
  • allow non-constant CntPhi base
Jan 11 2019, 1:01 AM

Jan 5 2019

tabloid.adroit added a comment to D55877: [LIR] Add CTTZ support part2.

gentle ping

Jan 5 2019, 6:55 PM
tabloid.adroit added a comment to D55915: [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer.

https://reviews.llvm.org/D56351
https://reviews.llvm.org/D56353

Jan 5 2019, 4:46 AM
tabloid.adroit created D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='.
Jan 5 2019, 4:42 AM · Restricted Project
tabloid.adroit updated the summary of D56351: Replace function attributes "no-frame-pointer-elim" and "no-frame-pointer-elim-non-leaf" with "frame-pointer".
Jan 5 2019, 1:39 AM
tabloid.adroit updated the summary of D56351: Replace function attributes "no-frame-pointer-elim" and "no-frame-pointer-elim-non-leaf" with "frame-pointer".
Jan 5 2019, 1:38 AM
tabloid.adroit updated the summary of D56351: Replace function attributes "no-frame-pointer-elim" and "no-frame-pointer-elim-non-leaf" with "frame-pointer".
Jan 5 2019, 12:33 AM
tabloid.adroit removed a reviewer for D56351: Replace function attributes "no-frame-pointer-elim" and "no-frame-pointer-elim-non-leaf" with "frame-pointer": mstorsjo.
Jan 5 2019, 12:30 AM
tabloid.adroit retitled D56351: Replace function attributes "no-frame-pointer-elim" and "no-frame-pointer-elim-non-leaf" with "frame-pointer" from wip to Replace function attributes "no-frame-pointer-elim" and "no-frame-pointer-elim-non-leaf" with "frame-pointer".
Jan 5 2019, 12:30 AM
tabloid.adroit created D56351: Replace function attributes "no-frame-pointer-elim" and "no-frame-pointer-elim-non-leaf" with "frame-pointer".
Jan 5 2019, 12:15 AM

Dec 26 2018

tabloid.adroit abandoned D55669: [LIR] Add CTTZ support.
Dec 26 2018, 7:42 PM
tabloid.adroit added inline comments to D55915: [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer.
Dec 26 2018, 7:40 PM

Dec 23 2018

tabloid.adroit added a comment to D55915: [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer.

Thanks for the review! Comments inline.

Dec 23 2018, 8:34 AM
tabloid.adroit updated the diff for D55915: [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer.
  • update test
Dec 23 2018, 8:24 AM

Dec 21 2018

tabloid.adroit updated the diff for D55915: [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer.
  • [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer
  • add test
  • update
Dec 21 2018, 11:49 AM
tabloid.adroit added a comment to D55876: [LIR] Add CTTZ support.

Hi Craig, could you please help to commit it? Thanks.

Dec 21 2018, 10:57 AM

Dec 20 2018

tabloid.adroit updated the diff for D55877: [LIR] Add CTTZ support part2.

update

Dec 20 2018, 2:46 PM
tabloid.adroit updated the diff for D55876: [LIR] Add CTTZ support.

update

Dec 20 2018, 2:42 PM
tabloid.adroit updated the diff for D55876: [LIR] Add CTTZ support.
  • [LIR] Add CTTZ support part2
Dec 20 2018, 2:40 PM
tabloid.adroit updated the diff for D55876: [LIR] Add CTTZ support.

update test

Dec 20 2018, 2:32 PM

Dec 19 2018

tabloid.adroit retitled D55915: [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer from [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer and make -fomit-frame-pointer imply -momit-leaf-frame-pointer. This matches GCC's behavior. to [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer.
Dec 19 2018, 9:00 PM
tabloid.adroit created D55915: [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer.
Dec 19 2018, 8:55 PM

Dec 18 2018

tabloid.adroit added a comment to D55669: [LIR] Add CTTZ support.

Thank you! Splitted into two patches.

Dec 18 2018, 7:25 PM
tabloid.adroit added a child revision for D55876: [LIR] Add CTTZ support: D55877: [LIR] Add CTTZ support part2.
Dec 18 2018, 7:22 PM
tabloid.adroit added a parent revision for D55877: [LIR] Add CTTZ support part2: D55876: [LIR] Add CTTZ support.
Dec 18 2018, 7:22 PM
tabloid.adroit updated the summary of D55877: [LIR] Add CTTZ support part2.
Dec 18 2018, 7:21 PM
tabloid.adroit created D55877: [LIR] Add CTTZ support part2.
Dec 18 2018, 7:21 PM
tabloid.adroit updated the summary of D55876: [LIR] Add CTTZ support.
Dec 18 2018, 7:13 PM
tabloid.adroit updated the summary of D55876: [LIR] Add CTTZ support.
Dec 18 2018, 7:13 PM
tabloid.adroit created D55876: [LIR] Add CTTZ support.
Dec 18 2018, 7:05 PM
tabloid.adroit added a comment to D55669: [LIR] Add CTTZ support.

gentle ping

Dec 18 2018, 8:04 AM
tabloid.adroit added reviewers for D55669: [LIR] Add CTTZ support: mcrosier, bkramer.
Dec 18 2018, 8:04 AM

Dec 13 2018

tabloid.adroit added reviewers for D55669: [LIR] Add CTTZ support: evstupac, craig.topper, davide.
Dec 13 2018, 1:29 PM
tabloid.adroit created D55669: [LIR] Add CTTZ support.
Dec 13 2018, 1:21 PM

Oct 24 2018

tabloid.adroit updated the diff for D53686: [CMake] When built with LLVM, not use `-Wl,-z,defs`.
  • update
Oct 24 2018, 8:53 PM
tabloid.adroit updated the summary of D53686: [CMake] When built with LLVM, not use `-Wl,-z,defs`.
Oct 24 2018, 6:47 PM
tabloid.adroit created D53686: [CMake] When built with LLVM, not use `-Wl,-z,defs`.
Oct 24 2018, 6:45 PM
tabloid.adroit added a reviewer for D53553: [CMake] Allow undefined unwinder API reference when compiler does not specify unwinder lib: EricWF.
Oct 24 2018, 6:30 PM

Oct 23 2018

tabloid.adroit updated the summary of D53553: [CMake] Allow undefined unwinder API reference when compiler does not specify unwinder lib.
Oct 23 2018, 8:15 AM
tabloid.adroit retitled D53553: [CMake] Allow undefined unwinder API reference when compiler does not specify unwinder lib from [CMake] Allow undefined unwinder API reference when compiler does not specify unwinder lib (in this case clang + compiler-rt) There is also a similar patch for compiler-rt, which will be submitted in a separate patch in compiler-rt tree. to [CMake] Allow undefined unwinder API reference when compiler does not specify unwinder lib.
Oct 23 2018, 8:04 AM

Oct 22 2018

tabloid.adroit created D53553: [CMake] Allow undefined unwinder API reference when compiler does not specify unwinder lib.
Oct 22 2018, 8:33 PM

May 25 2015

tabloid.adroit updated subscribers of rL216239: Use DILexicalBlockFile, rather than DILexicalBlock, to track discriminator….
May 25 2015, 3:11 PM
tabloid.adroit updated subscribers of D2691: Add a new pass to compute DWARF path discriminators..
May 25 2015, 2:58 PM
tabloid.adroit updated subscribers of D2794: Support DWARF discriminators in object streamer..
May 25 2015, 2:57 PM
tabloid.adroit updated subscribers of D2794: Support DWARF discriminators in object streamer..
May 25 2015, 2:56 PM