Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

t-troebst (Thorben Tröbst)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 13 2023, 2:26 AM (23 w, 5 d)

Recent Activity

May 1 2023

t-troebst added a comment to D148284: [clangd] Add "readonly" token to const member expressions.

I've added some logic to get const-ness for dependent expressions. I think you're right that its probably reasonable to do this since mutable is almost always used in member functions where the type isn't dependent anyways.

May 1 2023, 11:21 PM · Restricted Project, Restricted Project
t-troebst updated the diff for D148284: [clangd] Add "readonly" token to const member expressions.

Add best effort attempt to get const-ness for dependent member expressions.

May 1 2023, 11:18 PM · Restricted Project, Restricted Project

Apr 13 2023

t-troebst updated the diff for D148284: [clangd] Add "readonly" token to const member expressions.

Changed isConstQualifed() to the custom isConst() (though this isConst() behaves strangely for pointer types, we should fix this separately and keep them synced for now).

Apr 13 2023, 6:29 PM · Restricted Project, Restricted Project
t-troebst requested review of D148284: [clangd] Add "readonly" token to const member expressions.
Apr 13 2023, 6:20 PM · Restricted Project, Restricted Project