Page MenuHomePhabricator
People t-rasmud

t-rasmud (Rashmi Mudduluru)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 31 2022, 2:26 PM (59 w, 4 d)

Recent Activity
View All

Thu, Mar 23

t-rasmud updated the diff for D145739: [-Wunsafe-buffer-usage][WIP] Group variables associated by pointer assignments.
Thu, Mar 23, 1:40 PM · Restricted Project
t-rasmud added inline comments to D146669: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag, -fsafe-buffer-usage-suggestions..
Thu, Mar 23, 12:43 PM · Restricted Project
t-rasmud accepted D146669: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag, -fsafe-buffer-usage-suggestions..
Thu, Mar 23, 12:42 PM · Restricted Project
t-rasmud requested changes to D146669: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag, -fsafe-buffer-usage-suggestions..
Thu, Mar 23, 12:42 PM · Restricted Project

Tue, Mar 14

t-rasmud abandoned D143133: [-Wunsafe-buffer-usage][WIP] Add fixit for variables that have an assignment from another spanified pointer.

Abandoning patch in favor of D145739

Tue, Mar 14, 11:42 AM · Restricted Project

Thu, Mar 9

t-rasmud requested review of D145739: [-Wunsafe-buffer-usage][WIP] Group variables associated by pointer assignments.
Thu, Mar 9, 4:14 PM · Restricted Project

Mon, Mar 6

t-rasmud added inline comments to D143128: [-Wunsafe-buffer-usage] Fix-Its transforming `&DRE[any]` to `(DRE.data() + any)`.
Mon, Mar 6, 10:51 AM · Restricted Project, Restricted Project

Feb 13 2023

t-rasmud added a comment to D143133: [-Wunsafe-buffer-usage][WIP] Add fixit for variables that have an assignment from another spanified pointer.

Friendly Ping @jkorous @ziqingluo-90 @NoQ

Feb 13 2023, 9:08 AM · Restricted Project

Feb 10 2023

t-rasmud updated the diff for D143133: [-Wunsafe-buffer-usage][WIP] Add fixit for variables that have an assignment from another spanified pointer.
Feb 10 2023, 3:16 PM · Restricted Project

Feb 9 2023

t-rasmud updated the diff for D143133: [-Wunsafe-buffer-usage][WIP] Add fixit for variables that have an assignment from another spanified pointer.

Address feedback.

Feb 9 2023, 4:37 PM · Restricted Project
t-rasmud updated the diff for D143133: [-Wunsafe-buffer-usage][WIP] Add fixit for variables that have an assignment from another spanified pointer.
Feb 9 2023, 3:47 PM · Restricted Project
t-rasmud updated the diff for D143133: [-Wunsafe-buffer-usage][WIP] Add fixit for variables that have an assignment from another spanified pointer.
  • Fixes crash caused by FixableGadgetSets and WarningGadgetSets being unique pointers in the context of multiple declaration gadgets.
Feb 9 2023, 3:44 PM · Restricted Project
t-rasmud updated the diff for D143133: [-Wunsafe-buffer-usage][WIP] Add fixit for variables that have an assignment from another spanified pointer.
Feb 9 2023, 2:41 PM · Restricted Project

Feb 8 2023

t-rasmud updated the diff for D143133: [-Wunsafe-buffer-usage][WIP] Add fixit for variables that have an assignment from another spanified pointer.

WIP: Fixable for ptr1 = ptr2 when both LHS and RHS have their fixit strategies set as std::span.

Feb 8 2023, 2:37 PM · Restricted Project

Feb 1 2023

t-rasmud requested review of D143133: [-Wunsafe-buffer-usage][WIP] Add fixit for variables that have an assignment from another spanified pointer.
Feb 1 2023, 8:10 PM · Restricted Project

Jan 31 2023

t-rasmud committed rGacc3cc69e4d1: [-Wunsafe-buffer-usage] Introduce the unsafe_buffer_usage attribute (authored by t-rasmud).
[-Wunsafe-buffer-usage] Introduce the unsafe_buffer_usage attribute
Jan 31 2023, 11:45 AM · Restricted Project, Restricted Project
t-rasmud closed D138940: [-Wunsafe-buffer-usage] Introduce the `unsafe_buffer_usage` attribute.
Jan 31 2023, 11:45 AM · Restricted Project, Restricted Project

Jan 30 2023

t-rasmud updated the diff for D138940: [-Wunsafe-buffer-usage] Introduce the `unsafe_buffer_usage` attribute.

Adds a release note for unsafe_buffer_usage attribute.

Jan 30 2023, 4:35 PM · Restricted Project, Restricted Project
t-rasmud added a comment to D138940: [-Wunsafe-buffer-usage] Introduce the `unsafe_buffer_usage` attribute.

@erichkeane We'd love to get your feedback on the latest revision, thanks!

Jan 30 2023, 12:20 PM · Restricted Project, Restricted Project

Jan 26 2023

t-rasmud updated the summary of D138940: [-Wunsafe-buffer-usage] Introduce the `unsafe_buffer_usage` attribute.
Jan 26 2023, 4:32 PM · Restricted Project, Restricted Project
t-rasmud updated the diff for D138940: [-Wunsafe-buffer-usage] Introduce the `unsafe_buffer_usage` attribute.

Adds test cases for the unsafe_buffer_usage attribute on virtual functions.

Jan 26 2023, 4:30 PM · Restricted Project, Restricted Project

Jan 23 2023

t-rasmud updated the diff for D138940: [-Wunsafe-buffer-usage] Introduce the `unsafe_buffer_usage` attribute.

Adds tests for variadic functions, templates.

Jan 23 2023, 12:54 PM · Restricted Project, Restricted Project

Jan 19 2023

t-rasmud updated the diff for D138940: [-Wunsafe-buffer-usage] Introduce the `unsafe_buffer_usage` attribute.

Improves documentation for unsafe_buffer_usage attribute

Jan 19 2023, 10:18 AM · Restricted Project, Restricted Project

Jan 18 2023

t-rasmud updated the diff for D138940: [-Wunsafe-buffer-usage] Introduce the `unsafe_buffer_usage` attribute.

Improves documentation and addresses feedback.

Jan 18 2023, 2:08 PM · Restricted Project, Restricted Project

Jan 17 2023

t-rasmud committed rGfe93da22aa7b: [-Wunsafe-buffer-usage] Emit warnings about unsafe operations on arrays (authored by t-rasmud).
[-Wunsafe-buffer-usage] Emit warnings about unsafe operations on arrays
Jan 17 2023, 4:30 PM · Restricted Project, Restricted Project

Jan 13 2023

t-rasmud requested review of D141725: [-Wunsafe-buffer-usage] Emit warnings about unsafe operations on arrays.
Jan 13 2023, 1:33 PM · Restricted Project

Jan 5 2023

t-rasmud added a comment to D138940: [-Wunsafe-buffer-usage] Introduce the `unsafe_buffer_usage` attribute.

Here's an update on how we plan to implement the attribute after considering feedback from everyone:

Jan 5 2023, 4:04 PM · Restricted Project, Restricted Project

Nov 29 2022

t-rasmud retitled D138940: [-Wunsafe-buffer-usage] Introduce the `unsafe_buffer_usage` attribute from [-Wunsafe-buffer-usage] Introduces the `unsafe_buffer_usage` attribute to [-Wunsafe-buffer-usage] Introduce the `unsafe_buffer_usage` attribute.
Nov 29 2022, 2:36 PM · Restricted Project, Restricted Project
t-rasmud retitled D138940: [-Wunsafe-buffer-usage] Introduce the `unsafe_buffer_usage` attribute from [-Wunsafe-buffer-usage] Introducing the `unsafe_buffer_usage` attribute to [-Wunsafe-buffer-usage] Introduces the `unsafe_buffer_usage` attribute.
Nov 29 2022, 2:36 PM · Restricted Project, Restricted Project
t-rasmud added a reviewer for D138940: [-Wunsafe-buffer-usage] Introduce the `unsafe_buffer_usage` attribute: malavikasamak.
Nov 29 2022, 12:22 PM · Restricted Project, Restricted Project
t-rasmud requested review of D138940: [-Wunsafe-buffer-usage] Introduce the `unsafe_buffer_usage` attribute.
Nov 29 2022, 12:22 PM · Restricted Project, Restricted Project

Aug 5 2022

t-rasmud committed rG13bc71310920: fixes clang-tidy/checks/list.rst: a line was accidentally removed in… (authored by t-rasmud).
fixes clang-tidy/checks/list.rst: a line was accidentally removed in…
Aug 5 2022, 12:36 PM · Restricted Project, Restricted Project

Aug 2 2022

t-rasmud committed rG95a92995d45f: Adds the NSDateFormatter checker to clang-tidy (authored by t-rasmud).
Adds the NSDateFormatter checker to clang-tidy
Aug 2 2022, 1:58 PM · Restricted Project, Restricted Project
t-rasmud closed D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy.
Aug 2 2022, 1:58 PM · Restricted Project, Restricted Project

Aug 1 2022

t-rasmud updated the diff for D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy.
Aug 1 2022, 3:27 PM · Restricted Project, Restricted Project
t-rasmud added a comment to D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy.

Ping

Aug 1 2022, 11:42 AM · Restricted Project, Restricted Project

Jul 13 2022

t-rasmud updated the diff for D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy.

Addresses review comments from the previously uploaded diff.

Jul 13 2022, 11:25 PM · Restricted Project, Restricted Project

Jun 30 2022

t-rasmud committed rGeb1d908e5cf7: Adds AST matcher for ObjCStringLiteral (authored by t-rasmud).
Adds AST matcher for ObjCStringLiteral
Jun 30 2022, 3:23 PM · Restricted Project, Restricted Project
t-rasmud closed D128103: Adds AST Matcher for ObjCStringLiteral.
Jun 30 2022, 3:23 PM · Restricted Project, Restricted Project, Restricted Project
t-rasmud added a comment to D128103: Adds AST Matcher for ObjCStringLiteral.
In D128103#3622223, @aaron.ballman wrote:

LGTM! Do you need me to commit on your behalf? If so, what name and email address would you like me to use for patch attribution?

Jun 30 2022, 11:14 AM · Restricted Project, Restricted Project, Restricted Project

Jun 29 2022

t-rasmud updated the diff for D128103: Adds AST Matcher for ObjCStringLiteral.
Jun 29 2022, 2:54 PM · Restricted Project, Restricted Project, Restricted Project

Jun 28 2022

t-rasmud updated the diff for D128103: Adds AST Matcher for ObjCStringLiteral.

Removes manually added documentation and adds it in the header file.

Jun 28 2022, 2:08 PM · Restricted Project, Restricted Project, Restricted Project

Jun 27 2022

t-rasmud updated the diff for D128103: Adds AST Matcher for ObjCStringLiteral.
Jun 27 2022, 5:56 PM · Restricted Project, Restricted Project, Restricted Project
t-rasmud updated the diff for D128103: Adds AST Matcher for ObjCStringLiteral.

Documentation edits and other fixes, thanks to suggestions from @ziqingluo-90

Jun 27 2022, 5:26 PM · Restricted Project, Restricted Project, Restricted Project
t-rasmud added a reviewer for D128103: Adds AST Matcher for ObjCStringLiteral: ziqingluo-90.
Jun 27 2022, 1:02 PM · Restricted Project, Restricted Project, Restricted Project
t-rasmud updated the diff for D128103: Adds AST Matcher for ObjCStringLiteral.
Jun 27 2022, 1:01 PM · Restricted Project, Restricted Project, Restricted Project

Jun 21 2022

t-rasmud updated the diff for D128103: Adds AST Matcher for ObjCStringLiteral.
Jun 21 2022, 3:25 PM · Restricted Project, Restricted Project, Restricted Project

Jun 17 2022

t-rasmud requested review of D128103: Adds AST Matcher for ObjCStringLiteral.
Jun 17 2022, 3:41 PM · Restricted Project, Restricted Project, Restricted Project

May 20 2022

t-rasmud requested review of D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy.
May 20 2022, 3:40 PM · Restricted Project, Restricted Project

Apr 28 2022

t-rasmud abandoned D124570: Revert "[analyzer][NFC] Refactor GenericTaintChecker to use CallDescriptionMap".

Abandoning this patch because it was a downstream problem and I incorrectly diagnosed it on the open source branch.

Apr 28 2022, 1:18 PM · Restricted Project, Restricted Project
t-rasmud added a comment to D124570: Revert "[analyzer][NFC] Refactor GenericTaintChecker to use CallDescriptionMap".
Apr 28 2022, 9:43 AM · Restricted Project, Restricted Project

Apr 27 2022

t-rasmud requested review of D124570: Revert "[analyzer][NFC] Refactor GenericTaintChecker to use CallDescriptionMap".
Apr 27 2022, 4:24 PM · Restricted Project, Restricted Project

Feb 16 2022

t-rasmud committed rG572e2cd56a43: Reverting ce420820c815e806bab9c5f17cb3b829a616548a because it fails expensive… (authored by t-rasmud).
Reverting ce420820c815e806bab9c5f17cb3b829a616548a because it fails expensive…
Feb 16 2022, 9:26 AM

Feb 14 2022

t-rasmud updated the diff for D119270: [analyzer] Re-enables trustnonnullchecker_test and removes redundant code from TrustNonNullChecker.

Reverts previous changes; We are keeping trustnonnullchecker_test.m disabled because it still fails expensive checks.

Feb 14 2022, 11:13 AM · Restricted Project

Feb 10 2022

t-rasmud committed rGce420820c815: [Analyzer] Re-enables trustnonnullchecker_test.m (authored by t-rasmud).
[Analyzer] Re-enables trustnonnullchecker_test.m
Feb 10 2022, 6:53 PM

Feb 8 2022

t-rasmud added a comment to D119270: [analyzer] Re-enables trustnonnullchecker_test and removes redundant code from TrustNonNullChecker.
In D119270#3305768, @NoQ wrote:

Yes, as long as the maps are there, checkDeadSymbols has to be there. It doesn't have any visible effects (because the symbols are dead, there's in fact a guarantee that these map keys will never be queried anymore) but it keeps the maps small which is essential for performance.

Feb 8 2022, 2:56 PM · Restricted Project
t-rasmud updated the diff for D119270: [analyzer] Re-enables trustnonnullchecker_test and removes redundant code from TrustNonNullChecker.

Reverting changes to TrustNonNullChecker

Feb 8 2022, 2:52 PM · Restricted Project
t-rasmud requested review of D119270: [analyzer] Re-enables trustnonnullchecker_test and removes redundant code from TrustNonNullChecker.
Feb 8 2022, 11:31 AM · Restricted Project

Feb 1 2022

t-rasmud updated the diff for D118657: [analyzer] Adds TrustReturnsNonnullChecker.

This diff merges relevant test cases into one file.

Feb 1 2022, 1:51 PM · Restricted Project, Restricted Project
t-rasmud updated the diff for D118657: [analyzer] Adds TrustReturnsNonnullChecker.

This diff addresses review comments.

Feb 1 2022, 12:00 PM · Restricted Project, Restricted Project

Jan 31 2022

t-rasmud requested review of D118657: [analyzer] Adds TrustReturnsNonnullChecker.
Jan 31 2022, 2:40 PM · Restricted Project, Restricted Project