Page MenuHomePhabricator

szdominik (Dominik Szabó)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 29 2016, 3:22 AM (267 w, 3 d)

Recent Activity

Oct 11 2017

szdominik added inline comments to D33722: [clang-tidy] Add checker for undelegated copy of base classes.
Oct 11 2017, 7:44 AM · Restricted Project
szdominik updated the diff for D33722: [clang-tidy] Add checker for undelegated copy of base classes.

Small changes after aaron.ballman's comments.

Oct 11 2017, 7:43 AM · Restricted Project

Sep 18 2017

szdominik added a comment to D33722: [clang-tidy] Add checker for undelegated copy of base classes.

There wasn't any update on this check lately - can I help to make it better?

Sep 18 2017, 7:21 AM · Restricted Project

Aug 3 2017

szdominik updated the diff for D33722: [clang-tidy] Add checker for undelegated copy of base classes.

Fixed check-fixes lines in test cases.
Updated matcher definition.

Aug 3 2017, 8:14 AM · Restricted Project

Jul 12 2017

szdominik added a comment to D33645: [analyzer] Add missing documentation for static analyzer checkers.

Do you have commit access, or do you need someone to commit it for you?

Jul 12 2017, 12:44 PM
szdominik updated the diff for D33645: [analyzer] Add missing documentation for static analyzer checkers.

Update with more idiomatic examples (from @dcoughlin).

Jul 12 2017, 5:23 AM
szdominik added a comment to D33645: [analyzer] Add missing documentation for static analyzer checkers.

Who is the target of this documentation? Is it developers of the analyzer or is it end users of the analyzer? If it is end users, it is unfortunate that we've been just grabbing examples from the regression tests. These tests are usually not idiomatic and, since they're designed for testing, they typically won't explain the check well to an end user.

I've suggested some more idiomatic examples inline for for some of the Objective-C targeted checkers -- but it is probably worth thinking about the remaining examples from the perspective of an end user.

Jul 12 2017, 5:21 AM

Jun 21 2017

szdominik updated the diff for D33722: [clang-tidy] Add checker for undelegated copy of base classes.

Updated loop for searching the beginning of the initlist.

Jun 21 2017, 8:06 AM · Restricted Project
szdominik updated the diff for D33645: [analyzer] Add missing documentation for static analyzer checkers.

Fixed alpha.core.CallAndMessageUnInitRefArg.

Jun 21 2017, 7:40 AM

Jun 16 2017

szdominik added inline comments to D33722: [clang-tidy] Add checker for undelegated copy of base classes.
Jun 16 2017, 5:32 AM · Restricted Project
szdominik added inline comments to D33722: [clang-tidy] Add checker for undelegated copy of base classes.
Jun 16 2017, 5:19 AM · Restricted Project
szdominik updated the diff for D33722: [clang-tidy] Add checker for undelegated copy of base classes.

Rename check.
Hoisted matcher, changed warning message & nits.

Jun 16 2017, 5:17 AM · Restricted Project

Jun 15 2017

szdominik added inline comments to D33645: [analyzer] Add missing documentation for static analyzer checkers.
Jun 15 2017, 3:17 AM
szdominik updated the diff for D33645: [analyzer] Add missing documentation for static analyzer checkers.

Delete modeling checkers (unix.StdCLibraryFunctions, cplusplus.SelfAssignment).
Delete unix.MallocWithAnnotations.

Jun 15 2017, 3:14 AM

Jun 10 2017

szdominik added a comment to D33722: [clang-tidy] Add checker for undelegated copy of base classes.

Warnings of the check's run on llvm/clang codebase.

Jun 10 2017, 12:45 AM · Restricted Project

May 31 2017

szdominik updated the diff for D33722: [clang-tidy] Add checker for undelegated copy of base classes.

Update with fixed docs.

May 31 2017, 11:15 AM · Restricted Project
szdominik created D33722: [clang-tidy] Add checker for undelegated copy of base classes.
May 31 2017, 6:28 AM · Restricted Project

May 29 2017

szdominik created D33645: [analyzer] Add missing documentation for static analyzer checkers.
May 29 2017, 6:15 AM

May 5 2016

szdominik added a comment to D19769: [clang-tidy] Add explicitly given array size heuristic to misc-suspicious-missing-comma check..

I think the main success is that we don't warn here:

const char* A[2] = {"a", "b" "c");

The problem is, as you said, not remove already supported cases (such as when the parent is not a vardecl (but also an initListExpr)).
But I'll implement, and we'll see it.

May 5 2016, 10:10 AM
szdominik added a comment to D19769: [clang-tidy] Add explicitly given array size heuristic to misc-suspicious-missing-comma check..

The original size is available - but from the decleration, not from the initListExpr.

May 5 2016, 7:15 AM

May 2 2016

szdominik added inline comments to D19769: [clang-tidy] Add explicitly given array size heuristic to misc-suspicious-missing-comma check..
May 2 2016, 3:57 AM
szdominik added inline comments to D19769: [clang-tidy] Add explicitly given array size heuristic to misc-suspicious-missing-comma check..
May 2 2016, 3:16 AM

May 1 2016

szdominik updated the diff for D19769: [clang-tidy] Add explicitly given array size heuristic to misc-suspicious-missing-comma check..

Implement the heuristic in a different (and simpler) way.
Based on the array fillers.

May 1 2016, 3:08 AM
szdominik added inline comments to D19769: [clang-tidy] Add explicitly given array size heuristic to misc-suspicious-missing-comma check..
May 1 2016, 1:44 AM

Apr 30 2016

szdominik retitled D19769: [clang-tidy] Add explicitly given array size heuristic to misc-suspicious-missing-comma check. from to [clang-tidy] Add explicitly given array size heuristic to misc-suspicious-missing-comma check..
Apr 30 2016, 10:05 AM

Mar 29 2016

szdominik added a comment to D18457: [clang-tidy] Add a new checker to detect missing comma in initializer list..

I'm working on the same (or almost the same) checker as you, so maybe you'll find helpful my code.
I think your approach (or heuristics) is better than mine, but there are other options in this problem.
e.g.

  • more precise location (where exactly is the missing comma)
  • FixItHint for that
  • think about what if the explicit array size is given (see below in my test)
Mar 29 2016, 3:51 AM