Page MenuHomePhabricator

svenbrauch (Sven Brauch)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 31 2017, 6:28 AM (153 w, 2 d)

Recent Activity

Jan 9 2018

svenbrauch added a comment to D37650: [continued] Add a way to get the CXCursor that corresponds to a completion result.

I know it breaks ABI compatiblity, I just don't know whether it needs to be kept (e.g. for clang-6.0). The alternative requires sorting by a separate index list which is a bit ugly (and slower). If you feel like working on it in the next few days that would of course be great, otherwise if it is clear that this solution doesn't work, I will pick it up again later. Thanks!

Jan 9 2018, 12:11 PM

Oct 16 2017

svenbrauch updated the diff for D37650: [continued] Add a way to get the CXCursor that corresponds to a completion result.

Sorry for the wait.

Oct 16 2017, 2:47 AM

Sep 11 2017

svenbrauch added a comment to D37650: [continued] Add a way to get the CXCursor that corresponds to a completion result.

Oh, one thing: I would like to remove the CursorKind member of the CXCompletionResult struct now since it is obsolete (same as clang_getCursorKind(Result->Cursor)). But, is that compatible with your API stability guarantees?

Sep 11 2017, 1:27 PM
svenbrauch updated the diff for D37650: [continued] Add a way to get the CXCursor that corresponds to a completion result.

I added a few more tests and found two issues:

Sep 11 2017, 1:20 PM

Sep 9 2017

svenbrauch added a comment to D37650: [continued] Add a way to get the CXCursor that corresponds to a completion result.

I'll add some more, just wanted to post this to see if people think it's the right way to go.

Sep 9 2017, 5:42 AM

Sep 8 2017

svenbrauch created D37650: [continued] Add a way to get the CXCursor that corresponds to a completion result.
Sep 8 2017, 4:17 PM
svenbrauch added a comment to D13599: Add a way to get the CXCursor that corresponds to a completion result..

I will try to take care of this, yes. Thanks for the advice!

Sep 8 2017, 11:22 AM

Aug 18 2017

svenbrauch added a comment to D13599: Add a way to get the CXCursor that corresponds to a completion result..

Ping?

Aug 18 2017, 2:30 AM

Jul 31 2017

svenbrauch added a comment to D13599: Add a way to get the CXCursor that corresponds to a completion result..

If somebody could answer Milian's questions about tests, I would try to pick this up, I think the problem it solves is still very relevant.

Jul 31 2017, 6:29 AM