Page MenuHomePhabricator

sunziping2016 (Sun Ziping)
User

Projects

User does not belong to any projects.

User Details

User Since
May 12 2022, 10:20 PM (7 w, 3 d)

Recent Activity

May 18 2022

sunziping2016 closed D125522: [llvm][fix-irreducible] ensure that loop subtree under child is correctly reconnected to new loop.

Merged by commit https://github.com/llvm/llvm-project/commit/242961f23b4abaca999611fd364e93a8d2186371

May 18 2022, 5:40 AM · Restricted Project, Restricted Project
sunziping2016 updated the diff for D125522: [llvm][fix-irreducible] ensure that loop subtree under child is correctly reconnected to new loop.

rename test file to a meaningful name

May 18 2022, 2:02 AM · Restricted Project, Restricted Project
sunziping2016 added a comment to D125522: [llvm][fix-irreducible] ensure that loop subtree under child is correctly reconnected to new loop.

Thanks for your patient and professional review. I think the x64 debian failure is related to my changes. I need to spend some time to fix the issue.

May 18 2022, 12:18 AM · Restricted Project, Restricted Project

May 17 2022

sunziping2016 updated the diff for D125522: [llvm][fix-irreducible] ensure that loop subtree under child is correctly reconnected to new loop.

update commit message

May 17 2022, 11:08 PM · Restricted Project, Restricted Project
sunziping2016 added a comment to D125522: [llvm][fix-irreducible] ensure that loop subtree under child is correctly reconnected to new loop.

I think the change description is missing the point and needs to be rephrased. The modified function was incorrectly (not unnecessarily) ignoring grandchild loops, and this change fixes the bug. In particular, this fixes the handling of the loop { inner, body }. The TODO in the same function is talking about the b1 self loop, which may be "unnecessarily" lost, but that is a different issue.

A possible wording would be: "ensure that loop subtree under child is correctly reconnected to new loop"

May 17 2022, 10:39 PM · Restricted Project, Restricted Project
sunziping2016 retitled D125522: [llvm][fix-irreducible] ensure that loop subtree under child is correctly reconnected to new loop from [llvm][fix-irreducible] FixIrreducible unnecessarily destroys child loops causing assertion error to [llvm][fix-irreducible] ensure that loop subtree under child is correctly reconnected to new loop.
May 17 2022, 10:37 PM · Restricted Project, Restricted Project

May 12 2022

sunziping2016 added reviewers for D125522: [llvm][fix-irreducible] ensure that loop subtree under child is correctly reconnected to new loop: sameerds, slarin.
May 12 2022, 11:42 PM · Restricted Project, Restricted Project
sunziping2016 requested review of D125522: [llvm][fix-irreducible] ensure that loop subtree under child is correctly reconnected to new loop.
May 12 2022, 11:30 PM · Restricted Project, Restricted Project