Page MenuHomePhabricator

stuart (Stuart Brady)
GPU Compiler Engineer at ARM

Projects

User does not belong to any projects.

User Details

User Since
Apr 20 2018, 6:55 AM (77 w, 4 d)

Recent Activity

Sep 12 2019

stuart added inline comments to D67507: Refer to IEEE 754-2019 in langref instead of 2018 draft.
Sep 12 2019, 11:21 AM · Restricted Project
stuart added inline comments to D67507: Refer to IEEE 754-2019 in langref instead of 2018 draft.
Sep 12 2019, 10:51 AM · Restricted Project
stuart added a comment to D67507: Refer to IEEE 754-2019 in langref instead of 2018 draft.

@hans, is it too late for this to be considered as a candidate for the 9.0.0 release?

Sep 12 2019, 9:49 AM · Restricted Project
stuart created D67507: Refer to IEEE 754-2019 in langref instead of 2018 draft.
Sep 12 2019, 9:42 AM · Restricted Project

Apr 27 2018

stuart updated the summary of D46015: [OpenCL] Add separate read_only and write_only pipe IR types.
Apr 27 2018, 3:37 AM
stuart updated the summary of D46015: [OpenCL] Add separate read_only and write_only pipe IR types.
Apr 27 2018, 3:33 AM
stuart updated the summary of D46015: [OpenCL] Add separate read_only and write_only pipe IR types.
Apr 27 2018, 3:31 AM

Apr 25 2018

stuart added a comment to D46015: [OpenCL] Add separate read_only and write_only pipe IR types.

There should not be need for bitcast. Could give an example ? Thanks.

If I have a write_only pipe as the argument to get_pipe_max_packets(), and this uses a single __get_pipe_num_packets() function taking a read_only pipe, we will automatically get a bitcast:

%20 = call i32 bitcast (i32 (%opencl.pipe_ro_t*, i32, i32)* @__get_pipe_max_packets to i32 (%opencl.pipe_wo_t*, i32, i32)*)(%opencl.pipe_wo_t* %19, i32 4, i32 4)

Sorry, but I don't quite understand what does get_pipe_max_packets(), uses __get_pipe_num_packets() mean. Could you clarify? Possibly OpenCL C source example could help.

Apr 25 2018, 9:51 AM
stuart added a comment to D46015: [OpenCL] Add separate read_only and write_only pipe IR types.

There should not be need for bitcast. Could give an example ? Thanks.

Apr 25 2018, 8:31 AM
stuart added a comment to D46015: [OpenCL] Add separate read_only and write_only pipe IR types.

It is not clear why we need two versions of get_pipe_num_packets and get_pipe_max_packets builtins. There is only one instruction per builtin in the SPIR-V spec. I think splitting the IR type is enough for translation to SPIR-V purposes.

Apr 25 2018, 8:25 AM
stuart updated the diff for D46015: [OpenCL] Add separate read_only and write_only pipe IR types.

Changed new getPipeType() method to have protected visibility.

Apr 25 2018, 8:16 AM

Apr 24 2018

stuart created D46015: [OpenCL] Add separate read_only and write_only pipe IR types.
Apr 24 2018, 8:25 AM