User Details
- User Since
- Apr 20 2018, 6:55 AM (219 w, 4 d)
May 12 2022
Dec 16 2021
I've updated the review to include test changes that are required for check-clang-semaopencl to pass.
Dec 15 2021
Oct 8 2021
Sep 29 2021
Sep 28 2021
Sep 2 2021
Aug 26 2021
Unfortunately I cannot look at this in detail right now, but I'll reply quickly for a heads up: The problem was not how to detect kernels, but the ABI/CC mismatch to the clSetKerneArg() with (user facing) arguments that get split to multiple args or vice versa. E.g. x86 ABI had a CC where 2xfloat gets to 1xdouble in the generated function finger print, thus there was no 1:1 match of the kernel arguments to the OpenCL-facing ones (making clSetKernelArg calls difficult to implement robustly).
Jul 22 2021
LGTM, too.
Jul 19 2021
This looks good to me.
Jun 25 2021
If I understand correctly, this needs review from the libc++abi group before I can push it. It's a fairly trivial change. Could someone review this please? (Is there anyone specifically I should add?)
On reflection, I don't think it makes sense to make use of DW_LANG_C_plus_plus_17 or DW_LANG_C_plus_plus_20 in Clang just yet, as these are generally not supported by other tooling. I am a bit confused by DWARF publishing these tags ahead of time, yet tooling having not been updated to recognize them. Regardless, it is clear that support in debuggers needs to come first, which is something that I am not planning to add.
Jun 23 2021
No chances since last time. Rebased to force a rebuild.
Added handling of -gstrict-dwarf and updated tests accordingly.
Jun 16 2021
There is no CPlusPlus03 in LangOptions, so it is better not to merge DW_LANG_C_plus_plus_03 support with D99250.
Jun 15 2021
Changes will be required to align this with D104291.
This looks good to me.
Jun 11 2021
Add missing trailing commas to CHECK lines of FileCheck test.
Note: there is currently no DWARF language code defined for C++ for OpenCL, so we must use DW_LANG_C_plus_plus* if we wish to be able to determine whether output has been generated from C++ for OpenCL source or from OpenCL C source. I have raised DWARF issue 210514.1 to add a dedicated C++ for OpenCL code in the next version of DWARF, but for now I believe that it is best to use DW_LANG_OpenCL for OpenCL C only, and not for C++ for OpenCL.
Jun 10 2021
Add a/ and b/ prefixes to diff.
Reupload with no changes.
@jyknight, I have reuploaded the exact same diff with full context:
Reupload with no changes.
Jun 7 2021
The pre-merge check failures relating to the failure to include "ItaniumDemangle.h" seem confusing to me. I cannot see how they would be caused by this change, itself: this looks on the surface to be a problem with the CI. Do I need to do anything about this?
Jun 4 2021
Mar 11 2021
Looks good to me.
Mar 1 2021
Feb 9 2021
Looks good, just some suggestions about the test.
Feb 5 2021
Looks good. Small nit about the test case.
This looks like a really good cleanup, in addition to fixing the metadata for pipes.
Sep 12 2019
@hans, is it too late for this to be considered as a candidate for the 9.0.0 release?
Apr 27 2018
Apr 25 2018
Changed new getPipeType() method to have protected visibility.