Page MenuHomePhabricator

stettberger (Christian Dietrich)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 30 2016, 6:02 AM (181 w, 5 d)

Recent Activity

Mar 12 2018

stettberger added inline comments to D40731: Integrate CHash into CLang.
Mar 12 2018, 8:43 AM
stettberger updated the diff for D40731: Integrate CHash into CLang.

Addressed comments, for more details, please see the mail on cfe-devel

Mar 12 2018, 8:38 AM

Feb 23 2018

stettberger updated the diff for D40731: Integrate CHash into CLang.

[CHash] Stable TU-level AST Hashing for local and global hashes

Feb 23 2018, 12:49 AM

Feb 21 2018

stettberger updated the diff for D40731: Integrate CHash into CLang.

Rebased to HEAD, Run (external) clang-hash testsuite and ASTTest

Feb 21 2018, 3:55 AM

Dec 20 2017

stettberger added a comment to D40782: [tablegen] Replace strconcat, listconcat by concat.

From a user's perspective, I got the impression that code [{}] is just a handy shortcut for multiline strings and I was quite surprised that they are internally actual different datatypes. So for me, changing the semantic of !strconcat would remain rather intuitive.

Dec 20 2017, 1:22 AM

Dec 14 2017

stettberger updated the diff for D40731: Integrate CHash into CLang.

@rtrieu: Fixed the checking of Decl::hasAttrs() before using Decl::attrs()

Dec 14 2017, 3:41 AM

Dec 12 2017

stettberger updated the diff for D40731: Integrate CHash into CLang.

I removed the magic constants and added the number of children for various AST nodes. This should avoid hash collisions.

Dec 12 2017, 3:41 AM
stettberger added a comment to D40782: [tablegen] Replace strconcat, listconcat by concat.

I think there should be some documentation for this new TableGen command.

Dec 12 2017, 1:03 AM

Dec 4 2017

stettberger added a comment to D40731: Integrate CHash into CLang.

For my changes to StmtDataCollectors: I tried to leave the already existing entries in StmtDataCollector.td untouched and the test-cases still work OK. If there is something somebody could break by changing these files it would be good to have a test case for it.

Dec 4 2017, 6:17 AM
stettberger updated the diff for D40731: Integrate CHash into CLang.

@Eugene.Zelenko Thank you for pointing me out on these issues. I ran clang-tidy and clang-format on CHashVisitor.h

Dec 4 2017, 4:19 AM

Dec 1 2017

stettberger created D40731: Integrate CHash into CLang.
Dec 1 2017, 8:18 AM