Page MenuHomePhabricator

sterni (sterni)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 3 2022, 2:05 AM (19 w, 14 h)

Recent Activity

Jan 8 2022

sterni added a comment to D116524: [doc][cmake] Convert read-me for the common CMake utils to reST.

I'll let this sit a bit in case anyone wants to re-review it.

Jan 8 2022, 1:23 AM · Restricted Project

Jan 7 2022

sterni added inline comments to D116524: [doc][cmake] Convert read-me for the common CMake utils to reST.
Jan 7 2022, 12:17 PM · Restricted Project

Jan 4 2022

sterni added a comment to D116537: [llvm][cmake] never link llvm-config against llvm dylib.

Ok, thanks. Don’t you have the same issue with the tblgen tools then too?

Jan 4 2022, 6:11 AM · Restricted Project
sterni added a comment to D116537: [llvm][cmake] never link llvm-config against llvm dylib.

Ok, so the missing context is that you're manually forwarding this by setting e.g. -DLLVM_LINK_LLVM_DYLIB=ON -DCROSS_TOOLCHAIN_FLAGS_NATIVE="... -DLLVM_LINK_LLVM_DYLIB=ON ..."?

Jan 4 2022, 2:25 AM · Restricted Project

Jan 3 2022

sterni updated the diff for D116537: [llvm][cmake] never link llvm-config against llvm dylib.

Add suggest comment above DISABLE_LLVM_LINK_LLVM_DYLIB

Jan 3 2022, 5:41 PM · Restricted Project
sterni added a comment to D116537: [llvm][cmake] never link llvm-config against llvm dylib.

What do you think about not passing in LLVM_LINK_LLVM_DYLIB to the internal, chained cmake build for the native tools (or forcing it to false)? Either as complement to or replacement for this patch.

Jan 3 2022, 5:31 PM · Restricted Project
sterni requested review of D116537: [llvm][cmake] never link llvm-config against llvm dylib.
Jan 3 2022, 6:31 AM · Restricted Project