Page MenuHomePhabricator

stelios-arm (Stelios Ioannou)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 24 2021, 5:48 AM (10 w, 2 d)

Recent Activity

Wed, May 5

stelios-arm added a comment to D99272: [AArch64] Adds a pre-indexed paired Load/Store optimization for LDR-STR..

@nathanchance Great! Thanks for the update.

Wed, May 5, 9:07 AM · Restricted Project
stelios-arm committed rG3f4bad5eadac: [AArch64] Fix for the pre-indexed paired load/store optimization. (authored by stelios-arm).
[AArch64] Fix for the pre-indexed paired load/store optimization.
Wed, May 5, 7:15 AM
stelios-arm closed D101888: [AArch64] Fix for the pre-indexed paired load/store optimization..
Wed, May 5, 7:15 AM · Restricted Project
stelios-arm added a comment to rG936c777e2bf8: [AArch64] Adds a pre-indexed paired Load/Store optimization for LDR-STR..

Follow up fix: https://reviews.llvm.org/D101888

Wed, May 5, 3:26 AM
stelios-arm added a comment to D99272: [AArch64] Adds a pre-indexed paired Load/Store optimization for LDR-STR..

@nickdesaulniers This patch is a possible fix for the issue, do you mind testing if it's now OK?
@dmgreen I added one in the patch.

Wed, May 5, 3:16 AM · Restricted Project
stelios-arm requested review of D101888: [AArch64] Fix for the pre-indexed paired load/store optimization..
Wed, May 5, 3:09 AM · Restricted Project

Sun, May 2

stelios-arm committed rG36a44dfd95d8: [AArch64] Sets the preferred function alignment for Cortex-A53/A55. (authored by stelios-arm).
[AArch64] Sets the preferred function alignment for Cortex-A53/A55.
Sun, May 2, 4:01 PM
stelios-arm closed D101636: [AArch64] Sets the preferred function alignment for Cortex-A53/A55.
Sun, May 2, 4:00 PM · Restricted Project

Fri, Apr 30

stelios-arm updated the diff for D101636: [AArch64] Sets the preferred function alignment for Cortex-A53/A55.

Modified the Cortex-A53 test and added one for Cortex-A55.

Fri, Apr 30, 9:59 AM · Restricted Project
stelios-arm committed rG936c777e2bf8: [AArch64] Adds a pre-indexed paired Load/Store optimization for LDR-STR. (authored by stelios-arm).
[AArch64] Adds a pre-indexed paired Load/Store optimization for LDR-STR.
Fri, Apr 30, 9:30 AM
stelios-arm closed D99272: [AArch64] Adds a pre-indexed paired Load/Store optimization for LDR-STR..
Fri, Apr 30, 9:30 AM · Restricted Project
stelios-arm requested review of D101636: [AArch64] Sets the preferred function alignment for Cortex-A53/A55.
Fri, Apr 30, 7:57 AM · Restricted Project
stelios-arm updated the diff for D99272: [AArch64] Adds a pre-indexed paired Load/Store optimization for LDR-STR..

Addressed the comments made by @dmgreen.

Fri, Apr 30, 4:13 AM · Restricted Project
stelios-arm added inline comments to D99272: [AArch64] Adds a pre-indexed paired Load/Store optimization for LDR-STR..
Fri, Apr 30, 4:11 AM · Restricted Project

Thu, Apr 22

stelios-arm added inline comments to D99272: [AArch64] Adds a pre-indexed paired Load/Store optimization for LDR-STR..
Thu, Apr 22, 7:15 AM · Restricted Project
stelios-arm updated the diff for D99272: [AArch64] Adds a pre-indexed paired Load/Store optimization for LDR-STR..

Addressed the comments made by @dmgreen (Thanks for the comments!)

  1. Added more test cases
  2. Refactoring
  3. Added support for LDUR<>i<>Ri/STUR<>i
  4. Changed the code so that the same Pre Ld/St Opcodes are not candidates to merge/pair.
Thu, Apr 22, 7:12 AM · Restricted Project

Fri, Apr 16

stelios-arm updated the diff for D99272: [AArch64] Adds a pre-indexed paired Load/Store optimization for LDR-STR..
  1. Added more test cases.
  2. Addressed the remarks.
Fri, Apr 16, 8:55 AM · Restricted Project
stelios-arm added inline comments to D99272: [AArch64] Adds a pre-indexed paired Load/Store optimization for LDR-STR..
Fri, Apr 16, 8:54 AM · Restricted Project

Thu, Apr 15

stelios-arm committed rGbf147c465352: [LSR] Fix for pre-indexed generated constant offset (authored by stelios-arm).
[LSR] Fix for pre-indexed generated constant offset
Thu, Apr 15, 8:49 AM
stelios-arm closed D100383: [LSR] Fix for pre-indexed generated constant offset.
Thu, Apr 15, 8:49 AM · Restricted Project
stelios-arm added inline comments to D100383: [LSR] Fix for pre-indexed generated constant offset.
Thu, Apr 15, 7:17 AM · Restricted Project
stelios-arm updated the diff for D100383: [LSR] Fix for pre-indexed generated constant offset.

Added back some of the atomic tests.

Thu, Apr 15, 7:16 AM · Restricted Project
stelios-arm updated the diff for D100383: [LSR] Fix for pre-indexed generated constant offset.
  1. Added comments to the new test.
  2. Fixed the failing AMDGPU tests.
Thu, Apr 15, 5:45 AM · Restricted Project

Wed, Apr 14

stelios-arm added a comment to D100383: [LSR] Fix for pre-indexed generated constant offset.

And forgot to add, and just double checking, this passes your bootstrap build and test again?

Wed, Apr 14, 5:49 AM · Restricted Project
stelios-arm added a comment to D100383: [LSR] Fix for pre-indexed generated constant offset.

In this link you can see how it results in an error.

Wed, Apr 14, 4:05 AM · Restricted Project
stelios-arm updated the diff for D100383: [LSR] Fix for pre-indexed generated constant offset.
  1. Added a test that triggers the assertion failure.
  2. Changed the isLegalUse parameters in LSRInstance::GenerateConstantOffsetsImpl to look the same as the assertion used for illegal formulas.
Wed, Apr 14, 4:03 AM · Restricted Project

Tue, Apr 13

stelios-arm added inline comments to D100383: [LSR] Fix for pre-indexed generated constant offset.
Tue, Apr 13, 9:02 AM · Restricted Project
stelios-arm added a comment to D100383: [LSR] Fix for pre-indexed generated constant offset.

I am afraid we need to add a test case for this because this doesn't seem to be covered by existing tests. So, I think you need to make a minimal reproducer of the input file that triggers the assertion failure.

Tue, Apr 13, 9:00 AM · Restricted Project
stelios-arm requested review of D100383: [LSR] Fix for pre-indexed generated constant offset.
Tue, Apr 13, 6:51 AM · Restricted Project
stelios-arm updated the diff for D99272: [AArch64] Adds a pre-indexed paired Load/Store optimization for LDR-STR..

Removed the hack that was used to avoid the memoperands_empty() check for LDR<>pre instructions.

Tue, Apr 13, 3:19 AM · Restricted Project

Mon, Apr 12

stelios-arm closed D100215: [AArch64] Adds memory operands for indexed loads..
Mon, Apr 12, 1:18 AM · Restricted Project
stelios-arm added a comment to D100215: [AArch64] Adds memory operands for indexed loads..

Closed by git revision a655f250fef84795e3e46c0bcb824d7b5fbceec6.

Mon, Apr 12, 1:16 AM · Restricted Project
stelios-arm committed rGa655f250fef8: [AArch64] Adds memory operands for indexed loads. (authored by stelios-arm).
[AArch64] Adds memory operands for indexed loads.
Mon, Apr 12, 1:12 AM

Fri, Apr 9

stelios-arm requested review of D100215: [AArch64] Adds memory operands for indexed loads..
Fri, Apr 9, 9:49 AM · Restricted Project
stelios-arm added inline comments to D99272: [AArch64] Adds a pre-indexed paired Load/Store optimization for LDR-STR..
Fri, Apr 9, 4:50 AM · Restricted Project
stelios-arm added a comment to D99272: [AArch64] Adds a pre-indexed paired Load/Store optimization for LDR-STR..

Hi Stelios, many thanks for putting this together, good stuff.
I will do a code-review a bit later, but as there's potential for some corner cases here, first a testing question. Did you do a bootstrap build and e.g. ran the llvm test suite?

Fri, Apr 9, 4:44 AM · Restricted Project
stelios-arm updated the diff for D99272: [AArch64] Adds a pre-indexed paired Load/Store optimization for LDR-STR..
  1. Added all the various forms of STR<>pre/LDR<>pre.
  2. Added additional test cases for the MIR tests to cover the various forms of STR<>pre/LDR<>pre.
  3. Added constraints so that it optimizes cases where the offset of the second LDR/STR<>ui is equal to the size of the destination register. Additionally, it only optimizes cases where the base register of the pre-index LDR/STRpre<> is not used or modified.
  4. Did a bootstrap build and ran the llvm test-suite on an AArch64 machine. Both the test-suite and regression tests results in no errors.
  5. Currently there is a hack to avoid the memoperands_empty() check for LDR<>pre instructions. This is because they are missing the load memory operand. See below:
Fri, Apr 9, 4:39 AM · Restricted Project

Mar 24 2021

stelios-arm added inline comments to D99272: [AArch64] Adds a pre-indexed paired Load/Store optimization for LDR-STR..
Mar 24 2021, 9:07 AM · Restricted Project
stelios-arm requested review of D99272: [AArch64] Adds a pre-indexed paired Load/Store optimization for LDR-STR..
Mar 24 2021, 8:50 AM · Restricted Project

Mar 15 2021

stelios-arm committed rGab86edbc88fa: [AArch64] Implement __rndr, __rndrrs intrinsics (authored by stelios-arm).
[AArch64] Implement __rndr, __rndrrs intrinsics
Mar 15 2021, 10:52 AM
stelios-arm closed D98264: [AArch64] Implement __rndr, __rndrrs intrinsics.
Mar 15 2021, 10:52 AM · Restricted Project, Restricted Project
stelios-arm updated the diff for D98264: [AArch64] Implement __rndr, __rndrrs intrinsics.

Typo fix for __ARM_FEATURE_RNG macro check in aarch64-target-features.c.

Mar 15 2021, 9:34 AM · Restricted Project, Restricted Project
stelios-arm updated the diff for D98264: [AArch64] Implement __rndr, __rndrrs intrinsics.

Changed the rand.ll llc arguments to the ones that are only relevant.

Mar 15 2021, 8:26 AM · Restricted Project, Restricted Project
stelios-arm updated the diff for D98264: [AArch64] Implement __rndr, __rndrrs intrinsics.

Added tests in arm_acle.c.

Mar 15 2021, 5:26 AM · Restricted Project, Restricted Project
stelios-arm added inline comments to D98264: [AArch64] Implement __rndr, __rndrrs intrinsics.
Mar 15 2021, 2:28 AM · Restricted Project, Restricted Project

Mar 12 2021

stelios-arm added inline comments to D98264: [AArch64] Implement __rndr, __rndrrs intrinsics.
Mar 12 2021, 7:04 AM · Restricted Project, Restricted Project
stelios-arm updated the diff for D98264: [AArch64] Implement __rndr, __rndrrs intrinsics.
  1. Removed a redundant comment
  2. Removed the changes made in the test/CodeGen/arm_acle.c, since the test is disabled.
  3. Added a clang preprocessor test to check the presence and absence of the __ARM_FEATURE_RNG macro.
Mar 12 2021, 7:00 AM · Restricted Project, Restricted Project

Mar 11 2021

stelios-arm updated the diff for D98264: [AArch64] Implement __rndr, __rndrrs intrinsics.

Rephrased a comment.

Mar 11 2021, 5:46 AM · Restricted Project, Restricted Project
stelios-arm updated the diff for D98264: [AArch64] Implement __rndr, __rndrrs intrinsics.
  1. Addressed the comment made by @SjoerdMeijer and added the comment for the MRS instruction.
  2. Added the +rang feature in arm_acle.c
Mar 11 2021, 5:29 AM · Restricted Project, Restricted Project

Mar 10 2021

stelios-arm updated the diff for D98264: [AArch64] Implement __rndr, __rndrrs intrinsics.

Addressed the comments made by @SjoerdMeijer and @dmgreen.

Mar 10 2021, 4:30 PM · Restricted Project, Restricted Project
stelios-arm added inline comments to D98264: [AArch64] Implement __rndr, __rndrrs intrinsics.
Mar 10 2021, 4:26 PM · Restricted Project, Restricted Project
stelios-arm added a comment to D98264: [AArch64] Implement __rndr, __rndrrs intrinsics.

@SjoerdMeijer @dmgreen Thanks for your reviews, I will be looking into this.

Mar 10 2021, 2:32 AM · Restricted Project, Restricted Project

Mar 9 2021

stelios-arm requested review of D98264: [AArch64] Implement __rndr, __rndrrs intrinsics.
Mar 9 2021, 8:01 AM · Restricted Project, Restricted Project

Mar 2 2021

stelios-arm closed D97380: [AArch64] Add abs intrinsic costs.
Mar 2 2021, 1:28 AM · Restricted Project
stelios-arm added a comment to D97380: [AArch64] Add abs intrinsic costs.

Closed by git revision 30cb9c03b53ee03af2cdf16f4ee645e5dcff7e21.

Mar 2 2021, 12:58 AM · Restricted Project

Feb 25 2021

stelios-arm committed rG30cb9c03b53e: [AArch64] Add abs intrinsic costs (authored by stelios-arm).
[AArch64] Add abs intrinsic costs
Feb 25 2021, 2:03 AM

Feb 24 2021

stelios-arm requested review of D97380: [AArch64] Add abs intrinsic costs.
Feb 24 2021, 6:57 AM · Restricted Project