Page MenuHomePhabricator

stefanhaller (Stefan Haller)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 30 2022, 6:02 AM (9 w, 8 h)

Recent Activity

May 13 2022

stefanhaller added a comment to D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac.

Looks great! I'm happy to land it, will do so on Tuesday unless anyone has further comments.

May 13 2022, 1:32 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 7 2022

stefanhaller added a comment to D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac.

@sammccall I addressed your last change requests with a revised patch, do you want to have a final look?

May 7 2022, 2:07 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 6 2022

stefanhaller retitled D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac from Use QoS class Utility for ThreadPriority::Low on Mac to Add ThreadPriority::Low, and use QoS class Utility on Mac.
May 6 2022, 3:02 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
stefanhaller updated the diff for D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac.
  • Added a comment to setThreadBackgroundPriority
  • Improved comments for ThreadPriority enum
  • Add FIXME comments for Windows and Linux
May 6 2022, 3:00 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
stefanhaller updated the diff for D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac.

Updated the patch to have both Background and Low

May 6 2022, 1:56 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 5 2022

stefanhaller added a comment to D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac.

I'm still concerned some users will find this a large regression and we won't have a good workaround:

  • it'll use a lot more battery than before
May 5 2022, 4:18 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 4 2022

stefanhaller added a comment to D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac.

That said, you may want to consider dynamically switching to background if running on laptop with battery, or other heuristics,

May 4 2022, 11:44 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
stefanhaller added a comment to D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac.

(How) does this interact with battery vs mains power on laptops?
It seems like there's a common scenario where:

  • the user is on a relatively slow laptop, running off battery
  • the codebase is large, and indexing is unlikely to finish within an editing session

In this case, it seems like only using efficiency cores is what you'd want, and that people are likely to be upset if clangd 15 keeps their performance cores running at all times.

May 4 2022, 12:02 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 30 2022

stefanhaller updated the diff for D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac.

Fix documentation of ThreadPriority::Low (was: Background), and move it up from
set_thread_priority to ThreadPriority.

Apr 30 2022, 8:57 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
stefanhaller added reviewers for D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac: sammccall, dgoldman, akyrtzi, kadircet.
Apr 30 2022, 7:58 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
stefanhaller requested review of D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac.
Apr 30 2022, 7:55 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project