In D124715#3498846, @sammccall wrote:

Looks great! I'm happy to land it, will do so on Tuesday unless anyone has further comments.

@sammccall I addressed your last change requests with a revised patch, do you want to have a final look?

• Added a comment to setThreadBackgroundPriority
• Improved comments for ThreadPriority enum
• Add FIXME comments for Windows and Linux

Updated the patch to have both Background and Low

In D124715#3491985, @sammccall wrote:

I'm still concerned some users will find this a large regression and we won't have a good workaround:

• it'll use a lot more battery than before

In D124715#3491782, @akyrtzi wrote:

That said, you may want to consider dynamically switching to background if running on laptop with battery, or other heuristics,

In D124715#3488447, @sammccall wrote:

(How) does this interact with battery vs mains power on laptops?
It seems like there's a common scenario where:

• the user is on a relatively slow laptop, running off battery
• the codebase is large, and indexing is unlikely to finish within an editing session

In this case, it seems like only using efficiency cores is what you'd want, and that people are likely to be upset if clangd 15 keeps their performance cores running at all times.

Fix documentation of ThreadPriority::Low (was: Background), and move it up from
set_thread_priority to ThreadPriority.