Page MenuHomePhabricator

stefan_reinalter (Stefan Reinalter)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 6 2018, 9:18 AM (113 w, 2 d)

Recent Activity

Jul 18 2018

stefan_reinalter added inline comments to D49366: [LLD][COFF] Add support for /FUNCTIONPADMIN command-line option.
Jul 18 2018, 3:28 AM · Restricted Project, lld
stefan_reinalter updated the diff for D49230: Add support for COFF groups in * Linker * compiland in PDB.

Updated diff to only contain formatted changes for new code.

Jul 18 2018, 3:20 AM · lld
stefan_reinalter updated the diff for D49231: Add import libraries to list of modules in PDB.

Updated diff to only contain formatted changes for new code.

Jul 18 2018, 3:19 AM · lld

Jul 17 2018

stefan_reinalter added a comment to D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).

Also: Just noticed that response files aren't being expanded inline in the stored command-line (as per MSVC link.exe). I'll open a bug for it.

Jul 17 2018, 7:13 AM · lld
stefan_reinalter updated the diff for D49366: [LLD][COFF] Add support for /FUNCTIONPADMIN command-line option.

I updated the implementation according to the recommendation by Peter. I also added a comment regarding /FUNCTIONPADMIN default padding on ARM platforms.
Also ran git-clang-format against the source files so that the diff shows only my changes.

Jul 17 2018, 6:55 AM · Restricted Project, lld
stefan_reinalter added inline comments to D49366: [LLD][COFF] Add support for /FUNCTIONPADMIN command-line option.
Jul 17 2018, 6:13 AM · Restricted Project, lld
stefan_reinalter added a comment to D49366: [LLD][COFF] Add support for /FUNCTIONPADMIN command-line option.
In D49366#1163821, @pcc wrote:

Unless I'm missing something, doesn't this patch end up adding padding to the end of every code section rather than the beginning?

It seems like this ought to be implemented by changing the section layout code. I'm thinking that you would add code to http://llvm-cs.pcc.me.uk/tools/lld/COFF/Writer.cpp#742 that does this:

if (C requires padding) {
  RawSize += Padding;
  VirtualSize += Padding;
}

With that I don't think you need to add fields for storing the amount of padding required, you can just figure it out on the fly there.

Jul 17 2018, 5:34 AM · Restricted Project, lld

Jul 16 2018

stefan_reinalter added inline comments to D49366: [LLD][COFF] Add support for /FUNCTIONPADMIN command-line option.
Jul 16 2018, 9:28 AM · Restricted Project, lld
stefan_reinalter created D49366: [LLD][COFF] Add support for /FUNCTIONPADMIN command-line option.
Jul 16 2018, 2:16 AM · Restricted Project, lld

Jul 12 2018

stefan_reinalter created D49231: Add import libraries to list of modules in PDB.
Jul 12 2018, 6:05 AM · lld
stefan_reinalter created D49230: Add support for COFF groups in * Linker * compiland in PDB.
Jul 12 2018, 5:59 AM · lld