Page MenuHomePhabricator

stanshebs (Stan Shebs)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 19 2018, 2:06 PM (150 w, 5 d)

Recent Activity

Oct 23 2020

stanshebs added a comment to D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.

@MaskRay
Sorry... can you pause on this for a second. I want to talk to the glibc guys about this first.

@stefanp I already did it... I think this is a problem for many ld.so implementations. For example, musl has

if ((def.sym->st_info&0xf) == STT_TLS)
         return __tls_get_addr((tls_mod_off_t []){def.dso->tls_id, def.sym->st_value-DTP_OFFSET});

It was broken as well...

Can you give me more information about one of these examples?
I want to try to reproduce this myself and I want to talk to some people on glibc as well.
I'm affraid that it is possible to get incorrect code gen in these situations and so I want to try it out myself.

So, what glibc source did you use and how did you compile it?

Oct 23 2020, 12:31 PM · Restricted Project

Dec 9 2019

stanshebs added a comment to D71094: [libc] Add implementation of errno and define the other macros of errno.h..

errno is a fundamental component baked in almost every component of a libc and contributors/reviewers should really be on the same page. Both abrachet and stanshebs accepted the patch and they were the initially-added reviewers. I feel a bit lonely to be the only one in the "Request Changes" camp, but I hope you do not commit the patch with these open issues not resolved. To reiterate, I feel strong about my suggested items:

  • __attribute__((visibility("hidden"))) in the internal header.
  • __attribute__((const)) in the public header.

They are adopted by both glibc and musl.

You are reluctant to add hidden visibility because you feel that it may make overlaying llvm-libc on top of system libc harder? Can you discuss more about the details somewhere, e.g. libc-dev or llvm-dev?

Dec 9 2019, 11:57 AM · Restricted Project
stanshebs accepted D71094: [libc] Add implementation of errno and define the other macros of errno.h..
Dec 9 2019, 9:56 AM · Restricted Project

Dec 6 2019

stanshebs added inline comments to D71094: [libc] Add implementation of errno and define the other macros of errno.h..
Dec 6 2019, 12:06 PM · Restricted Project