Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

srishti-pm (Srishti Srivastava)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 4 2021, 9:36 PM (126 w, 18 h)

Recent Activity

Sep 30 2023

srishti-pm added inline comments to D158941: [MLIR][transforms] Fix `cloneInto()` error in `RemoveDeadValues` pass.
Sep 30 2023, 3:21 PM · Restricted Project, Restricted Project

Aug 26 2023

srishti-pm committed rGb6bab6db9bea: [MLIR][transforms] Fix `cloneInto()` error in `RemoveDeadValues` pass (authored by srishti-pm).
[MLIR][transforms] Fix `cloneInto()` error in `RemoveDeadValues` pass
Aug 26 2023, 12:50 PM · Restricted Project, Restricted Project
srishti-pm closed D158941: [MLIR][transforms] Fix `cloneInto()` error in `RemoveDeadValues` pass.
Aug 26 2023, 12:50 PM · Restricted Project, Restricted Project
srishti-pm accepted D158941: [MLIR][transforms] Fix `cloneInto()` error in `RemoveDeadValues` pass.
Aug 26 2023, 12:10 PM · Restricted Project, Restricted Project
srishti-pm updated the diff for D158941: [MLIR][transforms] Fix `cloneInto()` error in `RemoveDeadValues` pass.

Rebase to main.

Aug 26 2023, 11:24 AM · Restricted Project, Restricted Project
srishti-pm added a comment to D158941: [MLIR][transforms] Fix `cloneInto()` error in `RemoveDeadValues` pass.

I'm planning on accepting and landing this change soon because it is trivial and crucial.

Aug 26 2023, 11:21 AM · Restricted Project, Restricted Project
srishti-pm added reviewers for D158941: [MLIR][transforms] Fix `cloneInto()` error in `RemoveDeadValues` pass: srishti-pm, matthiaskramm.
Aug 26 2023, 11:11 AM · Restricted Project, Restricted Project
srishti-pm requested review of D158941: [MLIR][transforms] Fix `cloneInto()` error in `RemoveDeadValues` pass.
Aug 26 2023, 11:08 AM · Restricted Project, Restricted Project

Aug 25 2023

srishti-pm added a comment to D158444: [mlir] Commutative Operand Sorting Pass.

Please update the commit summary. It only contains the title currently. Also, change your revision and commit titles to [MLIR][transforms] Add a pass to sort commutative operands.

Aug 25 2023, 4:08 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D157528: [mlir] Commutativity Operand Sorting Pattern Bug Fixes.

For Bug 4, the assertion error initially was only encountered on the Windows version of the build in this patch. My local Linux environment and the Linux build were both unable to catch this. Although there is no previously broken test case that gets resolved via this fix, it is a big problem that will cause failures at runtime. The assertion exists within stable_sort to prevent the endless swapping of equal operands if the comparison method returns true for those cases.

Aug 25 2023, 4:06 PM · Restricted Project, Restricted Project

Aug 23 2023

srishti-pm added a comment to D157528: [mlir] Commutativity Operand Sorting Pattern Bug Fixes.

! In D157528#4608458, @amandatang wrote:
example1_test, example2_test and check_commutative_small_similar_ancestor_tree are the only tests that worked prior to the fixes in this patch.

Aug 23 2023, 5:07 PM · Restricted Project, Restricted Project
srishti-pm committed rG0e98fb9fadb0: [MLIR][transforms] Add an optimization pass to remove dead values (authored by srishti-pm).
[MLIR][transforms] Add an optimization pass to remove dead values
Aug 23 2023, 4:55 PM · Restricted Project, Restricted Project
srishti-pm closed D157049: [MLIR][transforms] Add an optimization pass to remove dead values.
Aug 23 2023, 4:55 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Also, thanks @matthiaskramm, @Mogball, and @jcai19 for reviewing and approving this patch. I'm waiting for the build and tests to pass here and then will land this.

Aug 23 2023, 3:51 PM · Restricted Project, Restricted Project
srishti-pm updated the summary of D157049: [MLIR][transforms] Add an optimization pass to remove dead values.
Aug 23 2023, 3:48 PM · Restricted Project, Restricted Project
srishti-pm retitled D157049: [MLIR][transforms] Add an optimization pass to remove dead values from [MLIR][transforms] Add an optimization pass to remove non-live values to [MLIR][transforms] Add an optimization pass to remove dead values.
Aug 23 2023, 3:45 PM · Restricted Project, Restricted Project
srishti-pm updated the diff for D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Rename pass to RemoveDeadValues and propoagate this change to code comments and commit summary.

Aug 23 2023, 3:45 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Thank you all for your comments. Based on the above comments from @Mogball, @jcai19, and @matthiaskramm, I'm renaming the pass to removeDeadValues.

Aug 23 2023, 3:12 PM · Restricted Project, Restricted Project
srishti-pm updated the diff for D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Call op arg operands handling.

Aug 23 2023, 3:08 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D157528: [mlir] Commutativity Operand Sorting Pattern Bug Fixes.

Bug 2 and bug 3 are related. When the visitedAncestor check in line 152 is removed, it causes block arguments to not be added to the ancestorQueue. Originally, block arguments are only added because nullptr is not in the visitedAncestor set, so either way, the logic is not sound despite being functional. There could also be additional block argument cast and check to make this more safe.

if (!operandDefOp || !visitedAncestors.contains(operandDefOp))
Aug 23 2023, 3:06 PM · Restricted Project, Restricted Project
srishti-pm updated the diff for D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Rebase to main

Aug 23 2023, 1:42 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D157528: [mlir] Commutativity Operand Sorting Pattern Bug Fixes.

Some of the bug fixes, when moved to their own commit, also caused existing and previously correct test cases to fail.

Why will this happen if your fix is correct? I'd suggest making sure your fix is correct and doesn't have a bug in itself.

Because fixing each bug individually means the other 3 bugs remain unaddressed in each patch. Those unaddressed bugs causes problems in the tests that are not due to the fix itself. Sorry the wording was a bit confusing in my last comment.

Aug 23 2023, 11:44 AM · Restricted Project, Restricted Project

Aug 22 2023

srishti-pm added a comment to D157528: [mlir] Commutativity Operand Sorting Pattern Bug Fixes.

Some of the bug fixes, when moved to their own commit, also caused existing and previously correct test cases to fail.

Aug 22 2023, 10:04 PM · Restricted Project, Restricted Project
srishti-pm requested changes to D158444: [mlir] Commutative Operand Sorting Pass.

Thanks for adding this. An initial comment:-

Aug 22 2023, 2:57 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D157528: [mlir] Commutativity Operand Sorting Pattern Bug Fixes.

@srishti-pm Let me know if these two examples make sense

Aug 22 2023, 2:33 PM · Restricted Project, Restricted Project
srishti-pm requested changes to D157528: [mlir] Commutativity Operand Sorting Pattern Bug Fixes.

Thank you for working on this. There are a few issues here. Listing them below:-

Aug 22 2023, 2:31 PM · Restricted Project, Restricted Project

Aug 21 2023

srishti-pm updated the diff for D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Nit changes.

Aug 21 2023, 5:03 PM · Restricted Project, Restricted Project
srishti-pm updated the summary of D157049: [MLIR][transforms] Add an optimization pass to remove dead values.
Aug 21 2023, 5:02 PM · Restricted Project, Restricted Project
srishti-pm updated the diff for D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Update commit summary to reflect recent changes.

Aug 21 2023, 5:01 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

@Mogball and @jcai19, I have addressed all your comments. Thanks for the review!
@matthiaskramm, thank you for the clarification on the naming!
@mehdi_amini, awaiting your re-review and/or response, thanks! :)

Aug 21 2023, 4:57 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Naming nit: Can this be called removeDeadValues?

Thanks for bringing this up! This is actually an important discussion. We can't call it removeDeadValues because "non-live" doesn't mean "dead". Something could be "non-live" and not "dead". Also, something could be "dead" and not "non-live". Both these are orthogonal to each other.

"dead" (like in "dead code elimination") refers to instructions that should theoretically never execute on the hardware.

I think we should add comments here clarifying "dead" in MLIR means unreachable code and therefore we have to call this analysis "non-live".

Aug 21 2023, 4:54 PM · Restricted Project, Restricted Project
srishti-pm updated the diff for D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Address all comments given so far.

Aug 21 2023, 4:54 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Naming nit: Can this be called removeDeadValues?

Thanks for bringing this up! This is actually an important discussion. We can't call it removeDeadValues because "non-live" doesn't mean "dead". Something could be "non-live" and not "dead". Also, something could be "dead" and not "non-live". Both these are orthogonal to each other.

"dead" (like in "dead code elimination") refers to instructions that should theoretically never execute on the hardware.

I think we should add comments here clarifying "dead" in MLIR means unreachable code and therefore we have to call this analysis "non-live".

There are counter examples to this: "Dead-store elimination" for example is not about "stores that are unreachable", but ones that don't have observable effects.

Aug 21 2023, 11:38 AM · Restricted Project, Restricted Project
srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Thanks for your comments, @Mogball. Working on addressing them.

Aug 21 2023, 10:59 AM · Restricted Project, Restricted Project

Aug 18 2023

srishti-pm requested review of D157049: [MLIR][transforms] Add an optimization pass to remove dead values.
Aug 18 2023, 3:16 PM · Restricted Project, Restricted Project

Aug 17 2023

srishti-pm updated the summary of D153779: [MLIR][ANALYSIS] Add liveness analysis utility.
Aug 17 2023, 8:41 PM · Restricted Project, Restricted Project

Aug 16 2023

srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

! In D157049#4577762, @srishti-pm wrote:
Again, it should be noted here that since this patch introduces this pass, it may not be perfect. The pass relies on liveness analysis which isn't perfect and liveness analysis relies on sparse backward dataflow which isn't perfect. But, theoretically speaking, if we assume that sparse backward dataflow analysis is perfect, liveness analysis is perfect, and this pass is perfect (as in, no forms of IR have been missed), the above holds true. I am also parallely trying to make these things perfect. Some patches that work towards that are here: https://reviews.llvm.org/D156376, https://reviews.llvm.org/D157261. It is potentially a long way to go. Hopefully we can achieve that 😅

Does this make sense?

Aug 16 2023, 1:44 AM · Restricted Project, Restricted Project
srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

@mehdi_amini

I can understand the theoretical view, but that seems a bit simplistic to me: liveness analysis has to be conservative, and it's not clear to me that canonicalization can't just improve the capability of the analysis.

I don't understand your question. Can you kindly re-state it?

I mean that liveness must say that a value is live when there is a doubt, otherwise we're kill a useful value for example. That's the conservative part.
Now I would think that the analysis cannot provide good results without canonicalization, that is it would most often say "I don't know so I'll say it is live".

Aug 16 2023, 1:41 AM · Restricted Project, Restricted Project

Aug 15 2023

srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

@mehdi_amini , theoretically, do you agree liveness analysis gets no benefit from canonicalization?

Aug 15 2023, 10:50 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

I can understand the theoretical view, but that seems a bit simplistic to me: liveness analysis has to be conservative, and it's not clear to me that canonicalization can't just improve the capability of the analysis.

I don't understand your question. Can you kindly re-state it?

Aug 15 2023, 10:43 PM · Restricted Project, Restricted Project
srishti-pm updated the summary of D157049: [MLIR][transforms] Add an optimization pass to remove dead values.
Aug 15 2023, 1:57 PM · Restricted Project, Restricted Project
srishti-pm updated the diff for D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Nit changes.

Aug 15 2023, 1:55 PM · Restricted Project, Restricted Project
srishti-pm updated the diff for D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Fix handling of region branch and region branch terminator ops based on the recent changes to their interface methods.

Aug 15 2023, 12:02 PM · Restricted Project, Restricted Project

Aug 14 2023

srishti-pm updated the diff for D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

clang-format

Aug 14 2023, 6:50 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

All comments here have been addressed and/or answered to. Awaiting a re-review @mehdi_amini, @Mogball, and @jcai19.

Aug 14 2023, 2:09 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

I understand the issue. Working on making the "value added by this pass" clearer.

Aug 14 2023, 2:08 PM · Restricted Project, Restricted Project
srishti-pm updated the summary of D157049: [MLIR][transforms] Add an optimization pass to remove dead values.
Aug 14 2023, 2:07 PM · Restricted Project, Restricted Project
srishti-pm updated the summary of D157049: [MLIR][transforms] Add an optimization pass to remove dead values.
Aug 14 2023, 2:04 PM · Restricted Project, Restricted Project
srishti-pm updated the summary of D157049: [MLIR][transforms] Add an optimization pass to remove dead values.
Aug 14 2023, 2:03 PM · Restricted Project, Restricted Project
srishti-pm added inline comments to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.
Aug 14 2023, 1:53 PM · Restricted Project, Restricted Project
srishti-pm updated the diff for D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Address @Mogball and @mehdi_amini's comments.

Aug 14 2023, 1:53 PM · Restricted Project, Restricted Project

Aug 11 2023

srishti-pm updated the diff for D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Rebase to main.

Aug 11 2023, 11:20 AM · Restricted Project, Restricted Project
srishti-pm committed rG232f8eadae18: [MLIR][analysis] Fix call op handling in sparse backward dataflow (authored by srishti-pm).
[MLIR][analysis] Fix call op handling in sparse backward dataflow
Aug 11 2023, 10:27 AM · Restricted Project, Restricted Project
srishti-pm closed D157261: [MLIR][analysis] Fix call op handling in sparse backward dataflow.
Aug 11 2023, 10:27 AM · Restricted Project, Restricted Project

Aug 10 2023

srishti-pm updated the diff for D157261: [MLIR][analysis] Fix call op handling in sparse backward dataflow.

Rebased to main.

Aug 10 2023, 1:32 PM · Restricted Project, Restricted Project
srishti-pm updated the diff for D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Address Jian's comment.

Aug 10 2023, 11:52 AM · Restricted Project, Restricted Project
srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

One specific question that came to mind right now is: is this pass idempotent or would rerunning it a second time (recomputing the analysis) provide a different result? What about the interleaving with canonicalization?

The pass is idempotent. The analysis is idempotent too. What do you mean by "what about the interleaving with canonicalization"?

It is about idempotence of canonicalization + this pass.
So If I run: --pass-pipeline=builtin.module(remove-non-live-values, canonicalize) ; do I always get the same result as --pass-pipeline=builtin.module(remove-non-live-values, canonicalize, remove-non-live-values, canonicalize)

Aug 10 2023, 11:33 AM · Restricted Project, Restricted Project

Aug 9 2023

srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

They're just optimizations that don't happen in canonicalize because patterns to perform those canonicalizations haven't been added to that particular op (like, say, the scf.while op). On the tests that I have added for the intra-procedural cases, we see signification optimization that this pass is able to do but if we run canonicalize on the same tests, it does nothing to the IR. Is this what you're asking or did I misunderstand your question?

Yes: basically you are proposing to introduce a new pass, if it is just "this pass does not do more than canonicalization", the value proposal isn't clear. Right now there is nothing in either the review description or the pass description that provides any context on this.
So, my questions are all about prompting on the value proposition of this work, by contrasting it to something we all know (canonicalize).

Aug 9 2023, 7:04 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

One specific question that came to mind right now is: is this pass idempotent or would rerunning it a second time (recomputing the analysis) provide a different result? What about the interleaving with canonicalization?

Aug 9 2023, 6:52 PM · Restricted Project, Restricted Project
srishti-pm added inline comments to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.
Aug 9 2023, 6:46 PM · Restricted Project, Restricted Project
srishti-pm added inline comments to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.
Aug 9 2023, 6:42 PM · Restricted Project, Restricted Project
srishti-pm added inline comments to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.
Aug 9 2023, 6:36 PM · Restricted Project, Restricted Project
srishti-pm updated the diff for D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Address comments.

Aug 9 2023, 6:36 PM · Restricted Project, Restricted Project
srishti-pm added inline comments to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.
Aug 9 2023, 5:44 PM · Restricted Project, Restricted Project
srishti-pm updated the summary of D157261: [MLIR][analysis] Fix call op handling in sparse backward dataflow.
Aug 9 2023, 5:14 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D157528: [mlir] Commutativity Operand Sorting Pattern Bug Fixes.

Can you make the summary precise? It's a bit long-winded and the bugs aren't clear from the summary. If you can explain a bug in one line or with a small example, it will be great. You don't need to explain the older functionality in detail.

Aug 9 2023, 5:02 PM · Restricted Project, Restricted Project
srishti-pm updated the summary of D157261: [MLIR][analysis] Fix call op handling in sparse backward dataflow.
Aug 9 2023, 4:38 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D157261: [MLIR][analysis] Fix call op handling in sparse backward dataflow.

All comments are addressed here and it is approved by two reviewers. Will wait one more day before landing this in case other reviewers would like to suggest changes too :)

Aug 9 2023, 4:28 PM · Restricted Project, Restricted Project
srishti-pm added inline comments to D157261: [MLIR][analysis] Fix call op handling in sparse backward dataflow.
Aug 9 2023, 4:26 PM · Restricted Project, Restricted Project
srishti-pm updated the diff for D157261: [MLIR][analysis] Fix call op handling in sparse backward dataflow.

Address Jian's comments.

Aug 9 2023, 4:26 PM · Restricted Project, Restricted Project
srishti-pm added a reviewer for D157261: [MLIR][analysis] Fix call op handling in sparse backward dataflow: mehdi_amini.
Aug 9 2023, 3:50 PM · Restricted Project, Restricted Project
srishti-pm added a reviewer for D157261: [MLIR][analysis] Fix call op handling in sparse backward dataflow: Mogball.
Aug 9 2023, 3:49 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Naming nit: Can this be called removeDeadValues?

Aug 9 2023, 1:01 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D157261: [MLIR][analysis] Fix call op handling in sparse backward dataflow.

All comments given so far in this patch have been addressed.

Aug 9 2023, 11:43 AM · Restricted Project, Restricted Project
srishti-pm updated the diff for D157261: [MLIR][analysis] Fix call op handling in sparse backward dataflow.

Rebased to main.

Aug 9 2023, 11:41 AM · Restricted Project, Restricted Project
srishti-pm added inline comments to D157261: [MLIR][analysis] Fix call op handling in sparse backward dataflow.
Aug 9 2023, 11:29 AM · Restricted Project, Restricted Project
srishti-pm added a reviewer for D157049: [MLIR][transforms] Add an optimization pass to remove dead values: Mogball.
Aug 9 2023, 11:25 AM · Restricted Project, Restricted Project

Aug 8 2023

srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Can you try to elaborate with how you see the difference with canonicalize in the intra-procedural case?

Aug 8 2023, 2:01 AM · Restricted Project, Restricted Project

Aug 7 2023

srishti-pm added inline comments to D157261: [MLIR][analysis] Fix call op handling in sparse backward dataflow.
Aug 7 2023, 4:35 PM · Restricted Project, Restricted Project
srishti-pm added inline comments to D157261: [MLIR][analysis] Fix call op handling in sparse backward dataflow.
Aug 7 2023, 3:50 PM · Restricted Project, Restricted Project
srishti-pm added inline comments to D157261: [MLIR][analysis] Fix call op handling in sparse backward dataflow.
Aug 7 2023, 3:47 PM · Restricted Project, Restricted Project
srishti-pm updated the diff for D157261: [MLIR][analysis] Fix call op handling in sparse backward dataflow.

Address comments.

Aug 7 2023, 3:43 PM · Restricted Project, Restricted Project
srishti-pm added inline comments to D157261: [MLIR][analysis] Fix call op handling in sparse backward dataflow.
Aug 7 2023, 2:46 PM · Restricted Project, Restricted Project
srishti-pm added inline comments to D157261: [MLIR][analysis] Fix call op handling in sparse backward dataflow.
Aug 7 2023, 2:43 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

@mehdi_amini, I have updated the unit tests. Here's how you can navigate them:-

Aug 7 2023, 2:20 PM · Restricted Project, Restricted Project
srishti-pm updated the diff for D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Update unit tests.

Aug 7 2023, 2:08 PM · Restricted Project, Restricted Project
srishti-pm retitled D157049: [MLIR][transforms] Add an optimization pass to remove dead values from [MLIR][TRANSFORMS] Add an optimization pass to remove non-live values to [MLIR][transforms] Add an optimization pass to remove non-live values.
Aug 7 2023, 11:01 AM · Restricted Project, Restricted Project
srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Do you have any case of non-interprocedural effect of this?

Aug 7 2023, 10:40 AM · Restricted Project, Restricted Project
srishti-pm added reviewers for D157261: [MLIR][analysis] Fix call op handling in sparse backward dataflow: matthiaskramm, jcai19.
Aug 7 2023, 2:09 AM · Restricted Project, Restricted Project
srishti-pm requested review of D157261: [MLIR][analysis] Fix call op handling in sparse backward dataflow.
Aug 7 2023, 2:08 AM · Restricted Project, Restricted Project

Aug 6 2023

srishti-pm updated the diff for D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Nit changes

Aug 6 2023, 7:12 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

More tests and notes to be added.

I'm working on this.

Aug 6 2023, 6:49 PM · Restricted Project, Restricted Project
srishti-pm updated the diff for D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Enhance test cases to reveal functionality difference from the canonicalize pass.

Aug 6 2023, 6:48 PM · Restricted Project, Restricted Project

Aug 3 2023

srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

More tests and notes to be added.

Aug 3 2023, 6:06 PM · Restricted Project, Restricted Project
srishti-pm updated the diff for D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Add notes about comparisons with the canonicalize pass. More tests and notes to be added.

Aug 3 2023, 6:05 PM · Restricted Project, Restricted Project
srishti-pm added inline comments to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.
Aug 3 2023, 5:41 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Can you add a bit more example that showcase how this pass catches cases that canonicalization cannot handle?

Aug 3 2023, 4:57 PM · Restricted Project, Restricted Project
srishti-pm updated the diff for D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Enhance unit tests of cleanSimpleOp().

Aug 3 2023, 4:55 PM · Restricted Project, Restricted Project
srishti-pm updated the summary of D157049: [MLIR][transforms] Add an optimization pass to remove dead values.
Aug 3 2023, 4:35 PM · Restricted Project, Restricted Project
srishti-pm updated the diff for D157049: [MLIR][transforms] Add an optimization pass to remove dead values.

Update commit summary.

Aug 3 2023, 4:34 PM · Restricted Project, Restricted Project