Page MenuHomePhabricator

srishti-pm (Srishti Srivastava)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 4 2021, 9:36 PM (51 w, 7 h)

Recent Activity

Wed, Jun 15

srishti-pm added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

Right now I'm not yet understanding all of the algorithm (haven't spent enough time on it), but I'm mostly concerned by the runtime cost of this normalization.

Wed, Jun 15, 10:18 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the diff for D124750: [MLIR] Add a utility to sort the operands of commutative ops.

Increasing pattern benefit + minor typo correction.

Wed, Jun 15, 11:53 AM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the summary of D124750: [MLIR] Add a utility to sort the operands of commutative ops.
Wed, Jun 15, 11:04 AM · Restricted Project, Restricted Project, Restricted Project
srishti-pm added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

Addressed most of the comments. A few remaining.

Wed, Jun 15, 10:58 AM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the diff for D124750: [MLIR] Add a utility to sort the operands of commutative ops.

Addressing comments.

Wed, Jun 15, 10:56 AM · Restricted Project, Restricted Project, Restricted Project

Sun, Jun 12

srishti-pm updated the diff for D124750: [MLIR] Add a utility to sort the operands of commutative ops.

Minor changes.

Sun, Jun 12, 11:34 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the summary of D124750: [MLIR] Add a utility to sort the operands of commutative ops.
Sun, Jun 12, 11:24 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the summary of D124750: [MLIR] Add a utility to sort the operands of commutative ops.
Sun, Jun 12, 11:17 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the summary of D124750: [MLIR] Add a utility to sort the operands of commutative ops.
Sun, Jun 12, 11:17 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the summary of D124750: [MLIR] Add a utility to sort the operands of commutative ops.
Sun, Jun 12, 11:15 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the summary of D124750: [MLIR] Add a utility to sort the operands of commutative ops.
Sun, Jun 12, 11:14 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the summary of D124750: [MLIR] Add a utility to sort the operands of commutative ops.
Sun, Jun 12, 11:13 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the summary of D124750: [MLIR] Add a utility to sort the operands of commutative ops.
Sun, Jun 12, 10:29 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the diff for D124750: [MLIR] Add a utility to sort the operands of commutative ops.

Addressed all the comments.

Sun, Jun 12, 10:24 PM · Restricted Project, Restricted Project, Restricted Project

May 23 2022

srishti-pm added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

@Mogball @mehdi_amini @jpienaar, sorry there haven't been any updates from my side here for the past 10 or so days. I had been busy in some other tasks. I have started working on this again.

May 23 2022, 1:00 AM · Restricted Project, Restricted Project, Restricted Project

May 16 2022

srishti-pm removed reviewers for D118684: [MLIR][PDLInterp] Define new ops in PDLInterp to support commutativity: rriddle, sfuniak, Mogball.
May 16 2022, 8:20 PM · Restricted Project, Restricted Project
srishti-pm removed reviewers for D118683: [MLIR][PDL] Add optional attribute to enable commutativity in PDL: rriddle, sfuniak.
May 16 2022, 8:19 PM · Restricted Project, Restricted Project
srishti-pm removed reviewers for D118689: [MLIR][PDL] Execute nondeterministic bytecode & lower some PDLInterp ops: Mogball, rriddle, sfuniak.
May 16 2022, 8:19 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D118689: [MLIR][PDL] Execute nondeterministic bytecode & lower some PDLInterp ops.

This change is obsolete now, based on our concluding remark here: https://discourse.llvm.org/t/mlir-pdl-extending-pdl-pdlinterp-bytecode-to-enable-commutative-matching/60798/19 and my new solution here: https://reviews.llvm.org/D124750.

May 16 2022, 8:19 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D118684: [MLIR][PDLInterp] Define new ops in PDLInterp to support commutativity.

This change is obsolete now, based on our concluding remark here: https://discourse.llvm.org/t/mlir-pdl-extending-pdl-pdlinterp-bytecode-to-enable-commutative-matching/60798/19 and my new solution here: https://reviews.llvm.org/D124750.

May 16 2022, 8:18 PM · Restricted Project, Restricted Project

May 10 2022

srishti-pm added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

Replying to the various comments given in this revision:

May 10 2022, 4:20 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

Thanks for improving the doc! Are you moving this to be used in canonicalization next?
I think a first good step would be to make it a pattern and test it with a pass that applies it in the greedy rewriter. I would land this first and then try to enable this in the canonicalized.

May 10 2022, 4:00 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the diff for D124750: [MLIR] Add a utility to sort the operands of commutative ops.

Fixing a minor typo.

May 10 2022, 2:30 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the summary of D124750: [MLIR] Add a utility to sort the operands of commutative ops.
May 10 2022, 2:26 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the summary of D124750: [MLIR] Add a utility to sort the operands of commutative ops.
May 10 2022, 2:25 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the summary of D124750: [MLIR] Add a utility to sort the operands of commutative ops.
May 10 2022, 2:24 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the summary of D124750: [MLIR] Add a utility to sort the operands of commutative ops.
May 10 2022, 2:21 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the summary of D124750: [MLIR] Add a utility to sort the operands of commutative ops.
May 10 2022, 2:20 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the diff for D124750: [MLIR] Add a utility to sort the operands of commutative ops.

Improving the documentation of the functionality of this utility to make it more clear.

May 10 2022, 2:16 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

Why? Again your description of the sort is as follow:

May 10 2022, 2:00 AM · Restricted Project, Restricted Project, Restricted Project
srishti-pm added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

Every time the algorithm would consider a commutative op, that is all the op, it would recurse and try to re-sort the current slice, processing the same ops over and over.

May 10 2022, 1:56 AM · Restricted Project, Restricted Project, Restricted Project
srishti-pm added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

So: I understand that the producers should be sorted for a pattern to apply, but our disconnect earlier is that my usual approach to see canonicalization is to process an entire block/region, and as such we don't work on slices but on operation in order until fix-point. I'm a bit concerned about efficiency of your approach, because when integrated in a framework that actually visit the entire block you would recompute subset of the same slice over and over and re-attempt to sort everything multiple times:

May 10 2022, 1:54 AM · Restricted Project, Restricted Project, Restricted Project
srishti-pm added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

So far you explained "what is canonicalization and why are we canonicalizing", the same rationale applies to "push constant to the right" that we do already in canonicalization, and this is exactly why I asked before whether we could do what you're doing as a canonicalization.

May 10 2022, 1:45 AM · Restricted Project, Restricted Project, Restricted Project
srishti-pm added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

My "why?" question is about canonicalization: could this be a canonicalization and if so why / why not? This is an important thing to answer before looking into the discussion below actually:

May 10 2022, 1:41 AM · Restricted Project, Restricted Project, Restricted Project

May 9 2022

srishti-pm updated the summary of D124750: [MLIR] Add a utility to sort the operands of commutative ops.
May 9 2022, 11:54 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the diff for D124750: [MLIR] Add a utility to sort the operands of commutative ops.

Made the sorting strictly stable.

May 9 2022, 11:51 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

You're telling me "what" while I'm actually more interested in the "why" here?

May 9 2022, 6:19 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the diff for D124750: [MLIR] Add a utility to sort the operands of commutative ops.

Within constant-like ops, removed the requirement for them being sorted alphabetically. Basically, all constants will be treated as equals by the sorting algorithm and it will not distinguish between, say, arith.constant and tf.Const. This is because multiple canonicalizations exist in various dialects that push the constants to the right but do not make any distinction among constants. So, since we want this utility to not clash with those canonicalizations, this is being done.

May 9 2022, 4:51 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

Seems like this should be added to canonicalization? The "push constants to the right hand side" is there already.

May 9 2022, 4:33 PM · Restricted Project, Restricted Project, Restricted Project

May 8 2022

srishti-pm added reviewers for D124750: [MLIR] Add a utility to sort the operands of commutative ops: stephenneuendorffer, shauheen, antiagainst, arpith-jacob, mgester, liufengdb.
May 8 2022, 6:35 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the diff for D124750: [MLIR] Add a utility to sort the operands of commutative ops.

Fixing a comment typo and enhancing the commit summary even further.

May 8 2022, 6:31 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the summary of D124750: [MLIR] Add a utility to sort the operands of commutative ops.
May 8 2022, 6:26 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm added reviewers for D124750: [MLIR] Add a utility to sort the operands of commutative ops: nicolasvasilache, mehdi_amini, rriddle, aartbik, Chia-hungDuan, bondhugula, vinayaka-polymage.
May 8 2022, 6:25 PM · Restricted Project, Restricted Project, Restricted Project

May 1 2022

srishti-pm updated the summary of D124750: [MLIR] Add a utility to sort the operands of commutative ops.
May 1 2022, 10:55 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm updated the diff for D124750: [MLIR] Add a utility to sort the operands of commutative ops.

Improving the commit summary

May 1 2022, 10:53 PM · Restricted Project, Restricted Project, Restricted Project
srishti-pm requested review of D124750: [MLIR] Add a utility to sort the operands of commutative ops.
May 1 2022, 10:31 PM · Restricted Project, Restricted Project, Restricted Project

Apr 17 2022

srishti-pm added a comment to D118683: [MLIR][PDL] Add optional attribute to enable commutativity in PDL.

This change is obsolete now, based on our concluding remark here: https://discourse.llvm.org/t/mlir-pdl-extending-pdl-pdlinterp-bytecode-to-enable-commutative-matching/60798/19?u=srishtisrivastava. I am currently working on the finalized utility and will create a revision to incorporate the same into llvm-project.

Apr 17 2022, 3:14 PM · Restricted Project, Restricted Project

Mar 8 2022

srishti-pm added a comment to D118683: [MLIR][PDL] Add optional attribute to enable commutativity in PDL.

The implementation of commutative matching is very byte-code heavy but it's effectively just permuting every combination of operands. I think this can be implemented by just generating one pattern for every combination. Commutative patterns for an arbitrary number of operands are undesirable in both cases due to combinatorial explosion... Generally the approach is to have a canonical form for the order of operands. I wonder if this could be implemented generatively by creating patterns that reorder operands to the "canonical" form set by the commutative pattern.

Mar 8 2022, 11:01 PM · Restricted Project, Restricted Project
srishti-pm added a comment to D118683: [MLIR][PDL] Add optional attribute to enable commutativity in PDL.

Can you post an RFC on discourse discussing the desired extensions to PDL/PDLInterp/ByteCode to enable commutative matching? I know @Mogball had some concerns about some extensions to the PDLInterp/bytecode, and it would be good to discuss the full design.

Mar 8 2022, 10:57 PM · Restricted Project, Restricted Project

Mar 4 2022

srishti-pm added inline comments to D118684: [MLIR][PDLInterp] Define new ops in PDLInterp to support commutativity.
Mar 4 2022, 2:34 AM · Restricted Project, Restricted Project

Mar 2 2022

srishti-pm added inline comments to D118689: [MLIR][PDL] Execute nondeterministic bytecode & lower some PDLInterp ops.
Mar 2 2022, 11:11 AM · Restricted Project, Restricted Project
Herald added a project to D118689: [MLIR][PDL] Execute nondeterministic bytecode & lower some PDLInterp ops: Restricted Project.

As a side note: is there going to be one more diff stacked on top of this one that implements the lowering of commutative pdl.operations?

Mar 2 2022, 11:05 AM · Restricted Project, Restricted Project
srishti-pm added inline comments to D118684: [MLIR][PDLInterp] Define new ops in PDLInterp to support commutativity.
Mar 2 2022, 11:00 AM · Restricted Project, Restricted Project
Herald added a project to D118684: [MLIR][PDLInterp] Define new ops in PDLInterp to support commutativity: Restricted Project.

Can you add lit tests for these new ops?

Mar 2 2022, 10:50 AM · Restricted Project, Restricted Project
Herald added a project to D118683: [MLIR][PDL] Add optional attribute to enable commutativity in PDL: Restricted Project.
Mar 2 2022, 10:47 AM · Restricted Project, Restricted Project

Feb 1 2022

srishti-pm requested review of D118689: [MLIR][PDL] Execute nondeterministic bytecode & lower some PDLInterp ops.
Feb 1 2022, 3:05 AM · Restricted Project, Restricted Project
srishti-pm updated the diff for D118684: [MLIR][PDLInterp] Define new ops in PDLInterp to support commutativity.

Correct a typo in the commit summary.

Feb 1 2022, 3:03 AM · Restricted Project, Restricted Project
srishti-pm requested review of D118684: [MLIR][PDLInterp] Define new ops in PDLInterp to support commutativity.
Feb 1 2022, 1:58 AM · Restricted Project, Restricted Project
srishti-pm requested review of D118683: [MLIR][PDL] Add optional attribute to enable commutativity in PDL.
Feb 1 2022, 1:45 AM · Restricted Project, Restricted Project

Jul 12 2021

srishti-pm added a comment to D105418: [MLIR] Simplify affine.if having yield values and trivial conditions.

Hi, actually I want my username in Phabricator to be srishti-pml.

I said you to create new account.

New accounts have the disadvantage of losing the history of the account. Also if you're using GitHub login, you can't just have a new account (I think?).

So, when I tried changing my Phabricator username, I found out that I don't have the required permissions.

Now, my Phabricator account is associated with my GitHub account, in which my username was SrishtiSrivastavaPolymage before. So, I changed my GitHub username to srishti-pml, hoping that it would change by Phabricator username. But my Phabricator username didn't change. That is why I am requesting @mehdi_amini to kindly change my Phabricator username to srishti-pml.

I have no problem. But actually I think _volunteer_ phabricator administrator are not responsible for changing usernames of 20000+ llvm phab usrers or do they?
It is usually difficult to entertain such request :)

It takes ~10s to do, and it is really not common (it happened a handful of times per year so far).

Jul 12 2021, 11:17 AM · Restricted Project
mehdi_amini renamed srishti-pm from SrishtiSrivastavaPolyMage to srishti-pm.
Jul 12 2021, 11:06 AM
srishti-pm added a comment to D105418: [MLIR] Simplify affine.if having yield values and trivial conditions.
In D105418#2861432, @SrishtiSrivastavaPolyMage wrote:

@mehdi_amini, could you kindly change my Phabricator username to "srishti-pml", which is also my GitHub username attached to this account now. I am unable to do it myself because when I try, a pop-up comes and it says "Only administrators can change usernames".

You should simply create a new account with your @polymagelabs.com email address and get a new username srishti-pml otherwise simply change your GitHub username to SrishtiSrivastavPolyMage if you only want consistency.

Jul 12 2021, 5:43 AM · Restricted Project

Jul 7 2021

srishti-pm added a comment to D105418: [MLIR] Simplify affine.if having yield values and trivial conditions.

@mehdi_amini, could you kindly change my Phabricator username to "srishti-pml", which is also my GitHub username attached to this account now. I am unable to do it myself because when I try, a pop-up comes and it says "Only administrators can change usernames".

Jul 7 2021, 1:57 AM · Restricted Project

Jul 6 2021

srishti-pm added a comment to D105418: [MLIR] Simplify affine.if having yield values and trivial conditions.

Address comments

Jul 6 2021, 12:35 AM · Restricted Project

Jul 5 2021

srishti-pm updated the diff for D105418: [MLIR] Simplify affine.if having yield values and trivial conditions.

Modified test cases

Jul 5 2021, 9:52 PM · Restricted Project
srishti-pm updated the diff for D105418: [MLIR] Simplify affine.if having yield values and trivial conditions.

[MLIR] Simplify affine.if having yield values and trivial conditions

Jul 5 2021, 7:16 AM · Restricted Project

Jul 4 2021

srishti-pm requested review of D105418: [MLIR] Simplify affine.if having yield values and trivial conditions.
Jul 4 2021, 11:19 PM · Restricted Project