Page MenuHomePhabricator

speryt (Sebastian Peryt)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 21 2022, 10:31 AM (57 w, 6 d)

Compiler engineer at Intel

Recent Activity

Feb 8 2023

speryt added inline comments to D136163: Port PlaceSafepoints pass to the new pass manager.
Feb 8 2023, 11:46 AM · Restricted Project, Restricted Project

Jan 10 2023

speryt added a comment to D137103: [LegacyPM] Port example pass SimplifyCFG to new PM.

@aeubanks I believe this is ready for review/merge. Can you please look into this?
Personally I don't see any obvious things that might require immediate work from my end.

Jan 10 2023, 9:12 AM · Restricted Project, Restricted Project

Dec 23 2022

speryt updated the diff for D137103: [LegacyPM] Port example pass SimplifyCFG to new PM.

also this current patch doesn't apply cleanly on main

Dec 23 2022, 5:28 AM · Restricted Project, Restricted Project
speryt added a comment to D137103: [LegacyPM] Port example pass SimplifyCFG to new PM.

can you provide the configuration you're using and the list of test failures? I'm not seeing any test failures aside from two pass manager pipeline failures with -DLLVM_EXAMPLEIRTRANSFORMS_LINK_INTO_TOOLS=ON which don't really matter

Dec 23 2022, 4:41 AM · Restricted Project, Restricted Project

Dec 20 2022

speryt updated the diff for D137103: [LegacyPM] Port example pass SimplifyCFG to new PM.

Sorry, completely forgot about this diff. Got distracted with other tasks.
I spent some time to figure out why it is not passing on my end and still 5 tests are failing, but frankly speaking - no clue. My best guess is that I might have missed some option in building, or some configuration with my machine is just causing those failures.

Dec 20 2022, 5:02 AM · Restricted Project, Restricted Project

Dec 8 2022

speryt added a comment to D137103: [LegacyPM] Port example pass SimplifyCFG to new PM.

Sorry, work has been postponed on this task, due to some other more important issues.
I'm planning to have some updates to this diff by end of this week.

Dec 8 2022, 10:23 AM · Restricted Project, Restricted Project

Nov 18 2022

speryt updated the diff for D137103: [LegacyPM] Port example pass SimplifyCFG to new PM.

I still need to do some more debugging because with current patch following tests started to fail:

Nov 18 2022, 6:08 PM · Restricted Project, Restricted Project

Nov 14 2022

speryt added a comment to D137103: [LegacyPM] Port example pass SimplifyCFG to new PM.

Thanks @aeubanks for review. I should provide update this week.

Nov 14 2022, 6:03 PM · Restricted Project, Restricted Project

Nov 3 2022

speryt updated the diff for D137103: [LegacyPM] Port example pass SimplifyCFG to new PM.

Addressed (hopefully) all review comments.
I tried to understand how the naming schemas should work for registering new pass plugin, but there is a chance I might have missed something or misunderstood.
Bottom-line question is, what should I change, so I can call this pass with flags -tut-simplifycfg -tut-simplifycfg-version=XX?

Nov 3 2022, 3:48 PM · Restricted Project, Restricted Project

Oct 31 2022

speryt added a comment to D137103: [LegacyPM] Port example pass SimplifyCFG to new PM.

This is currently WIP patch, because I have some issues in understanding how exactly the porting should happen. I've been following @aeubanks recommendation from discourse, but two main things that I found unclear so far are:

Oct 31 2022, 12:48 PM · Restricted Project, Restricted Project
speryt requested review of D137103: [LegacyPM] Port example pass SimplifyCFG to new PM.
Oct 31 2022, 12:35 PM · Restricted Project, Restricted Project

Oct 10 2022

speryt updated the diff for D135497: [NFC][3/n] Remove enable-new-pm from Inline tests.

Sorry, I didn't realize that update means completely new diff rather than merging with previous changes. This is merge of my 2 previous patches.

Oct 10 2022, 12:34 PM · Restricted Project, Restricted Project
speryt updated the diff for D135497: [NFC][3/n] Remove enable-new-pm from Inline tests.

Removed tests that can be safely removed based on previous comments.

Oct 10 2022, 12:29 PM · Restricted Project, Restricted Project

Oct 7 2022

speryt added a reviewer for D135497: [NFC][3/n] Remove enable-new-pm from Inline tests: aeubanks.
Oct 7 2022, 4:33 PM · Restricted Project, Restricted Project
speryt added a comment to D135497: [NFC][3/n] Remove enable-new-pm from Inline tests.

There are still few tests left with which I'm not sure what resolution would be the best. Any comments are highly appreciated.

Oct 7 2022, 4:32 PM · Restricted Project, Restricted Project
speryt requested review of D135497: [NFC][3/n] Remove enable-new-pm from Inline tests.
Oct 7 2022, 4:16 PM · Restricted Project, Restricted Project

Sep 26 2022

speryt added inline comments to D134686: [NFC][2/n] Remove PrunePH pass.
Sep 26 2022, 5:37 PM · Restricted Project, Restricted Project
speryt requested review of D134686: [NFC][2/n] Remove PrunePH pass.
Sep 26 2022, 5:36 PM · Restricted Project, Restricted Project

Sep 19 2022

speryt added a comment to D134150: [NFC][1/n] Remove -enable-new-pm=0 flags from lit tests.

lg, thanks!
I can push for you if you don't have permissions

Sep 19 2022, 9:23 AM · Restricted Project, Restricted Project

Sep 18 2022

speryt requested review of D134150: [NFC][1/n] Remove -enable-new-pm=0 flags from lit tests.
Sep 18 2022, 4:23 PM · Restricted Project, Restricted Project

May 19 2022

speryt added a comment to D125581: [DOC] Improve LangRef description of declare.

@RKSimon could you please merge this diff? I don't have required permissions to do so. Thanks!

May 19 2022, 3:15 PM · Restricted Project, Restricted Project
speryt added a comment to D125831: [DOC] Refactor Functions section in LangRef.

@RKSimon could you please merge this diff? I don't have required permissions to do so. Thanks!

May 19 2022, 3:15 PM · Restricted Project, Restricted Project

May 17 2022

speryt added a comment to D125581: [DOC] Improve LangRef description of declare.

Refactor of Functions added in D125831.

May 17 2022, 12:41 PM · Restricted Project, Restricted Project
speryt requested review of D125831: [DOC] Refactor Functions section in LangRef.
May 17 2022, 12:39 PM · Restricted Project, Restricted Project
speryt updated the diff for D125581: [DOC] Improve LangRef description of declare.

Following @RKSimon suggestion I've split diff on two separate diffs.

May 17 2022, 12:30 PM · Restricted Project, Restricted Project

May 13 2022

speryt requested review of D125581: [DOC] Improve LangRef description of declare.
May 13 2022, 1:20 PM · Restricted Project, Restricted Project
speryt updated speryt.
May 13 2022, 12:45 PM