Page MenuHomePhabricator

sorenj (Jeffrey Sorensen)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 16 2019, 6:10 PM (103 w, 2 d)

Recent Activity

Jan 29 2020

sorenj added a comment to D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals..

My colleague pointed out that -Wsigned-conversion will not detect this very frequent mistake

Jan 29 2020, 2:35 PM · Restricted Project, Restricted Project

Jan 20 2020

sorenj added a comment to D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals..

So, I ran this check against the cxx directory of llvm, it fired 5 times so let's look at the context and disucss:

Jan 20 2020, 3:03 AM · Restricted Project, Restricted Project

Jan 18 2020

sorenj added a comment to D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals..

Okay, but as you can see the majority of my test cases are intentionally false negatives - -Wsign-conversion triggers so often than many people don't use it. And, unsigned x = 2; does not trigger a sign conversion warning despite there being a conversion form 2 to 2u. This check is targeting a very specific but frequent case of functions that do not guard against containers that might be empty.

Jan 18 2020, 6:35 AM · Restricted Project, Restricted Project

Jan 14 2020

sorenj added a comment to D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals..

Anything further needed?

Jan 14 2020, 4:20 AM · Restricted Project, Restricted Project

Jan 10 2020

sorenj updated the diff for D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals..
  • Remove double space.
Jan 10 2020, 6:40 PM · Restricted Project, Restricted Project
sorenj updated the diff for D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals..
  • Address documentation comments.
  • Address documentation comments.
Jan 10 2020, 5:54 PM · Restricted Project, Restricted Project
sorenj added a comment to D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals..

First time so trying to follow similar recent submits. PTAL.

Jan 10 2020, 3:02 PM · Restricted Project, Restricted Project
sorenj updated the diff for D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals..
Jan 10 2020, 2:54 PM · Restricted Project, Restricted Project
sorenj added a comment to D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals..

Friendly ping - anything further I need to do here?

Jan 10 2020, 1:57 PM · Restricted Project, Restricted Project

Dec 17 2019

sorenj added inline comments to D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals..
Dec 17 2019, 10:15 AM · Restricted Project, Restricted Project
sorenj updated the diff for D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals..

Address requested whitespace changes.

Dec 17 2019, 7:02 AM · Restricted Project, Restricted Project
sorenj created D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals..
Dec 17 2019, 6:42 AM · Restricted Project, Restricted Project