Page MenuHomePhabricator

smhc (Shane)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 27 2020, 3:37 AM (63 w, 6 d)

Recent Activity

Nov 25 2020

smhc added inline comments to D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.
Nov 25 2020, 1:23 AM · Restricted Project, Restricted Project

Nov 24 2020

smhc added a comment to D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

There's a build failure from this merge, looks like a typo:

Nov 24 2020, 6:06 PM · Restricted Project, Restricted Project

Nov 23 2020

smhc added a comment to D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check.

Yes all looks good, thanks!

Nov 23 2020, 3:16 PM · Restricted Project, Restricted Project
smhc added a comment to D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Yes I thought the same wrt the doco. There is also a hungarian notation config option in the works which does the same thing.

Nov 23 2020, 12:59 PM · Restricted Project, Restricted Project
smhc updated the diff for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Removed unnecessary str()

Nov 23 2020, 12:54 PM · Restricted Project, Restricted Project
smhc added a comment to D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Thanks for the reviews everyone, I have updated the title and summary.
Unfortunately I don't have push access to llvm - could someone help to push this please?

Nov 23 2020, 12:16 PM · Restricted Project, Restricted Project
smhc updated the diff for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Fixed uk/us spelling difference as suggested

Nov 23 2020, 12:07 PM · Restricted Project, Restricted Project
smhc retitled D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks from [clang-tidy] Add IgnoreShortNames config to identifier naming checks to [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.
Nov 23 2020, 12:06 PM · Restricted Project, Restricted Project

Nov 22 2020

smhc added inline comments to D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.
Nov 22 2020, 3:03 PM · Restricted Project, Restricted Project
smhc updated the diff for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Updated after review comments.

Nov 22 2020, 3:01 PM · Restricted Project, Restricted Project
smhc added a comment to D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check.

Thank you - I don't have commit access so am unable to merge it myself. The clang-tidy tests are passing fine.

Nov 22 2020, 12:42 PM · Restricted Project, Restricted Project

Nov 21 2020

smhc updated the diff for D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check.

Thanks - I had it like that originally but was not sure how often MacroUsageCallbacks would be instantiated or whether there was a many-to-one relationship. I've now modified it to create and maintain the regex object as a member of MacroUsageCallbacks.

Nov 21 2020, 12:26 PM · Restricted Project, Restricted Project
smhc requested review of D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check.
Nov 21 2020, 1:16 AM · Restricted Project, Restricted Project

Nov 20 2020

smhc updated the diff for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Updated after review comments.

Nov 20 2020, 6:15 PM · Restricted Project, Restricted Project
smhc updated the diff for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

removed notes on short length threshold

Nov 20 2020, 7:26 AM · Restricted Project, Restricted Project
smhc updated the diff for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Updated diff to use 'IgnoredRegexp'
I see that a regexp has been used elsewhere for some other checks (macro usage, AllowedRegexp).

Nov 20 2020, 7:21 AM · Restricted Project, Restricted Project

Nov 19 2020

smhc added a comment to D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Regexes may be a bit of a slippery slope as any identifier scheme could be represented as a regex (casing, prefix, suffix etc) but it's not practical to provide a fix or suggestion with a regex.
For example with a 'ShortThreshold' a fix could offer to change the casing/xffix or to trim the variable length. With a regex it's less about making a naming rule and more about providing a workaround for problematic edge cases. As such should be used sparingly.

Nov 19 2020, 8:13 PM · Restricted Project, Restricted Project

Nov 15 2020

smhc updated the diff for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Re-based to llvm master and re-diffed.

Nov 15 2020, 4:02 PM · Restricted Project, Restricted Project

Nov 14 2020

smhc added a comment to D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

I updated it to use XXShortSizeThreshold.

Nov 14 2020, 9:13 PM · Restricted Project, Restricted Project
smhc updated the diff for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.
Nov 14 2020, 9:02 PM · Restricted Project, Restricted Project

Nov 12 2020

smhc added a comment to D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Should this be a NamingStyle option instead.
{key: readability-identifier-naming.ParameterShortSizeThreshold, value: 2}
WDYT?

I think that makes a lot of sense -- I can imagine wanting to enforce different identifier lengths depending on whether we're spelling a type name vs a local variable name, etc.

Nov 12 2020, 10:15 PM · Restricted Project, Restricted Project
smhc set the repository for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks to rG LLVM Github Monorepo.
Nov 12 2020, 3:30 AM · Restricted Project, Restricted Project

Nov 5 2020

smhc updated the diff for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

I've updated the release notes and corrected the unit tests to be passing. Thanks again.

Nov 5 2020, 6:44 PM · Restricted Project, Restricted Project
smhc updated the diff for D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.

Thanks for the review! Agreed with suggestions, submitted updated diff.
Please note I do not have commit access to llvm. Regards.

Nov 5 2020, 3:36 AM · Restricted Project, Restricted Project

Nov 4 2020

smhc retitled D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks from Add IgnoreShortNames config to identifier naming checks to [clang-tidy] Add IgnoreShortNames config to identifier naming checks.
Nov 4 2020, 6:38 PM · Restricted Project, Restricted Project

Oct 27 2020

smhc requested review of D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks.
Oct 27 2020, 7:31 PM · Restricted Project, Restricted Project