Page MenuHomePhabricator

slingn (Nathan Slingerland)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 10 2015, 9:55 AM (188 w, 6 d)

Recent Activity

Jan 29 2016

slingn added a comment to D16727: [Profiling] Write out sparse indexed profiles.

If there is to be a new option for llvm-profdata then the *.rst documentation file needs to be updated too:
llvm/docs/CommandGuide/llvm-profdata.rst

Jan 29 2016, 9:20 AM
slingn added a comment to D16727: [Profiling] Write out sparse indexed profiles.

Making sparse the default would change the output of llvm-profdata show since zero count functions would no longer be listed. Is that a concern? In other words, could existing users of llvm-profdata be relying on it in any way?

Jan 29 2016, 9:19 AM

Jan 12 2016

slingn committed rL257532: [Support] Add saturating multiply-add support function.
[Support] Add saturating multiply-add support function
Jan 12 2016, 2:38 PM
slingn closed D15385: [Support] Add saturating multiply-add support function by committing rL257532: [Support] Add saturating multiply-add support function.
Jan 12 2016, 2:37 PM
slingn updated the diff for D15385: [Support] Add saturating multiply-add support function.

Update patch to apply cleanly to HEAD.

Jan 12 2016, 1:42 PM

Jan 6 2016

slingn committed rL256947: [compiler-rt] Fix empty translation unit warning.
[compiler-rt] Fix empty translation unit warning
Jan 6 2016, 8:58 AM

Jan 5 2016

slingn committed rL256855: [PGO] Enable clang to pass compiler-rt profile support library to linker on….
[PGO] Enable clang to pass compiler-rt profile support library to linker on…
Jan 5 2016, 10:30 AM
slingn closed D15833: [PGO] Enable clang to pass compiler-rt profile support library to linker on Windows by committing rL256855: [PGO] Enable clang to pass compiler-rt profile support library to linker on….
Jan 5 2016, 10:30 AM
slingn committed rL256848: [PGO] Enable building compiler-rt profile support library on Windows.
[PGO] Enable building compiler-rt profile support library on Windows
Jan 5 2016, 9:30 AM
slingn closed D15830: [PGO] Enable building compiler-rt profile support library on Windows by committing rL256848: [PGO] Enable building compiler-rt profile support library on Windows.
Jan 5 2016, 9:30 AM
slingn updated subscribers of D15833: [PGO] Enable clang to pass compiler-rt profile support library to linker on Windows.
Jan 5 2016, 9:27 AM
slingn updated the diff for D15833: [PGO] Enable clang to pass compiler-rt profile support library to linker on Windows.

-Fixed to accept any linker with name ending in 'link(.exe)?'

Jan 5 2016, 9:20 AM

Jan 4 2016

slingn added inline comments to D15833: [PGO] Enable clang to pass compiler-rt profile support library to linker on Windows.
Jan 4 2016, 5:00 PM
slingn updated the diff for D15833: [PGO] Enable clang to pass compiler-rt profile support library to linker on Windows.

-Fix instrprof-ld.c test to correctly skip to linker input.

Jan 4 2016, 5:00 PM
slingn updated the diff for D15830: [PGO] Enable building compiler-rt profile support library on Windows.

-Fixed guard of WindowsMMap.c

Jan 4 2016, 4:37 PM
slingn updated the diff for D15830: [PGO] Enable building compiler-rt profile support library on Windows.

Fix header comment.

Jan 4 2016, 3:17 PM
slingn updated the diff for D15833: [PGO] Enable clang to pass compiler-rt profile support library to linker on Windows.

Updated for davidxl's comments:

Jan 4 2016, 3:16 PM
slingn updated the diff for D15830: [PGO] Enable building compiler-rt profile support library on Windows.

Updated for davidxl's comments

Jan 4 2016, 3:14 PM
slingn updated subscribers of D15829: [PGO] Clang Option that enables IR level PGO instrumentation .
Jan 4 2016, 9:15 AM
slingn added inline comments to D15828: [PGO] Passmanagerbuilder change that enable IR level PGO instrumentation.
Jan 4 2016, 9:14 AM

Dec 30 2015

slingn added a comment to D15830: [PGO] Enable building compiler-rt profile support library on Windows.

mmap-windows.c gets #included directly in GCDAProfiling.c since the compatibility mmap()/msync()/flock() functions are not used anywhere else (they are static).

Dec 30 2015, 3:37 PM
slingn updated the diff for D15830: [PGO] Enable building compiler-rt profile support library on Windows.

Fix C++ -> C style comments in mmap-windows.c compatibility file.

Dec 30 2015, 3:15 PM
slingn added inline comments to D15830: [PGO] Enable building compiler-rt profile support library on Windows.
Dec 30 2015, 3:08 PM
slingn added a parent revision for D15833: [PGO] Enable clang to pass compiler-rt profile support library to linker on Windows: D15830: [PGO] Enable building compiler-rt profile support library on Windows.
Dec 30 2015, 2:17 PM
slingn added a child revision for D15830: [PGO] Enable building compiler-rt profile support library on Windows: D15833: [PGO] Enable clang to pass compiler-rt profile support library to linker on Windows.
Dec 30 2015, 2:17 PM
slingn retitled D15833: [PGO] Enable clang to pass compiler-rt profile support library to linker on Windows from to [PGO] Enable clang to pass compiler-rt profile support library to linker on Windows.
Dec 30 2015, 2:17 PM
slingn updated the diff for D15830: [PGO] Enable building compiler-rt profile support library on Windows.

Updated commit message.

Dec 30 2015, 1:58 PM
slingn retitled D15830: [PGO] Enable building compiler-rt profile support library on Windows from [PGO] Enable instrprof on Windows to [PGO] Enable building compiler-rt profile support library on Windows.
Dec 30 2015, 1:57 PM
slingn retitled D15830: [PGO] Enable building compiler-rt profile support library on Windows from to [PGO] Enable instrprof on Windows.
Dec 30 2015, 1:54 PM

Dec 21 2015

slingn added inline comments to D15540: [PGO] differentiate FE instrumentation and IR level instrumentation profiles.
Dec 21 2015, 11:59 AM
slingn updated subscribers of D15540: [PGO] differentiate FE instrumentation and IR level instrumentation profiles.
Dec 21 2015, 11:31 AM

Dec 16 2015

slingn updated the diff for D15385: [Support] Add saturating multiply-add support function.

Updated for silvas comments.
-Apply SaturatingMultplyAdd() to weighted PGO merging.

Dec 16 2015, 2:22 PM
slingn committed rL255825: [PGO] Handle and report overflow during profile merge for all types of data.
[PGO] Handle and report overflow during profile merge for all types of data
Dec 16 2015, 1:49 PM
slingn closed D15547: [PGO] Handle and report overflow during profile merge for all types of data by committing rL255825: [PGO] Handle and report overflow during profile merge for all types of data.
Dec 16 2015, 1:49 PM
slingn updated the diff for D15547: [PGO] Handle and report overflow during profile merge for all types of data.

Updated for davidxl feedback.

Dec 16 2015, 11:29 AM
slingn added inline comments to D15547: [PGO] Handle and report overflow during profile merge for all types of data.
Dec 16 2015, 11:17 AM
slingn added inline comments to D15547: [PGO] Handle and report overflow during profile merge for all types of data.
Dec 16 2015, 10:45 AM
slingn added inline comments to D15547: [PGO] Handle and report overflow during profile merge for all types of data.
Dec 16 2015, 10:31 AM
slingn updated the diff for D15547: [PGO] Handle and report overflow during profile merge for all types of data.

Updated for davidxl, dnovillo feedback.

Dec 16 2015, 10:31 AM

Dec 15 2015

slingn retitled D15547: [PGO] Handle and report overflow during profile merge for all types of data from to [PGO] Handle and report overflow during profile merge for all types of data.
Dec 15 2015, 4:22 PM
slingn committed rL255659: [llvm-profdata] Add support for weighted merge of profile data (2nd try).
[llvm-profdata] Add support for weighted merge of profile data (2nd try)
Dec 15 2015, 9:40 AM
slingn closed D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try) by committing rL255659: [llvm-profdata] Add support for weighted merge of profile data (2nd try).
Dec 15 2015, 9:40 AM

Dec 14 2015

slingn updated the diff for D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try).

Updated for dnovillo feedback.

Dec 14 2015, 2:40 PM
slingn updated D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try).
Dec 14 2015, 12:12 PM
slingn updated the diff for D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try).

Updated for silvas feedback.

Dec 14 2015, 12:12 PM

Dec 11 2015

slingn updated the diff for D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try).

Updated for silvas comments.

Dec 11 2015, 2:19 PM

Dec 10 2015

slingn added a comment to D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try).

OK - that makes sense to me if automated merging is expected to be the most common workflow.

Dec 10 2015, 3:54 PM
slingn added a comment to D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try).

There's one --weighted-file=<weight>,<filename> per file to merge, right?

Dec 10 2015, 3:38 PM
slingn added a comment to D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try).

Adding a few others for review since this has expanded beyond 'fix the Windows test issue' for the reverted D14547.

Dec 10 2015, 3:19 PM
slingn added reviewers for D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try): dnovillo, bogner.
Dec 10 2015, 3:18 PM
slingn added a comment to D15385: [Support] Add saturating multiply-add support function.

it is probably just slightly more efficient so probably not in this patch.

If we are looking to improve efficiency, the clearest improvement to make is to use __builtin_*_with_overflow which will dramatically reduce the cost since we can directly use the processor flags instead of using some explicit calculation.

Dec 10 2015, 10:28 AM
slingn added inline comments to D15385: [Support] Add saturating multiply-add support function.
Dec 10 2015, 10:17 AM
slingn added a comment to D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try).

From the end user's perspective the <filename>:<weight> syntax seems the most intuitive and concise. And no matter what delimiter we choose (even with a separate option) there will still be edge cases for us to differentiate between file names containing ',' and the user trying but failing to specify a weight.

Dec 10 2015, 9:39 AM
slingn committed rL255264: [ProfileData] Add unit test infrastructure for sample profile reader/writer.
[ProfileData] Add unit test infrastructure for sample profile reader/writer
Dec 10 2015, 9:24 AM
slingn closed D15211: [ProfileData] Add unit test infrastructure for sample profile reader/writer by committing rL255264: [ProfileData] Add unit test infrastructure for sample profile reader/writer.
Dec 10 2015, 9:24 AM

Dec 9 2015

slingn updated the diff for D15211: [ProfileData] Add unit test infrastructure for sample profile reader/writer.

Updated for davidxl's comments.

Dec 9 2015, 4:56 PM
slingn added inline comments to D15211: [ProfileData] Add unit test infrastructure for sample profile reader/writer.
Dec 9 2015, 4:44 PM
slingn retitled D15385: [Support] Add saturating multiply-add support function from to [Support] Add saturating multiply-add support function.
Dec 9 2015, 10:51 AM
slingn committed rL255128: [Support] Change SaturatingAdd()/SaturatingMultiply() to use pointer for….
[Support] Change SaturatingAdd()/SaturatingMultiply() to use pointer for…
Dec 9 2015, 9:14 AM
slingn closed D15219: [Support] Change SaturatingAdd()/SaturatingMultiply() to use pointer for returning overflow state by committing rL255128: [Support] Change SaturatingAdd()/SaturatingMultiply() to use pointer for….
Dec 9 2015, 9:14 AM

Dec 8 2015

slingn added inline comments to D15211: [ProfileData] Add unit test infrastructure for sample profile reader/writer.
Dec 8 2015, 2:29 PM
slingn updated the diff for D15211: [ProfileData] Add unit test infrastructure for sample profile reader/writer.

Updated for davidxl and silvas comments.

Dec 8 2015, 2:29 PM
slingn updated the diff for D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try).

Updated for davidxl and bogner's comments.

Dec 8 2015, 1:14 PM

Dec 7 2015

slingn added a comment to D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try).

I still think a check is a good idea for the edge case mentioned above (input contains ':' but is not specifying a weight and does not exist) so that the error message is correct. But thankfully I think since sys::fs::exists() works we can just check if the split path exists - if it doesn't fall back to default behavior. Hopefully that's a more appealing way to do this.

Dec 7 2015, 5:30 PM
slingn added a comment to D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try).

OK, so it's not a bug in sys::fs::exists(). It's a bug in the test script text-format-errors.text:

Dec 7 2015, 5:27 PM
slingn added inline comments to D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try).
Dec 7 2015, 4:00 PM
slingn updated the diff for D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try).

Updated for davidxl's comments.

Dec 7 2015, 3:57 PM
slingn added a comment to D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try).

BTW - I was able to reproduce the failure and verify the fix on Windows 7 / Visual Studio 2013.

Dec 7 2015, 2:51 PM
slingn added a comment to D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try).

Failed builds:

Dec 7 2015, 2:51 PM
slingn updated the diff for D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try).

Fix for Windows test failure.

Dec 7 2015, 2:15 PM
slingn added a comment to D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try).

Diff 1 is the baseline change from D14547. The fix for the Windows test failure isn't quite 'trivial' so I'm going to make that Diff 2.

Dec 7 2015, 2:14 PM
slingn retitled D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try) from to [llvm-profdata] Add support for weighted merge of profile data (2nd try).
Dec 7 2015, 2:13 PM

Dec 3 2015

slingn committed rL254687: Revert "[llvm-profdata] Add support for weighted merge of profile data".
Revert "[llvm-profdata] Add support for weighted merge of profile data"
Dec 3 2015, 6:17 PM
slingn retitled D15219: [Support] Change SaturatingAdd()/SaturatingMultiply() to use pointer for returning overflow state from to [Support] Change SaturatingAdd()/SaturatingMultiply() to use pointer for returning overflow state.
Dec 3 2015, 4:48 PM
slingn committed rL254669: [llvm-profdata] Add support for weighted merge of profile data.
[llvm-profdata] Add support for weighted merge of profile data
Dec 3 2015, 4:03 PM
slingn closed D14547: [llvm-profdata] Add support for weighted merge of profile data by committing rL254669: [llvm-profdata] Add support for weighted merge of profile data.
Dec 3 2015, 4:03 PM
slingn added inline comments to D14547: [llvm-profdata] Add support for weighted merge of profile data.
Dec 3 2015, 3:16 PM
slingn retitled D15211: [ProfileData] Add unit test infrastructure for sample profile reader/writer from to [ProfileData] Add unit test infrastructure for sample profile reader/writer.
Dec 3 2015, 2:57 PM

Dec 2 2015

slingn updated the diff for D14547: [llvm-profdata] Add support for weighted merge of profile data.

Updated for silvas feedback.

Dec 2 2015, 3:30 PM
slingn added a comment to D14547: [llvm-profdata] Add support for weighted merge of profile data.
Dec 2 2015, 2:39 PM
slingn updated the diff for D14547: [llvm-profdata] Add support for weighted merge of profile data.

Updated for davidxl and silvas feedback.

Dec 2 2015, 2:36 PM
slingn committed rL254525: [llvm-profdata] Change instr prof counter overflow to saturate rather than….
[llvm-profdata] Change instr prof counter overflow to saturate rather than…
Dec 2 2015, 10:22 AM
slingn closed D14893: [llvm-profdata] Change instr prof counter overflow to saturate rather than discard by committing rL254525: [llvm-profdata] Change instr prof counter overflow to saturate rather than….
Dec 2 2015, 10:22 AM
slingn added inline comments to D14893: [llvm-profdata] Change instr prof counter overflow to saturate rather than discard.
Dec 2 2015, 9:48 AM
slingn updated the diff for D14893: [llvm-profdata] Change instr prof counter overflow to saturate rather than discard.

Updated for davidxl's comments.

Dec 2 2015, 9:48 AM

Nov 23 2015

slingn updated the diff for D14893: [llvm-profdata] Change instr prof counter overflow to saturate rather than discard.

Updated to use new version of SaturatingAdd() that sets if result overflow.

Nov 23 2015, 2:17 PM
slingn committed rL253921: [Support] Add optional argument to SaturatingAdd() and SaturatingMultiply()….
[Support] Add optional argument to SaturatingAdd() and SaturatingMultiply()…
Nov 23 2015, 1:57 PM
slingn closed D14931: [Support] Add optional argument to SaturatingAdd() and SaturatingMultiply() to indicate that overflow occurred by committing rL253921: [Support] Add optional argument to SaturatingAdd() and SaturatingMultiply()….
Nov 23 2015, 1:57 PM
slingn updated the diff for D14931: [Support] Add optional argument to SaturatingAdd() and SaturatingMultiply() to indicate that overflow occurred.

Updated for davidxl's comments.

Nov 23 2015, 1:24 PM
slingn updated subscribers of D14894: [PGO] Add --text-format option for llvm-profdata show|merge commands.
Nov 23 2015, 1:04 PM
slingn retitled D14931: [Support] Add optional argument to SaturatingAdd() and SaturatingMultiply() to indicate that overflow occurred from to [Support] Add optional argument to SaturatingAdd() and SaturatingMultiply() to indicate that overflow occurred.
Nov 23 2015, 11:24 AM
slingn added inline comments to D14893: [llvm-profdata] Change instr prof counter overflow to saturate rather than discard.
Nov 23 2015, 9:52 AM
slingn updated the diff for D14893: [llvm-profdata] Change instr prof counter overflow to saturate rather than discard.

Updated for davidxl's comment.

Nov 23 2015, 9:51 AM
slingn added a comment to D14893: [llvm-profdata] Change instr prof counter overflow to saturate rather than discard.
Nov 23 2015, 9:01 AM
slingn updated the diff for D14893: [llvm-profdata] Change instr prof counter overflow to saturate rather than discard.

Updated for davidxl and silvas comments.

Nov 23 2015, 9:01 AM
slingn committed rL253870: [Support] Fix SaturatingMultiply<T>() to be correct (and fast), Re-enable….
[Support] Fix SaturatingMultiply<T>() to be correct (and fast), Re-enable…
Nov 23 2015, 7:36 AM
slingn closed D14845: [Support] Fix SaturatingMultiply<T>() to be correct (and fast), Re-enable Unit Tests by committing rL253870: [Support] Fix SaturatingMultiply<T>() to be correct (and fast), Re-enable….
Nov 23 2015, 7:36 AM

Nov 20 2015

slingn retitled D14893: [llvm-profdata] Change instr prof counter overflow to saturate rather than discard from to [llvm-profdata] Change instr prof counter overflow to saturate rather than discard.
Nov 20 2015, 3:54 PM
slingn added a comment to D14845: [Support] Fix SaturatingMultiply<T>() to be correct (and fast), Re-enable Unit Tests.
Nov 20 2015, 1:16 PM
slingn updated the diff for D14845: [Support] Fix SaturatingMultiply<T>() to be correct (and fast), Re-enable Unit Tests.

Added unit tests based on rsmith's suggestions.

Nov 20 2015, 1:15 PM