Page MenuHomePhabricator

slarin (Sergei Larin)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 2 2015, 8:43 AM (211 w, 3 d)

Recent Activity

Mar 8 2016

slarin added inline comments to D17066: libLTO: add a ThinLTOCodeGenerator on the model of LTOCodeGenerator..
Mar 8 2016, 12:09 PM
slarin added a comment to D17066: libLTO: add a ThinLTOCodeGenerator on the model of LTOCodeGenerator..

Sorry for the late entry... Some of my questions could have been already answered.

Mar 8 2016, 11:06 AM

Feb 23 2016

slarin added a comment to D17338: [SplitModule] Do not copy stale debug info during module splitting..

Guys, can you please take a quick look...?

Feb 23 2016, 9:18 AM

Feb 17 2016

slarin added reviewers for D17338: [SplitModule] Do not copy stale debug info during module splitting.: joker-eph-DISABLED, pcc.
Feb 17 2016, 9:30 AM
slarin retitled D17338: [SplitModule] Do not copy stale debug info during module splitting. from to [SplitModule] Do not copy stale debug info during module splitting..
Feb 17 2016, 9:27 AM

Jan 28 2016

slarin committed rL259075: [SplitModule] In split module utility we should never separate alias with its….
[SplitModule] In split module utility we should never separate alias with its…
Jan 28 2016, 11:03 AM
slarin closed D16585: In split module utility we should never separate alias with its aliasee. by committing rL259075: [SplitModule] In split module utility we should never separate alias with its….
Jan 28 2016, 11:03 AM
slarin updated the diff for D16585: In split module utility we should never separate alias with its aliasee..

Updated test.

Jan 28 2016, 10:58 AM

Jan 27 2016

slarin added a comment to D16585: In split module utility we should never separate alias with its aliasee..

Can this be landed now...?

Jan 27 2016, 12:40 PM

Jan 26 2016

slarin updated the diff for D16585: In split module utility we should never separate alias with its aliasee..

Make sure all kind of alisees are handled + test.

Jan 26 2016, 2:06 PM
slarin updated the diff for D16585: In split module utility we should never separate alias with its aliasee..

Implement Peters comments.

Jan 26 2016, 12:27 PM
slarin added a comment to D16585: In split module utility we should never separate alias with its aliasee..

Thanks Mehdi. I will let some time for Peter to comment if he pleases...

Jan 26 2016, 8:37 AM
slarin updated subscribers of D16585: In split module utility we should never separate alias with its aliasee..
Jan 26 2016, 8:15 AM
slarin added a reviewer for D16585: In split module utility we should never separate alias with its aliasee.: pcc.
Jan 26 2016, 8:14 AM
slarin retitled D16585: In split module utility we should never separate alias with its aliasee. from to In split module utility we should never separate alias with its aliasee..
Jan 26 2016, 8:13 AM

Jan 22 2016

slarin committed rL258556: Make sure that any new and optimized objects created during GlobalOPT copy….
Make sure that any new and optimized objects created during GlobalOPT copy…
Jan 22 2016, 1:22 PM
slarin closed D16074: Make sure that any new and optimized objects created during GlobalOPT copy all the attributes from the base object..
Jan 22 2016, 1:22 PM

Jan 20 2016

slarin updated the diff for D16074: Make sure that any new and optimized objects created during GlobalOPT copy all the attributes from the base object..

Cleared addrspace in tests.

Jan 20 2016, 1:03 PM
slarin updated the diff for D16074: Make sure that any new and optimized objects created during GlobalOPT copy all the attributes from the base object..

Implemented suggested changes.

Jan 20 2016, 10:21 AM

Jan 19 2016

slarin added a comment to D16074: Make sure that any new and optimized objects created during GlobalOPT copy all the attributes from the base object..

Hi Rafael,

Jan 19 2016, 7:54 AM

Jan 18 2016

slarin committed rL258083: Add to the split module utility an SCC based method which allows not to….
Add to the split module utility an SCC based method which allows not to…
Jan 18 2016, 1:11 PM

Jan 15 2016

slarin updated the diff for D16124: Add to the split module utility an SCC based method which allows not to globalize any local variables..

Implemented Peter's suggestions.

Jan 15 2016, 2:51 PM
slarin added a comment to D16124: Add to the split module utility an SCC based method which allows not to globalize any local variables..

Excellent suggestions. New patch will be up shortly.

Jan 15 2016, 2:40 PM
slarin added a comment to D16083: [bugpoint] Teach bugpoint to reduce MDNodes.

Got it. Thanks...

Jan 15 2016, 10:31 AM
slarin added a comment to D16083: [bugpoint] Teach bugpoint to reduce MDNodes.

Sorry - I told you I am starting cold :)

Jan 15 2016, 10:22 AM
slarin added a comment to D16083: [bugpoint] Teach bugpoint to reduce MDNodes.

Sorry to come in cold on the discussion, but let me ask a naive question - Why can't we teach CloneModule to drop unnecessary metadata in the same way we use a selector function for GlobalVariables (ShouldCloneDefinition) - why copy it in the first place?

Jan 15 2016, 9:56 AM
slarin updated subscribers of D16083: [bugpoint] Teach bugpoint to reduce MDNodes.
Jan 15 2016, 9:52 AM

Jan 14 2016

slarin added a comment to D16124: Add to the split module utility an SCC based method which allows not to globalize any local variables..

This would be even better if EquivalenceClasses would guarantee deterministic order... but anyhow - this should reflect Peter's comments.

Jan 14 2016, 8:55 AM
slarin updated the diff for D16124: Add to the split module utility an SCC based method which allows not to globalize any local variables..

Add to the split module utility an SCC based method which allows not to globalize any local variables.

Jan 14 2016, 8:52 AM

Jan 13 2016

slarin added a comment to D16124: Add to the split module utility an SCC based method which allows not to globalize any local variables..

Here is one issue with EquivalenceClasses. It uses

Jan 13 2016, 10:54 AM
slarin added a comment to D16124: Add to the split module utility an SCC based method which allows not to globalize any local variables..

> Constant merging sometimes introduces additional dependencies that
might be counterproductive for splitting, and we are currently looking at our
options to address that.

How bad is the problem? I think that as long as your re-globalization is
conservatively correct (i.e. does not pollute the global namespace) it would
still be a useful contribution.

Jan 13 2016, 8:16 AM

Jan 12 2016

slarin added a comment to D16124: Add to the split module utility an SCC based method which allows not to globalize any local variables..

In the end it depends on what your linker does. If your linker tracks global symbols, turning locals into globals will not play well even with hidden attribute.

Jan 12 2016, 3:50 PM
slarin added a comment to D16124: Add to the split module utility an SCC based method which allows not to globalize any local variables..

I think Tobias beat me to the answer - at the least we can have linker errors if we try to blindly globalize locals with identical names. Renaming them will not always work either, since our customers might rely on presence of specific symbols in the final image... There are also other reasons for that, but correctness of at least some corner cases seems like a hard justification on its own :-)

Jan 12 2016, 3:45 PM
slarin added a comment to D16124: Add to the split module utility an SCC based method which allows not to globalize any local variables..

You are right in general - we have seen this bias. To address the issue, we re-globalize things that were internalized for LTO leaving only _real_ dependencies. If that step is interesting for anyone - we can definitely upstream it... but it will not go all the way. Constant merging sometimes introduces additional dependencies that might be counterproductive for splitting, and we are currently looking at our options to address that.

Jan 12 2016, 3:40 PM
slarin updated subscribers of D16124: Add to the split module utility an SCC based method which allows not to globalize any local variables..
Jan 12 2016, 12:40 PM
slarin added a reviewer for D16124: Add to the split module utility an SCC based method which allows not to globalize any local variables.: pcc.
Jan 12 2016, 12:39 PM
slarin retitled D16124: Add to the split module utility an SCC based method which allows not to globalize any local variables. from to Add to the split module utility an SCC based method which allows not to globalize any local variables..
Jan 12 2016, 12:37 PM

Jan 11 2016

slarin added a comment to D16074: Make sure that any new and optimized objects created during GlobalOPT copy all the attributes from the base object..

Yes, We had this discussion with Chris (see more context here)

Jan 11 2016, 12:35 PM
slarin added a comment to D16074: Make sure that any new and optimized objects created during GlobalOPT copy all the attributes from the base object..

Not really. See the test case - even if we mix GV with and without sections they will all be processed.

Jan 11 2016, 12:12 PM
slarin added reviewers for D16074: Make sure that any new and optimized objects created during GlobalOPT copy all the attributes from the base object.: jmolloy, joker-eph-DISABLED.
Jan 11 2016, 11:39 AM
slarin retitled D16074: Make sure that any new and optimized objects created during GlobalOPT copy all the attributes from the base object. from to Make sure that any new and optimized objects created during GlobalOPT copy all the attributes from the base object..
Jan 11 2016, 11:31 AM

Nov 2 2015

slarin updated subscribers of D13515: Support for ThinLTO function importing and symbol linking..
Nov 2 2015, 8:43 AM