Page MenuHomePhabricator

skirkovski (Seraphime Kirkovski (VMware))
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2021, 2:04 AM (6 w, 2 d)

Recent Activity

Thu, Jun 24

skirkovski added a comment to D104096: [Clang-Format] Add ReferenceAlignment directive.

ping

Thu, Jun 24, 3:57 AM · Restricted Project

Jun 17 2021

skirkovski added a comment to D104096: [Clang-Format] Add ReferenceAlignment directive.

Rebased and fixed warning. My local compiler was yelling at me for adding a default case to switch which already covers everything.

Jun 17 2021, 9:20 AM · Restricted Project
skirkovski updated the diff for D104096: [Clang-Format] Add ReferenceAlignment directive.

Rebase and fix warning

Jun 17 2021, 9:18 AM · Restricted Project

Jun 15 2021

skirkovski added a comment to D104096: [Clang-Format] Add ReferenceAlignment directive.

I do not have commit access, can someone submit this as time permits ?

Jun 15 2021, 1:33 PM · Restricted Project

Jun 12 2021

skirkovski added a comment to D104096: [Clang-Format] Add ReferenceAlignment directive.

Thanks for the review. I do not have submit access. Can you take care of landing the revision when you have some free time ?

Jun 12 2021, 5:33 AM · Restricted Project
skirkovski updated the diff for D104096: [Clang-Format] Add ReferenceAlignment directive.

Sort ReferenceAlignment after RawStringFormats in mapping()

Jun 12 2021, 4:53 AM · Restricted Project
skirkovski updated the diff for D104096: [Clang-Format] Add ReferenceAlignment directive.

Remove PAS_Pointer from Webkit style (since it derives from LLVM which already has it)
Add empty lines between style change in the test case
Split a verifyFormat with 3 different cases into different ones
Add test cases for declaration alignemnts

Jun 12 2021, 2:38 AM · Restricted Project

Jun 11 2021

MyDeveloperDay awarded D104096: [Clang-Format] Add ReferenceAlignment directive a Like token.
Jun 11 2021, 9:50 AM · Restricted Project
skirkovski added reviewers for D104096: [Clang-Format] Add ReferenceAlignment directive: MyDeveloperDay, HazardyKnusperkeks, curdeius.
Jun 11 2021, 12:47 AM · Restricted Project
skirkovski requested review of D104096: [Clang-Format] Add ReferenceAlignment directive.
Jun 11 2021, 12:45 AM · Restricted Project

Jun 10 2021

skirkovski added a comment to D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635).

@curdeius , @HazardyKnusperkeks any thoughts, personally I don't have any problems with this even if its not my personal preference. @skirkovski if this is something you need we might need for you to take over the revision and bring it upto date and address the comments? is that something you would be interesting in helping out with?

Jun 10 2021, 5:07 AM · Restricted Project, Restricted Project
skirkovski added a comment to D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635).

Is there still interest in this feature ?

Jun 10 2021, 2:12 AM · Restricted Project, Restricted Project