Page MenuHomePhabricator

skerner (Sam Kerner)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 18 2014, 6:37 AM (295 w, 3 d)

Recent Activity

Mar 30 2018

skerner added a comment to D44784: DataFlowSanitizer: wrappers of functions with local linkage should have the same linkage as the function being wrapped.

Peter, friendly ping.

Mar 30 2018, 7:16 AM

Mar 23 2018

skerner added a comment to D44784: DataFlowSanitizer: wrappers of functions with local linkage should have the same linkage as the function being wrapped.
In D44784#1045790, @pcc wrote:

It seems like a better fix would be to give the dfsw$ function internal linkage if the wrapped function has internal linkage. That way, if two translation units have static uninstrumented functions with the same name, the references to the dfsw$ functions will be correct.

Mar 23 2018, 10:42 AM
skerner retitled D44784: DataFlowSanitizer: wrappers of functions with local linkage should have the same linkage as the function being wrapped from DataFlowSanitizer: do not allow wrapper functions with non-local linkage to have dso_local set. to DataFlowSanitizer: wrappers of functions with local linkage should have the same linkage as the function being wrapped.
Mar 23 2018, 10:40 AM
skerner updated the diff for D44784: DataFlowSanitizer: wrappers of functions with local linkage should have the same linkage as the function being wrapped.

Address review comment: Wrappers of local functions should have the same linkage as the function being wrapped.

Mar 23 2018, 10:39 AM

Mar 22 2018

skerner updated the summary of D44784: DataFlowSanitizer: wrappers of functions with local linkage should have the same linkage as the function being wrapped.
Mar 22 2018, 8:59 AM
skerner updated the diff for D44784: DataFlowSanitizer: wrappers of functions with local linkage should have the same linkage as the function being wrapped.

Revert a file which was mistakenly included.

Mar 22 2018, 8:56 AM
skerner created D44784: DataFlowSanitizer: wrappers of functions with local linkage should have the same linkage as the function being wrapped.
Mar 22 2018, 8:53 AM

Feb 20 2018

skerner added a comment to D43132: Fix DataFlowSanitizer instrumentation pass to take parameter position changes into account for custom functions..

Peter, can you please commit this change?

Feb 20 2018, 9:23 AM

Feb 12 2018

skerner added a comment to D43132: Fix DataFlowSanitizer instrumentation pass to take parameter position changes into account for custom functions..

Peter, thanks for the review!

Feb 12 2018, 9:58 AM
skerner updated the diff for D43132: Fix DataFlowSanitizer instrumentation pass to take parameter position changes into account for custom functions..

Address review comments.

Feb 12 2018, 9:56 AM
skerner updated the diff for D43132: Fix DataFlowSanitizer instrumentation pass to take parameter position changes into account for custom functions..

Fix review comments.

Feb 12 2018, 9:46 AM

Feb 9 2018

skerner updated the diff for D43132: Fix DataFlowSanitizer instrumentation pass to take parameter position changes into account for custom functions..

Polish

Feb 9 2018, 11:05 AM
skerner created D43132: Fix DataFlowSanitizer instrumentation pass to take parameter position changes into account for custom functions..
Feb 9 2018, 10:29 AM

Aug 13 2014

skerner updated the test plan for D4894: DFSan's set label function should avoid writing to the shadow memory when the write would not change the value in memory..
Aug 13 2014, 6:49 PM
skerner retitled D4894: DFSan's set label function should avoid writing to the shadow memory when the write would not change the value in memory. from to DFSan's set label function should avoid writing to the shadow memory when the write would not change the value in memory..
Aug 13 2014, 6:48 PM
skerner abandoned D4893: DFSan's set label function should avoid writing to the shadow memory when the write would not change the value in memory..
Aug 13 2014, 6:47 PM
skerner updated subscribers of D4893: DFSan's set label function should avoid writing to the shadow memory when the write would not change the value in memory..
Aug 13 2014, 6:44 PM
skerner retitled D4893: DFSan's set label function should avoid writing to the shadow memory when the write would not change the value in memory. from to DFSan's set label function should avoid writing to the shadow memory when the write would not change the value in memory..
Aug 13 2014, 6:42 PM