• removed rank checks
• removed invalid canonicalize tests (_different_shape)

@eric-k256 I guess I will just remove the _different_shape tests and keep the new _bcast_ tests since that should be sufficient coverage. Is that acceptable?

• added rank checks for the folders
• further simplified
• also removed redundant and incorrect pattern rewriters for AddZero and MulOne

@eric-k256 thanks. I didn't see a hard requirement in the spec and was confused by the test above for add_zero_different_shape. Also turns out there is a AddZeroOptimization and MulOneOptimization that also allow mixed rank folding.. also kind of redundant. Shall I remove those as well?

@mgehre-amd thanks, simplified the logic.
@rsuderman cleaned up PR.

• simplified logic
• removed irrelevant change

@nicolasvasilache any feedback?

Thanks @rsuderman. Updated.

• cleanup changes for review comments

wrong button..

@hanchung any feedback on this.

Understood. This is as you said just lifting these attributes, a future change would use them and I will post it as an RFC to discuss. This change can wait for that, just trying to flush some trivial parts from my backlog.

Merged with original PR.

update format

[MLIR][Func] Add readonly,writeonly,noalias to func arg attributes

@ftynse these attributes are specific to func parameters, and not necessarily to LLVM backends (e.g. SPIRV). They are useful for dataflow analysis and would prefer not to have to include LLVMIR everywhere.

Simplified after rebase, using translation tables.