User Details
- User Since
- Jun 29 2021, 6:48 AM (117 w, 1 d)
Wed, Aug 30
Thanks for the improvements.
Tue, Aug 29
Updating D158180: [mlir][emitc] Add comparison operation
Aug 23 2023
Updating D158180: [mlir][emitc] Add comparison operation
Aug 22 2023
Updating D158180: [mlir][emitc] Add comparison operation
Aug 17 2023
Updating D158180: [mlir][emitc] Add comparison operation
Jul 4 2023
Can you add an error message when the module contains multiple func ops, paired with a test in test/Target/Cpp/invalid.mlir. Currently the translation succeeds but generates code that contains repeated class definitions with the same name.
Jun 26 2023
To me this looks like a lot of additional code that targets a very specific use case. Additionally this hardcodes the assumption that the Tensor class exposes a get method into the emitter.
May 11 2023
Apr 26 2023
Thanks for the cleanup @QuqqU. This LGTM.
Sep 13 2021
Sorry for the delay, I got distracted by other work :)
Add tests for the CPP target.
Sep 2 2021
I will add tests for the emitter now that it has landed, as well as a verifier for the opaque type to check whether it's a valid C identifier.
Updating D109143: [mlir] Fix printing of EmitC attrs/types with escape characters
Aug 25 2021
Jul 2 2021
Address review comments.