Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

simon-camp (Simon Camphausen)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2021, 6:48 AM (117 w, 1 d)

Recent Activity

Wed, Aug 30

simon-camp accepted D159195: [mlir][emitc][nfc] List supported comparisons.

Thanks for the improvements.

Wed, Aug 30, 7:21 AM · Restricted Project, Restricted Project

Tue, Aug 29

simon-camp added inline comments to D158180: [mlir][emitc] Add comparison operation.
Tue, Aug 29, 7:52 AM · Restricted Project, Restricted Project
simon-camp updated the diff for D158180: [mlir][emitc] Add comparison operation.

Updating D158180: [mlir][emitc] Add comparison operation

Tue, Aug 29, 5:37 AM · Restricted Project, Restricted Project

Aug 23 2023

simon-camp updated the diff for D158180: [mlir][emitc] Add comparison operation.

Updating D158180: [mlir][emitc] Add comparison operation

Aug 23 2023, 4:02 AM · Restricted Project, Restricted Project

Aug 22 2023

simon-camp added inline comments to D158180: [mlir][emitc] Add comparison operation.
Aug 22 2023, 7:06 AM · Restricted Project, Restricted Project
simon-camp updated the diff for D158180: [mlir][emitc] Add comparison operation.

Updating D158180: [mlir][emitc] Add comparison operation

Aug 22 2023, 7:01 AM · Restricted Project, Restricted Project

Aug 17 2023

simon-camp updated the diff for D158180: [mlir][emitc] Add comparison operation.

Updating D158180: [mlir][emitc] Add comparison operation

Aug 17 2023, 6:27 AM · Restricted Project, Restricted Project
simon-camp requested review of D158180: [mlir][emitc] Add comparison operation.
Aug 17 2023, 6:23 AM · Restricted Project, Restricted Project

Jul 4 2023

simon-camp added a comment to D147570: Add option to emit stateful functions to the emitc backend..

Can you add an error message when the module contains multiple func ops, paired with a test in test/Target/Cpp/invalid.mlir. Currently the translation succeeds but generates code that contains repeated class definitions with the same name.

Jul 4 2023, 6:39 AM · Restricted Project, Restricted Project

Jun 26 2023

simon-camp added a comment to D147570: Add option to emit stateful functions to the emitc backend..

To me this looks like a lot of additional code that targets a very specific use case. Additionally this hardcodes the assumption that the Tensor class exposes a get method into the emitter.

Jun 26 2023, 2:06 AM · Restricted Project, Restricted Project

May 11 2023

simon-camp added inline comments to D150356: [mlir][emitc] Add literal constant..
May 11 2023, 6:45 AM · Restricted Project, Restricted Project
simon-camp added a comment to D150356: [mlir][emitc] Add literal constant..
May 11 2023, 6:34 AM · Restricted Project, Restricted Project

Apr 26 2023

simon-camp accepted D147992: [MLIR][EmitC] Disallow to apply the op & to const.

Thanks for the cleanup @QuqqU. This LGTM.

Apr 26 2023, 7:10 AM · Restricted Project, Restricted Project

Sep 13 2021

simon-camp requested review of D109690: [mlir][emitc] Print signed integers properly.
Sep 13 2021, 7:49 AM · Restricted Project
simon-camp added a comment to D109143: [mlir] Fix printing of EmitC attrs/types with escape characters.

Sorry for the delay, I got distracted by other work :)

Sep 13 2021, 3:17 AM · Restricted Project
simon-camp updated the diff for D109143: [mlir] Fix printing of EmitC attrs/types with escape characters.

Add tests for the CPP target.

Sep 13 2021, 2:56 AM · Restricted Project

Sep 2 2021

simon-camp added a comment to D109143: [mlir] Fix printing of EmitC attrs/types with escape characters.

I will add tests for the emitter now that it has landed, as well as a verifier for the opaque type to check whether it's a valid C identifier.

Sep 2 2021, 8:24 AM · Restricted Project
simon-camp updated the diff for D109143: [mlir] Fix printing of EmitC attrs/types with escape characters.

Updating D109143: [mlir] Fix printing of EmitC attrs/types with escape characters

Sep 2 2021, 3:06 AM · Restricted Project
simon-camp requested review of D109143: [mlir] Fix printing of EmitC attrs/types with escape characters.
Sep 2 2021, 2:58 AM · Restricted Project

Aug 25 2021

simon-camp added inline comments to D104632: [mlir] Add Cpp emitter.
Aug 25 2021, 4:11 AM · Restricted Project

Jul 2 2021

simon-camp added inline comments to D105281: [mlir] Change custom syntax of emitc.include op to resemble C.
Jul 2 2021, 12:32 AM · Restricted Project
simon-camp updated the diff for D105281: [mlir] Change custom syntax of emitc.include op to resemble C.

Address review comments.

Jul 2 2021, 12:29 AM · Restricted Project

Jul 1 2021

simon-camp requested review of D105281: [mlir] Change custom syntax of emitc.include op to resemble C.
Jul 1 2021, 7:03 AM · Restricted Project

Jun 29 2021

simon-camp added inline comments to D104632: [mlir] Add Cpp emitter.
Jun 29 2021, 7:20 AM · Restricted Project