I think this can wait at this point. I noticed the problem on Power when I was doing performance tests. On Power using all the available threads (including HT) was causing slow downs with SPEC Accel OMP, so I had to set the OMP_THREAD_LIMIT and noticed the seg faults. I can patch my own runtime and wait for the next release that will integrate this fix. Thanks!

Will this fix make it to the 9.0 release? Thank you!

This looks great, thanks guys!
I agree, the name is mostly a "marketing" thing at this point, people know it in that way, changing it would be confusing.

I updated the patch and the description.
I have no way at this moment to test it on Windows, is the "--no-as-needed" flag supported?

In D40722#942168, @Hahnfeld wrote:

Looks like this also fixes https://bugs.llvm.org/show_bug.cgi?id=26199.

Fixed indentation errors, removed dead code and old barrier annotations.

I updated the patch according to the last comments.
I have tried to compile the runtime on PPC64LE and I was getting several compiling errors, have anybody compiled the runtime on power recently?

We rewrote the annotations file to deal with the license issue.

Addressed Dmitry's comment, patch ready to land.

Ping...

is ok to commit the patch in this status?
I talked to Bill, and he agreed to commit the patch as it is, since in the future they are more concerned about LE systems (VMA=46).

I added XFAIL in the tests that are currently failing.
I added a comment in each test so the failure can be addressed later more easily.

Updated patch for supporting multiple VMA (44 and 46 bits). To support these multiple VMAS transformations I followed the same mechanism used for AARCH64. By default the system will build for VMA=46, in order to build for VMA=44 will be still necessary to define the macro SANITIZER_PPC64_VMA at build time, for example for CMake:

I guess you might be right.
The only info that I can gather from GDB are the following:

Hi Bill,

Simone, can you please test this assembly code on the machine where you were having difficulty with the previous patch?

Fixed indentation spaces in "internal_clone" function. It made it fail the tests.

Adding Joachim, who is the main creator of the patch.
He can give more details if needed.

Removed TSAN_SUPPORT macro.

In D13072#252137, @hfinkel wrote:

Thanks for working on this; I'm very excited to see this functionality!

As a general comment, can you always define ANNOTATE_* macros, and just make them empty if TSAN_SUPPORT is not true. What would make things less verbose.

In D13072#252137, @hfinkel wrote:

Thanks for working on this; I'm very excited to see this functionality!

As a general comment, can you always define ANNOTATE_* macros, and just make them empty if TSAN_SUPPORT is not true. What would make things less verbose.

Activated by default ANNOTATIONS (switch on/off only with TSAN_SUPPORT).

Fixed tabs to spaces

Updated patch with "internal_clone", thanks to zatrazz for the implementation.

Patch fixed according to last comments.

Inserted control for BE and LE when selecting the GLIBC version.

Fixed test, ppc32 won't support Tsan.

Ignore previous update.

Ignore previous update.

• Added more context.
• Addressed all the comments

Added more context.