Page MenuHomePhabricator

simoatze (Simone)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 14 2015, 7:18 AM (210 w, 55 m)

Recent Activity

Mon, Sep 2

simoatze added a comment to D66351: Force runtime to honor nthreads-var and thread-limit-var inside the teams construct on host..

I think this can wait at this point. I noticed the problem on Power when I was doing performance tests. On Power using all the available threads (including HT) was causing slow downs with SPEC Accel OMP, so I had to set the OMP_THREAD_LIMIT and noticed the seg faults. I can patch my own runtime and wait for the next release that will integrate this fix. Thanks!

Mon, Sep 2, 1:14 PM · Restricted Project, Restricted Project

Aug 20 2019

simoatze added a comment to D66351: Force runtime to honor nthreads-var and thread-limit-var inside the teams construct on host..

Will this fix make it to the 9.0 release? Thank you!

Aug 20 2019, 10:31 AM · Restricted Project, Restricted Project

Dec 10 2018

simoatze added a comment to D45890: [OMPT] Add implementation and tests of Archer tool.

This looks great, thanks guys!
I agree, the name is mostly a "marketing" thing at this point, people know it in that way, changing it would be confusing.

Dec 10 2018, 7:25 AM

Jul 4 2018

simoatze retitled D48888: Dropped non-supoorted "--no-as-needed" flag from OMPT tests for macOS from Dropped "--no-as-needed" flag from OMPT for macOS to Dropped non-supoorted "--no-as-needed" flag from OMPT tests for macOS.
Jul 4 2018, 10:48 AM

Jul 3 2018

simoatze retitled D48888: Dropped non-supoorted "--no-as-needed" flag from OMPT tests for macOS from Removed "--no-as-needed" flag from OMPT tests to avoid failures on OSX to Dropped "--no-as-needed" flag from OMPT for macOS.
Jul 3 2018, 1:56 PM
simoatze updated the diff for D48888: Dropped non-supoorted "--no-as-needed" flag from OMPT tests for macOS.

I updated the patch and the description.
I have no way at this moment to test it on Windows, is the "--no-as-needed" flag supported?

Jul 3 2018, 1:55 PM
simoatze created D48888: Dropped non-supoorted "--no-as-needed" flag from OMPT tests for macOS.
Jul 3 2018, 11:02 AM

Jan 11 2018

simoatze added a comment to D40722: Add missing memory barrier for queuing locks.
Jan 11 2018, 11:50 AM

Jan 26 2017

simoatze created D29202: [OpenMP] New Tsan annotations to remove false positive on reduction and barriers.
Jan 26 2017, 3:55 PM

Jan 6 2017

simoatze updated D28443: Introducing a function to flush the shadow memory from third-party libraries.
Jan 6 2017, 10:37 PM
simoatze retitled D28443: Introducing a function to flush the shadow memory from third-party libraries from to Introducing a function to flush the shadow memory from third-party libraries.
Jan 6 2017, 10:36 PM

Oct 27 2016

simoatze updated the diff for D13072: [OpenMP] Enable ThreadSanitizer to check OpenMP programs.

Fixed indentation errors, removed dead code and old barrier annotations.

Oct 27 2016, 11:45 AM

Oct 21 2016

simoatze added inline comments to D13072: [OpenMP] Enable ThreadSanitizer to check OpenMP programs.
Oct 21 2016, 4:27 PM
simoatze updated the diff for D13072: [OpenMP] Enable ThreadSanitizer to check OpenMP programs.

I updated the patch according to the last comments.
I have tried to compile the runtime on PPC64LE and I was getting several compiling errors, have anybody compiled the runtime on power recently?

Oct 21 2016, 4:27 PM

Oct 13 2016

simoatze updated the diff for D13072: [OpenMP] Enable ThreadSanitizer to check OpenMP programs.

We rewrote the annotations file to deal with the license issue.

Oct 13 2016, 1:37 PM

Dec 7 2015

simoatze updated the diff for D12841: [LLVMdev] Compiler-RT - Enabling ThreadSanitizer on PPC64(BE/LE) platforms.

Addressed Dmitry's comment, patch ready to land.

Dec 7 2015, 10:54 AM

Dec 4 2015

simoatze added a comment to D12841: [LLVMdev] Compiler-RT - Enabling ThreadSanitizer on PPC64(BE/LE) platforms.

Ping...

Dec 4 2015, 6:43 AM

Dec 2 2015

simoatze added a comment to D12841: [LLVMdev] Compiler-RT - Enabling ThreadSanitizer on PPC64(BE/LE) platforms.

is ok to commit the patch in this status?
I talked to Bill, and he agreed to commit the patch as it is, since in the future they are more concerned about LE systems (VMA=46).

Dec 2 2015, 1:04 PM

Dec 1 2015

simoatze updated the diff for D12841: [LLVMdev] Compiler-RT - Enabling ThreadSanitizer on PPC64(BE/LE) platforms.

I added XFAIL in the tests that are currently failing.
I added a comment in each test so the failure can be addressed later more easily.

Dec 1 2015, 11:59 PM

Nov 27 2015

simoatze updated the diff for D12841: [LLVMdev] Compiler-RT - Enabling ThreadSanitizer on PPC64(BE/LE) platforms.

Updated patch for supporting multiple VMA (44 and 46 bits). To support these multiple VMAS transformations I followed the same mechanism used for AARCH64. By default the system will build for VMA=46, in order to build for VMA=44 will be still necessary to define the macro SANITIZER_PPC64_VMA at build time, for example for CMake:

Nov 27 2015, 11:51 PM

Nov 9 2015

simoatze added a comment to D13729: [TSAN, PowerPC] Setjmp/longjmp handling for PowerPC.

I guess you might be right.
The only info that I can gather from GDB are the following:

Nov 9 2015, 11:48 AM

Nov 8 2015

simoatze added a comment to D13729: [TSAN, PowerPC] Setjmp/longjmp handling for PowerPC.

Hi Bill,

Nov 8 2015, 9:47 PM

Nov 6 2015

simoatze added a comment to D13729: [TSAN, PowerPC] Setjmp/longjmp handling for PowerPC.

Simone, can you please test this assembly code on the machine where you were having difficulty with the previous patch?

Nov 6 2015, 12:54 AM

Sep 24 2015

simoatze updated the diff for D12841: [LLVMdev] Compiler-RT - Enabling ThreadSanitizer on PPC64(BE/LE) platforms.

Fixed indentation spaces in "internal_clone" function. It made it fail the tests.

Sep 24 2015, 5:07 PM
simoatze updated subscribers of D13072: [OpenMP] Enable ThreadSanitizer to check OpenMP programs.

Adding Joachim, who is the main creator of the patch.
He can give more details if needed.

Sep 24 2015, 6:37 AM

Sep 23 2015

simoatze updated the diff for D13072: [OpenMP] Enable ThreadSanitizer to check OpenMP programs.

Removed TSAN_SUPPORT macro.

Sep 23 2015, 2:44 PM
simoatze added a comment to D13072: [OpenMP] Enable ThreadSanitizer to check OpenMP programs.

Thanks for working on this; I'm very excited to see this functionality!

As a general comment, can you always define ANNOTATE_* macros, and just make them empty if TSAN_SUPPORT is not true. What would make things less verbose.

Sep 23 2015, 2:09 PM
simoatze added a comment to D13072: [OpenMP] Enable ThreadSanitizer to check OpenMP programs.

Thanks for working on this; I'm very excited to see this functionality!

As a general comment, can you always define ANNOTATE_* macros, and just make them empty if TSAN_SUPPORT is not true. What would make things less verbose.

Sep 23 2015, 2:06 PM
simoatze updated the diff for D13072: [OpenMP] Enable ThreadSanitizer to check OpenMP programs.

Activated by default ANNOTATIONS (switch on/off only with TSAN_SUPPORT).

Sep 23 2015, 2:00 PM
simoatze updated the diff for D13072: [OpenMP] Enable ThreadSanitizer to check OpenMP programs.

Fixed tabs to spaces

Sep 23 2015, 7:09 AM

Sep 22 2015

simoatze retitled D13072: [OpenMP] Enable ThreadSanitizer to check OpenMP programs from to [OpenMP] Enable ThreadSanitizer to check OpenMP programs.
Sep 22 2015, 2:43 PM

Sep 16 2015

simoatze updated the diff for D12841: [LLVMdev] Compiler-RT - Enabling ThreadSanitizer on PPC64(BE/LE) platforms.

Updated patch with "internal_clone", thanks to zatrazz for the implementation.

Sep 16 2015, 1:27 PM

Sep 15 2015

simoatze updated the diff for D12841: [LLVMdev] Compiler-RT - Enabling ThreadSanitizer on PPC64(BE/LE) platforms.

Patch fixed according to last comments.

Sep 15 2015, 4:43 PM
simoatze updated the diff for D12841: [LLVMdev] Compiler-RT - Enabling ThreadSanitizer on PPC64(BE/LE) platforms.

Inserted control for BE and LE when selecting the GLIBC version.

Sep 15 2015, 3:58 PM
simoatze updated the diff for D12841: [LLVMdev] Compiler-RT - Enabling ThreadSanitizer on PPC64(BE/LE) platforms.

Fixed test, ppc32 won't support Tsan.

Sep 15 2015, 2:40 PM
simoatze updated the diff for D12840: [cfe-dev] Enabling ThreadSanitizer on PPC64(BE/LE) plarforms.

Ignore previous update.

Sep 15 2015, 12:29 PM
simoatze updated the diff for D12841: [LLVMdev] Compiler-RT - Enabling ThreadSanitizer on PPC64(BE/LE) platforms.

Ignore previous update.

Sep 15 2015, 12:28 PM
simoatze updated the diff for D12841: [LLVMdev] Compiler-RT - Enabling ThreadSanitizer on PPC64(BE/LE) platforms.
  • Added more context.
  • Addressed all the comments
Sep 15 2015, 12:21 PM
simoatze updated the diff for D12840: [cfe-dev] Enabling ThreadSanitizer on PPC64(BE/LE) plarforms.

Added more context.

Sep 15 2015, 12:15 PM

Sep 14 2015

simoatze retitled D12841: [LLVMdev] Compiler-RT - Enabling ThreadSanitizer on PPC64(BE/LE) platforms from to [LLVMdev] Compiler-RT - Enabling ThreadSanitizer on PPC64(BE/LE) platforms.
Sep 14 2015, 8:24 AM
simoatze retitled D12840: [cfe-dev] Enabling ThreadSanitizer on PPC64(BE/LE) plarforms from to [cfe-dev] Enabling ThreadSanitizer on PPC64(BE/LE) plarforms.
Sep 14 2015, 8:15 AM