Page MenuHomePhabricator

siedentop (Christoph Siedentop)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 22 2019, 5:57 PM (33 w, 5 d)

Recent Activity

Jun 18 2019

siedentop added a comment to D63370: Specify log level for CMake messages (less stderr).

@sgraenitz I cannot merge the changes myself, could you please commit them for me?

Jun 18 2019, 2:23 PM · Restricted Project, Restricted Project, Restricted Project

Jun 17 2019

siedentop updated the diff for D63370: Specify log level for CMake messages (less stderr).

@sgraenitz , good find. I've removed the leading dashes.

Jun 17 2019, 8:41 PM · Restricted Project, Restricted Project, Restricted Project

Jun 15 2019

siedentop updated the diff for D63370: Specify log level for CMake messages (less stderr).

Removed changes to llvm/utils/benchmark.

Jun 15 2019, 12:01 PM · Restricted Project, Restricted Project, Restricted Project
siedentop added a comment to D63370: Specify log level for CMake messages (less stderr).

The llvm/utils/benchmark/ changes - can you please either submit them upstream yourself, or explicitly state that it is okay to steal them from you and submit?

Jun 15 2019, 11:47 AM · Restricted Project, Restricted Project, Restricted Project

Jun 14 2019

siedentop added a comment to D63370: Specify log level for CMake messages (less stderr).

Thank you for the review, @xiaobai. I've made the requested change.

Jun 14 2019, 5:21 PM · Restricted Project, Restricted Project, Restricted Project
siedentop updated the diff for D63370: Specify log level for CMake messages (less stderr).

Modified STATUS to WARNING as requested by @xiaobai

Jun 14 2019, 5:20 PM · Restricted Project, Restricted Project, Restricted Project
siedentop created D63370: Specify log level for CMake messages (less stderr).
Jun 14 2019, 5:00 PM · Restricted Project, Restricted Project, Restricted Project

May 5 2019

siedentop added a comment to D61550: Add recommendations on how to start a meetup in your city.

Please take into account @mehdi_amini 's valid two points. Besides this LGTM.

May 5 2019, 12:11 PM · Restricted Project

May 4 2019

siedentop added a comment to D61550: Add recommendations on how to start a meetup in your city.

Hi @AlexDenisov, I thought I could help in copy-editing this file. Very nice writing and useful advice. I am not a reviewer on LLVM though, so I cannot merge this.

May 4 2019, 7:37 PM · Restricted Project

Apr 24 2019

siedentop added a comment to D60987: [docs] Copy-edit lld/docs/WebAssembly.rst.

Could someone please merge/commit this now? I do not have commit access. First contribution :)

Apr 24 2019, 8:04 AM · Restricted Project

Apr 23 2019

siedentop updated the diff for D60987: [docs] Copy-edit lld/docs/WebAssembly.rst.

Thank you for the suggestion. Updated as suggested.

Apr 23 2019, 6:30 PM · Restricted Project

Apr 22 2019

siedentop created D60987: [docs] Copy-edit lld/docs/WebAssembly.rst.
Apr 22 2019, 6:19 PM · Restricted Project