Page MenuHomePhabricator

shixiao (Xiao Shi)
User

Projects

User does not belong to any projects.

User Details

User Since
May 15 2019, 8:18 PM (30 w, 12 h)

Recent Activity

Jul 18 2019

shixiao added inline comments to D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.
Jul 18 2019, 6:11 AM · Restricted Project

Jul 13 2019

shixiao added a comment to D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.

Could someone please take a look? I think I've addressed all of Jonas's comments above. Thank you!

Jul 13 2019, 11:13 AM · Restricted Project

Jun 26 2019

shixiao added a comment to D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.

Ping =) @JonasToth

Jun 26 2019, 9:53 AM · Restricted Project

Jun 19 2019

shixiao updated the diff for D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.

rebase

Jun 19 2019, 6:13 PM · Restricted Project

Jun 12 2019

shixiao added a comment to D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.

Ping =) @JonasToth

Jun 12 2019, 11:00 AM · Restricted Project

Jun 5 2019

shixiao updated the diff for D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.

update commit summary

Jun 5 2019, 6:49 PM · Restricted Project
shixiao updated the diff for D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.

rebase, fix comments, enable for c++2a, add report for running the check on llvm

Jun 5 2019, 6:48 PM · Restricted Project

May 28 2019

shixiao added a comment to D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.

Could you please run this check over LLVM and give a short report of your finding? I would imagine that there is a lot of duplication, given the include-heavy nature of big c++ code bases.

May 28 2019, 7:06 AM · Restricted Project

May 21 2019

shixiao added a comment to D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.

@JonasToth, does this look reasonable to you? Thanks!

May 21 2019, 7:01 AM · Restricted Project

May 16 2019

shixiao updated the diff for D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.

edit doc, add note in release notes, extend unit test to test transitive header includes

May 16 2019, 5:21 PM · Restricted Project
shixiao updated the diff for D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.

elide braces for single-stmt if-s, extend unit test

May 16 2019, 5:04 PM · Restricted Project

May 15 2019

shixiao updated the summary of D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.
May 15 2019, 8:39 PM · Restricted Project
shixiao created D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.
May 15 2019, 8:37 PM · Restricted Project