Page MenuHomePhabricator

shivanshu3 (Shivanshu Goyal)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 1 2020, 7:02 PM (7 w, 12 h)

Recent Activity

Tue, Oct 6

shivanshu3 updated the diff for D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl.

Address Hans' comments

  • Prepend %s with "--" for clang-cl
  • Remove a redundant test case
Tue, Oct 6, 2:40 AM · Restricted Project

Mon, Oct 5

shivanshu3 updated the diff for D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl.

Address Reid's comments:

  • Use hasFlag instead of hasArg
  • Add test cases
Mon, Oct 5, 6:38 PM · Restricted Project

Fri, Oct 2

shivanshu3 added a comment to D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl.

Also, I wanted to mention that clang-cl.exe actually crashes deterministically when running precompiles for 2 of our headers when using '-fpch-instantiate-templates' with the following signature:

Fri, Oct 2, 3:25 AM · Restricted Project

Thu, Oct 1

shivanshu3 added a comment to D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl.

Can you get at least some testcase, even if not small?

Thu, Oct 1, 11:48 PM · Restricted Project
shivanshu3 added a comment to D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl.
In D88680#2307564, @rnk wrote:

I think the flag was originally intended to be an internal -cc1 flag not exposed to users. You should be able to work around your problem with -Xclang -fno-pch-instantiate-templates, btw.


@zequanwu, can you patch this in locally and take over this patch? Please address the hasFlag comment above, add a test to clang/test/Driver, and make sure the flag works with --driver-mode=gcc and --driver-mode=cl. Follow the examples of the other tests, run clang with -###, and make sure this flag does or does not appear on the -cc1 line.

Thu, Oct 1, 5:46 PM · Restricted Project
shivanshu3 added a reviewer for D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl: zturner.
Thu, Oct 1, 4:40 PM · Restricted Project
shivanshu3 added a comment to D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl.

Note that I do not have commit access and this change will have to be committed by someone else on my behalf. Please use the following commit author details:
"Shivan Goyal <shigoyal@microsoft.com>"

Thu, Oct 1, 10:50 AM · Restricted Project
shivanshu3 requested review of D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl.
Thu, Oct 1, 10:41 AM · Restricted Project

Sep 3 2020

shivanshu3 added a comment to D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver.

Note that I do not have commit access and this change will have to be committed by someone else on my behalf. Thanks!

Sep 3 2020, 3:41 PM · Restricted Project
shivanshu3 added inline comments to D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver.
Sep 3 2020, 1:12 PM · Restricted Project
shivanshu3 updated the diff for D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver.
  • Remove the bool IsDependencyFileArg in the implementation of getClangStripDependencyFileAdjuster() to make it simpler.
  • Add an extra argument after -MT in the test case to ensure we do not strip arguments after -MT when using the cl driver mode.
Sep 3 2020, 1:11 PM · Restricted Project

Sep 2 2020

shivanshu3 added inline comments to D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver.
Sep 2 2020, 5:44 PM · Restricted Project
shivanshu3 updated the diff for D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver.
  • Simplified the implementation of getDriverMode and got rid of the Optional return type.
  • When using the cl driver mode, we do not want to skip the next argument for -MF, -MT, -MQ.
Sep 2 2020, 5:40 PM · Restricted Project

Sep 1 2020

shivanshu3 added a reviewer for D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver: zahen.
Sep 1 2020, 8:33 PM · Restricted Project
shivanshu3 requested review of D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver.
Sep 1 2020, 8:32 PM · Restricted Project