Page MenuHomePhabricator

shivanshu3 (Shivanshu Goyal)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 1 2020, 7:02 PM (31 w, 4 d)

Recent Activity

Dec 15 2020

shivanshu3 added inline comments to D91129: Print source location in the error message when parens are missing around sizeof typename and the expression is inside macro expansion.
Dec 15 2020, 3:25 PM · Restricted Project
shivanshu3 updated the diff for D91129: Print source location in the error message when parens are missing around sizeof typename and the expression is inside macro expansion.

Don't assume that getLocForEndOfToken will fail if and only if the token is a macro

Dec 15 2020, 3:24 PM · Restricted Project
shivanshu3 added a comment to D91659: Allow enum typedefs to be referenced with the 'enum' specifier under MSVC compat mode.

Ping!

Dec 15 2020, 2:12 PM · Restricted Project
shivanshu3 added a comment to D91129: Print source location in the error message when parens are missing around sizeof typename and the expression is inside macro expansion.

Ping!

Dec 15 2020, 2:11 PM · Restricted Project

Dec 1 2020

shivanshu3 updated the diff for D91129: Print source location in the error message when parens are missing around sizeof typename and the expression is inside macro expansion.

Clang format the test file. Forgot to do it before.

Dec 1 2020, 5:50 PM · Restricted Project
shivanshu3 added inline comments to D91659: Allow enum typedefs to be referenced with the 'enum' specifier under MSVC compat mode.
Dec 1 2020, 3:58 PM · Restricted Project
shivanshu3 updated the diff for D91659: Allow enum typedefs to be referenced with the 'enum' specifier under MSVC compat mode.

Previously for some reason I thought that MSVC only allowed this behavior for anonymous enums. But now I realize that the enum doesn't have to be anonymous. So the following code should be legal too with '-fms-compatibility':

Dec 1 2020, 3:55 PM · Restricted Project

Nov 17 2020

shivanshu3 added a comment to D91659: Allow enum typedefs to be referenced with the 'enum' specifier under MSVC compat mode.

Thank you very much for the review @rsmith!

Nov 17 2020, 9:52 PM · Restricted Project
shivanshu3 updated the diff for D91659: Allow enum typedefs to be referenced with the 'enum' specifier under MSVC compat mode.

Addressing some of rsmith's comments:

  • Add a test case where an enum variable is declared in the same scope as the enum definition
  • Fix a style issue with parentheses
  • Simplify the if condition for the C case
  • The C++ case should only apply for TUK_Reference
Nov 17 2020, 9:48 PM · Restricted Project
shivanshu3 requested review of D91659: Allow enum typedefs to be referenced with the 'enum' specifier under MSVC compat mode.
Nov 17 2020, 2:09 PM · Restricted Project

Nov 12 2020

shivanshu3 updated the diff for D91129: Print source location in the error message when parens are missing around sizeof typename and the expression is inside macro expansion.

Use getFileLoc instead of getExpansionLoc to get the location of error.

Nov 12 2020, 2:24 PM · Restricted Project

Nov 10 2020

shivanshu3 added a reviewer for D91129: Print source location in the error message when parens are missing around sizeof typename and the expression is inside macro expansion: tiagoma.

Note that this regression seems to be there ever since Clang 3.4.1

Nov 10 2020, 6:17 PM · Restricted Project

Nov 9 2020

shivanshu3 requested review of D91129: Print source location in the error message when parens are missing around sizeof typename and the expression is inside macro expansion.
Nov 9 2020, 11:52 PM · Restricted Project

Oct 6 2020

shivanshu3 updated the diff for D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl.

Address Hans' comments

  • Prepend %s with "--" for clang-cl
  • Remove a redundant test case
Oct 6 2020, 2:40 AM · Restricted Project

Oct 5 2020

shivanshu3 updated the diff for D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl.

Address Reid's comments:

  • Use hasFlag instead of hasArg
  • Add test cases
Oct 5 2020, 6:38 PM · Restricted Project

Oct 2 2020

shivanshu3 added a comment to D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl.

Also, I wanted to mention that clang-cl.exe actually crashes deterministically when running precompiles for 2 of our headers when using '-fpch-instantiate-templates' with the following signature:

Oct 2 2020, 3:25 AM · Restricted Project

Oct 1 2020

shivanshu3 added a comment to D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl.

Can you get at least some testcase, even if not small?

Oct 1 2020, 11:48 PM · Restricted Project
shivanshu3 added a comment to D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl.
In D88680#2307564, @rnk wrote:

I think the flag was originally intended to be an internal -cc1 flag not exposed to users. You should be able to work around your problem with -Xclang -fno-pch-instantiate-templates, btw.


@zequanwu, can you patch this in locally and take over this patch? Please address the hasFlag comment above, add a test to clang/test/Driver, and make sure the flag works with --driver-mode=gcc and --driver-mode=cl. Follow the examples of the other tests, run clang with -###, and make sure this flag does or does not appear on the -cc1 line.

Oct 1 2020, 5:46 PM · Restricted Project
shivanshu3 added a reviewer for D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl: zturner.
Oct 1 2020, 4:40 PM · Restricted Project
shivanshu3 added a comment to D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl.

Note that I do not have commit access and this change will have to be committed by someone else on my behalf. Please use the following commit author details:
"Shivan Goyal <shigoyal@microsoft.com>"

Oct 1 2020, 10:50 AM · Restricted Project
shivanshu3 requested review of D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl.
Oct 1 2020, 10:41 AM · Restricted Project

Sep 3 2020

shivanshu3 added a comment to D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver.

Note that I do not have commit access and this change will have to be committed by someone else on my behalf. Thanks!

Sep 3 2020, 3:41 PM · Restricted Project
shivanshu3 added inline comments to D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver.
Sep 3 2020, 1:12 PM · Restricted Project
shivanshu3 updated the diff for D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver.
  • Remove the bool IsDependencyFileArg in the implementation of getClangStripDependencyFileAdjuster() to make it simpler.
  • Add an extra argument after -MT in the test case to ensure we do not strip arguments after -MT when using the cl driver mode.
Sep 3 2020, 1:11 PM · Restricted Project

Sep 2 2020

shivanshu3 added inline comments to D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver.
Sep 2 2020, 5:44 PM · Restricted Project
shivanshu3 updated the diff for D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver.
  • Simplified the implementation of getDriverMode and got rid of the Optional return type.
  • When using the cl driver mode, we do not want to skip the next argument for -MF, -MT, -MQ.
Sep 2 2020, 5:40 PM · Restricted Project

Sep 1 2020

shivanshu3 added a reviewer for D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver: zahen.
Sep 1 2020, 8:33 PM · Restricted Project
shivanshu3 requested review of D86999: getClangStripDependencyFileAdjuster(): Do not remove -M args when using MSVC cl driver.
Sep 1 2020, 8:32 PM · Restricted Project