Page MenuHomePhabricator

sherwin-dc (Sherwin)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 2 2021, 8:59 AM (19 w, 5 d)

Recent Activity

Sep 16 2021

sherwin-dc added a comment to D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled.

I dont have commit access, would someone be able to commit on my behalf? Thank You.

Sep 16 2021, 3:06 AM · Restricted Project

Sep 15 2021

sherwin-dc added a comment to D109631: [HardwareLoops] Loop guard intrinsic to recognise zext.

Thanks for reviewing. I dont have commit access, so I'll need help with landing the change.

Sep 15 2021, 10:42 AM · Restricted Project
sherwin-dc updated the diff for D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled.
  • Modify test to correctly indicate old/new PM
Sep 15 2021, 10:40 AM · Restricted Project
sherwin-dc updated the diff for D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled.
  • Modify test to correctly indicate old/new PM
Sep 15 2021, 9:16 AM · Restricted Project
sherwin-dc added inline comments to D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled.
Sep 15 2021, 6:41 AM · Restricted Project
sherwin-dc updated the diff for D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled.
  • Modify test to correctly indicate old/new PM
Sep 15 2021, 6:38 AM · Restricted Project
sherwin-dc added a comment to D109631: [HardwareLoops] Loop guard intrinsic to recognise zext.

@dmgreen would this test case suffice or should I add a ARM test that compiles to a WLS loop?

Sep 15 2021, 3:01 AM · Restricted Project

Sep 14 2021

sherwin-dc added a comment to D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled.

@tejohnson would you be able to take another look at this again

Sep 14 2021, 3:30 AM · Restricted Project

Sep 13 2021

sherwin-dc updated the diff for D109631: [HardwareLoops] Loop guard intrinsic to recognise zext.
  • Add loop guard test
Sep 13 2021, 9:18 AM · Restricted Project
sherwin-dc added inline comments to D109631: [HardwareLoops] Loop guard intrinsic to recognise zext.
Sep 13 2021, 8:09 AM · Restricted Project

Sep 10 2021

sherwin-dc requested review of D109631: [HardwareLoops] Loop guard intrinsic to recognise zext.
Sep 10 2021, 2:03 PM · Restricted Project

Sep 8 2021

sherwin-dc updated the diff for D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled.
  • Consolidate test cases into one
Sep 8 2021, 4:41 AM · Restricted Project
sherwin-dc added inline comments to D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled.
Sep 8 2021, 4:39 AM · Restricted Project

Sep 7 2021

sherwin-dc updated the diff for D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled.

[PGO] Change tests to look at passes run

Sep 7 2021, 4:54 AM · Restricted Project
sherwin-dc added a comment to D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled.

I have changed the unroll and icp tests to instead look at the passes that were run, which are shown with the -mllvm -opt-bisect-limit=-1 flag. This should allow checking that the Loop Unrolling and Indirect Call Promotion passes are run with samplepgo but not thinlto.

Sep 7 2021, 4:48 AM · Restricted Project
sherwin-dc added a reviewer for D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled: tejohnson.
Sep 7 2021, 4:45 AM · Restricted Project
sherwin-dc updated the diff for D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled.

[PGO] Change tests to look at which passes were run

Sep 7 2021, 4:26 AM · Restricted Project

Sep 3 2021

sherwin-dc updated subscribers of D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled.
Sep 3 2021, 10:55 AM · Restricted Project
sherwin-dc added inline comments to D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled.
Sep 3 2021, 10:38 AM · Restricted Project
sherwin-dc retitled D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled from Change ThinLTO test for targets with loop unrolling disabled to [PGO] Change ThinLTO test for targets with loop unrolling disabled.
Sep 3 2021, 6:42 AM · Restricted Project
sherwin-dc requested review of D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled.
Sep 3 2021, 6:34 AM · Restricted Project