- User Since
- Jan 5 2016, 3:55 PM (179 w, 6 d)
Jun 6 2018
@ruiu whatś your opinion on this?
Jun 5 2018
Re-write the getAlignment function, keep the original logic but with the 3 additional tests:
Mind take another look?
Jun 1 2018
@pcc thanks for the review. Updated the patch -
- if getAlignment sees a ABS symbols, returns 0
- initialize Ret to UINT64_MAX
- in "addCopyRelSymbol", errors out if alignment is 0.
- unit test case that tests for proper handling of ABS symbols.
May 31 2018
Thanks @ruiu Updated the patch, also attached a test case.
@pcc do you agree with initializing Ret to uint64-1?
Thanks Rui. I just updated the patch a little bit, that - st_value is only valid for alignment when symbol shndx is set to SHN_COMMON.
May 25 2018
May 17 2018
Thanks. (Comments revised and DefaoutOutSec -> Default)
May 16 2018
Hi George, mind take a look? (This is a follow up of D45788.)
May 15 2018
May 14 2018
Thanks for the review. Fixed as suggested in D45788.
Merge D46764 (Fix test cases that check addresses that are not always invariable) into this.
May 11 2018
Sorry for breaking the builders. Should double check again after my fix for the broken 4 cases.
May 10 2018
Some clarification why my test result is different from George's.
Thanks. Landed as https://llvm.org/svn/llvm-project/lld/trunk@332038
Synced to newest and re-ran tests, make sure everything passes.
May 8 2018
Thanks for the review.
Updated according to review feedback. Also synced to upstream HEAD and re-run all tests. All passed now.
May 7 2018
Revised linkerscript/out-of-order.s and linkerscript/no-space.s to honor layout constraint (also added notes). Also addressed previous 2 minor comments.
May 4 2018
May 3 2018
Refined test cases changes and provide more context.
May 2 2018
Fixed all affected test cases.
May 1 2018
Any further thoughts? If not, I'll proceed to fixing all the other test failures caused by section re-arrangement.
Apr 27 2018
Thanks. Done with a test case.
Apr 26 2018
@espindola would you mind take a look?
Apr 19 2018
Apr 18 2018
Apr 2 2018
clang-format the changed lines in X86_64.cpp
Mar 28 2018
Mar 2 2018
Fixed in llvm/trunk@326592
Aug 2 2017
Jul 31 2017
Ping? Can we make a decision on this?
I've this simple one D35849: [UBSan] Provide default blacklist filename for UBSan which, depending on this, shall be discarded or move forward.
If this CL stalls, I'll seek to proceed with D35849. Any how, D35849 gets wiped out whence this CL (D32842) is submitted.
Jul 25 2017
Thanks for pointing out the relevant CLs. I agree that's the clearer and better solution.
Thanks. Can you update "SanitizerArgs::collectDefaultBlacklists" to include "ubsan_blacklist.txt"?