Page MenuHomePhabricator

shenhan (Han Shen)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 5 2016, 3:55 PM (179 w, 6 d)

Recent Activity

Jun 6 2018

shenhan committed rL334155: ClangTidy fix - 'clang::Sema::checkAllowedCUDAInitializer' has a definition….
ClangTidy fix - 'clang::Sema::checkAllowedCUDAInitializer' has a definition…
Jun 6 2018, 6:00 PM
shenhan committed rC334155: ClangTidy fix - 'clang::Sema::checkAllowedCUDAInitializer' has a definition….
ClangTidy fix - 'clang::Sema::checkAllowedCUDAInitializer' has a definition…
Jun 6 2018, 6:00 PM
shenhan committed rLLD334135: Correct aligment computation for shared object symbols..
Correct aligment computation for shared object symbols.
Jun 6 2018, 2:48 PM
shenhan committed rL334135: Correct aligment computation for shared object symbols..
Correct aligment computation for shared object symbols.
Jun 6 2018, 2:48 PM
shenhan closed D47602: Correct aligment computation for shared object symbols.
Jun 6 2018, 2:48 PM
shenhan committed rL334114: Fix the test case that places intermediate in source directory..
Fix the test case that places intermediate in source directory.
Jun 6 2018, 12:00 PM
shenhan closed D47839: Fix the test case that places intermediate in source directory.
Jun 6 2018, 11:59 AM
shenhan created D47839: Fix the test case that places intermediate in source directory.
Jun 6 2018, 11:45 AM
shenhan added a comment to D47602: Correct aligment computation for shared object symbols.

@ruiu whatś your opinion on this?

Jun 6 2018, 9:41 AM

Jun 5 2018

shenhan added inline comments to D47602: Correct aligment computation for shared object symbols.
Jun 5 2018, 3:17 PM
shenhan updated the diff for D47602: Correct aligment computation for shared object symbols.
Jun 5 2018, 3:16 PM
shenhan added a comment to D47602: Correct aligment computation for shared object symbols.

Re-write the getAlignment function, keep the original logic but with the 3 additional tests:

Jun 5 2018, 1:56 PM
shenhan updated the diff for D47602: Correct aligment computation for shared object symbols.
Jun 5 2018, 1:56 PM
shenhan added a comment to D47602: Correct aligment computation for shared object symbols.

Mind take another look?

Jun 5 2018, 9:24 AM

Jun 1 2018

shenhan added inline comments to D47602: Correct aligment computation for shared object symbols.
Jun 1 2018, 5:33 PM
shenhan updated the diff for D47602: Correct aligment computation for shared object symbols.
Jun 1 2018, 5:32 PM
shenhan added inline comments to D47602: Correct aligment computation for shared object symbols.
Jun 1 2018, 2:25 PM
shenhan updated the diff for D47602: Correct aligment computation for shared object symbols.
Jun 1 2018, 2:25 PM
shenhan updated the diff for D47602: Correct aligment computation for shared object symbols.
Jun 1 2018, 2:14 PM
shenhan added inline comments to D47602: Correct aligment computation for shared object symbols.
Jun 1 2018, 2:09 PM
shenhan updated the diff for D47602: Correct aligment computation for shared object symbols.
Jun 1 2018, 2:09 PM
shenhan updated the diff for D47602: Correct aligment computation for shared object symbols.

@pcc thanks for the review. Updated the patch -

  1. if getAlignment sees a ABS symbols, returns 0
  2. initialize Ret to UINT64_MAX
  3. in "addCopyRelSymbol", errors out if alignment is 0.
  4. unit test case that tests for proper handling of ABS symbols.
Jun 1 2018, 1:44 PM
shenhan added inline comments to D47602: Correct aligment computation for shared object symbols.
Jun 1 2018, 10:36 AM

May 31 2018

shenhan added inline comments to D47602: Correct aligment computation for shared object symbols.
May 31 2018, 4:41 PM
shenhan added a comment to D47602: Correct aligment computation for shared object symbols.

Thanks @ruiu Updated the patch, also attached a test case.

May 31 2018, 3:50 PM
shenhan updated the summary of D47602: Correct aligment computation for shared object symbols.
May 31 2018, 3:49 PM
shenhan updated the diff for D47602: Correct aligment computation for shared object symbols.
May 31 2018, 3:43 PM
shenhan added a comment to D47602: Correct aligment computation for shared object symbols.

@pcc do you agree with initializing Ret to uint64-1?

May 31 2018, 2:35 PM
shenhan added a comment to D47602: Correct aligment computation for shared object symbols.

@pcc

May 31 2018, 2:02 PM
shenhan added inline comments to D47602: Correct aligment computation for shared object symbols.
May 31 2018, 1:51 PM
shenhan added inline comments to D47602: Correct aligment computation for shared object symbols.
May 31 2018, 1:32 PM
shenhan added a comment to D47602: Correct aligment computation for shared object symbols.

Thanks Rui. I just updated the patch a little bit, that - st_value is only valid for alignment when symbol shndx is set to SHN_COMMON.

May 31 2018, 1:25 PM
shenhan updated the diff for D47602: Correct aligment computation for shared object symbols.
May 31 2018, 1:22 PM
shenhan updated the summary of D47602: Correct aligment computation for shared object symbols.
May 31 2018, 1:21 PM
shenhan added a reviewer for D47602: Correct aligment computation for shared object symbols: ruiu.
May 31 2018, 12:32 PM
shenhan created D47602: Correct aligment computation for shared object symbols.
May 31 2018, 12:31 PM

May 25 2018

shenhan added a comment to D47396: [LLD] Place .nv_fatbin section at the beginning of the executable..

+Han Shen <shenhan@google.com>

Han, did you try that idea before?

May 25 2018, 4:45 PM

May 17 2018

shenhan committed rL332688: Mitigate relocation overflow [part 2 of 2].
Mitigate relocation overflow [part 2 of 2]
May 17 2018, 8:05 PM
shenhan committed rLLD332688: Mitigate relocation overflow [part 2 of 2].
Mitigate relocation overflow [part 2 of 2]
May 17 2018, 8:05 PM
shenhan added a comment to D46200: Mitigate relocation overflow [part 2 of 2].

Thanks. (Comments revised and DefaoutOutSec -> Default)

May 17 2018, 2:11 PM
shenhan updated the diff for D46200: Mitigate relocation overflow [part 2 of 2].
May 17 2018, 2:10 PM
shenhan added inline comments to D46200: Mitigate relocation overflow [part 2 of 2].
May 17 2018, 9:30 AM
shenhan updated the diff for D46200: Mitigate relocation overflow [part 2 of 2].
May 17 2018, 9:30 AM

May 16 2018

shenhan added a comment to D46200: Mitigate relocation overflow [part 2 of 2].

Hi George, mind take a look? (This is a follow up of D45788.)

May 16 2018, 11:16 AM
shenhan edited reviewers for D46200: Mitigate relocation overflow [part 2 of 2], added: grimar; removed: espindola.
May 16 2018, 11:15 AM
shenhan updated the diff for D46200: Mitigate relocation overflow [part 2 of 2].
May 16 2018, 11:14 AM

May 15 2018

shenhan committed rL332374: [lld] Mitigate relocation overflow [part 1 of 2]..
[lld] Mitigate relocation overflow [part 1 of 2].
May 15 2018, 10:09 AM
shenhan committed rLLD332374: [lld] Mitigate relocation overflow [part 1 of 2]..
[lld] Mitigate relocation overflow [part 1 of 2].
May 15 2018, 10:09 AM
shenhan closed D45788: Mitigate relocation overflow [part 1 of 2].
May 15 2018, 10:09 AM

May 14 2018

shenhan added a comment to D46764: Fix test cases that check addresses that are not always invariable.

Thanks for the review. Fixed as suggested in D45788.

May 14 2018, 9:08 PM
shenhan updated the diff for D45788: Mitigate relocation overflow [part 1 of 2].

Merge D46764 (Fix test cases that check addresses that are not always invariable) into this.

May 14 2018, 9:03 PM

May 11 2018

shenhan created D46764: Fix test cases that check addresses that are not always invariable.
May 11 2018, 11:31 AM
shenhan added a comment to D45788: Mitigate relocation overflow [part 1 of 2].

Sorry for breaking the builders. Should double check again after my fix for the broken 4 cases.

May 11 2018, 7:25 AM

May 10 2018

shenhan added a comment to D45788: Mitigate relocation overflow [part 1 of 2].

Some clarification why my test result is different from George's.

May 10 2018, 3:43 PM
shenhan committed rLLD332054: Fix test cases failure caused by revision 332038..
Fix test cases failure caused by revision 332038.
May 10 2018, 3:36 PM
shenhan committed rL332054: Fix test cases failure caused by revision 332038..
Fix test cases failure caused by revision 332038.
May 10 2018, 3:36 PM
shenhan created D46730: Fix test cases failure by revision 332038 .
May 10 2018, 3:30 PM
shenhan added a comment to D45788: Mitigate relocation overflow [part 1 of 2].

Thanks. Landed as https://llvm.org/svn/llvm-project/lld/trunk@332038

May 10 2018, 1:58 PM
shenhan updated the diff for D45788: Mitigate relocation overflow [part 1 of 2].

Synced to newest and re-ran tests, make sure everything passes.

May 10 2018, 1:51 PM
shenhan committed rL332038: Mitigate relocation overflow [part 1 of 2]..
Mitigate relocation overflow [part 1 of 2].
May 10 2018, 1:48 PM
shenhan committed rLLD332038: Mitigate relocation overflow [part 1 of 2]..
Mitigate relocation overflow [part 1 of 2].
May 10 2018, 1:48 PM

May 8 2018

shenhan added a comment to D45788: Mitigate relocation overflow [part 1 of 2].

Thanks for the review.

May 8 2018, 10:19 AM
shenhan updated the diff for D45788: Mitigate relocation overflow [part 1 of 2].
May 8 2018, 10:19 AM
shenhan updated the diff for D45788: Mitigate relocation overflow [part 1 of 2].

Updated according to review feedback. Also synced to upstream HEAD and re-run all tests. All passed now.

May 8 2018, 10:15 AM

May 7 2018

shenhan updated the diff for D45788: Mitigate relocation overflow [part 1 of 2].

Revised linkerscript/out-of-order.s and linkerscript/no-space.s to honor layout constraint (also added notes). Also addressed previous 2 minor comments.

May 7 2018, 10:51 AM

May 4 2018

shenhan added inline comments to D45788: Mitigate relocation overflow [part 1 of 2].
May 4 2018, 1:40 PM
shenhan added inline comments to D45788: Mitigate relocation overflow [part 1 of 2].
May 4 2018, 10:13 AM

May 3 2018

shenhan updated the diff for D45788: Mitigate relocation overflow [part 1 of 2].

Refined test cases changes and provide more context.

May 3 2018, 10:21 AM

May 2 2018

shenhan updated the diff for D45788: Mitigate relocation overflow [part 1 of 2].

Fixed all affected test cases.

May 2 2018, 9:36 PM

May 1 2018

shenhan updated the diff for D45788: Mitigate relocation overflow [part 1 of 2].
May 1 2018, 1:04 PM
shenhan added a comment to D46200: Mitigate relocation overflow [part 2 of 2].

Comments?

May 1 2018, 9:16 AM
shenhan added a comment to D45788: Mitigate relocation overflow [part 1 of 2].

Any further thoughts? If not, I'll proceed to fixing all the other test failures caused by section re-arrangement.

May 1 2018, 9:16 AM

Apr 27 2018

shenhan created D46200: Mitigate relocation overflow [part 2 of 2].
Apr 27 2018, 10:32 AM
shenhan added a comment to D45788: Mitigate relocation overflow [part 1 of 2].

Thanks. Done with a test case.

Apr 27 2018, 9:46 AM
shenhan updated the diff for D45788: Mitigate relocation overflow [part 1 of 2].
Apr 27 2018, 9:46 AM

Apr 26 2018

shenhan added a comment to D45788: Mitigate relocation overflow [part 1 of 2].

@espindola would you mind take a look?

Apr 26 2018, 3:45 PM
shenhan updated the diff for D45788: Mitigate relocation overflow [part 1 of 2].
Apr 26 2018, 3:39 PM
shenhan updated the diff for D45788: Mitigate relocation overflow [part 1 of 2].
Apr 26 2018, 3:37 PM
shenhan updated the diff for D45788: Mitigate relocation overflow [part 1 of 2].
Apr 26 2018, 2:58 PM
shenhan updated the diff for D45788: Mitigate relocation overflow [part 1 of 2].
Apr 26 2018, 2:52 PM
shenhan updated the diff for D45788: Mitigate relocation overflow [part 1 of 2].
Apr 26 2018, 12:51 PM

Apr 19 2018

shenhan added inline comments to D45788: Mitigate relocation overflow [part 1 of 2].
Apr 19 2018, 11:17 AM
shenhan updated the diff for D45788: Mitigate relocation overflow [part 1 of 2].
Apr 19 2018, 11:16 AM
shenhan added inline comments to D45788: Mitigate relocation overflow [part 1 of 2].
Apr 19 2018, 10:06 AM
shenhan updated the diff for D45788: Mitigate relocation overflow [part 1 of 2].
Apr 19 2018, 10:06 AM

Apr 18 2018

shenhan removed a reviewer for D45788: Mitigate relocation overflow [part 1 of 2]: espindola.
Apr 18 2018, 3:23 PM
shenhan created D45788: Mitigate relocation overflow [part 1 of 2].
Apr 18 2018, 3:22 PM

Apr 2 2018

shenhan updated the diff for D44993: Do not create R_X86_64_32S in dyna relo tbl.

clang-format the changed lines in X86_64.cpp

Apr 2 2018, 9:52 AM

Mar 28 2018

shenhan created D44993: Do not create R_X86_64_32S in dyna relo tbl.
Mar 28 2018, 12:21 PM

Mar 2 2018

shenhan abandoned D44027: Local variable only referenced in assert, causing opt build warnings.
Mar 2 2018, 10:15 AM
shenhan added a comment to D44027: Local variable only referenced in assert, causing opt build warnings.

Fixed in llvm/trunk@326592
Abandoned.

Mar 2 2018, 10:15 AM
shenhan created D44027: Local variable only referenced in assert, causing opt build warnings.
Mar 2 2018, 9:36 AM

Aug 2 2017

shenhan committed rL309873: [UBSan] Provide default blacklist filename for UBSan.
[UBSan] Provide default blacklist filename for UBSan
Aug 2 2017, 12:54 PM
shenhan closed D35849: [UBSan] Provide default blacklist filename for UBSan.
Aug 2 2017, 12:54 PM

Jul 31 2017

shenhan added a comment to D32842: Specify which sanitizers are covered by a sanitizer blacklist.

Ping? Can we make a decision on this?
I've this simple one D35849: [UBSan] Provide default blacklist filename for UBSan which, depending on this, shall be discarded or move forward.
If this CL stalls, I'll seek to proceed with D35849. Any how, D35849 gets wiped out whence this CL (D32842) is submitted.

Jul 31 2017, 11:52 AM

Jul 25 2017

shenhan added a comment to D35849: [UBSan] Provide default blacklist filename for UBSan.

Thanks for pointing out the relevant CLs. I agree that's the clearer and better solution.

Jul 25 2017, 1:35 PM
shenhan added a comment to D32842: Specify which sanitizers are covered by a sanitizer blacklist.

Thanks. Can you update "SanitizerArgs::collectDefaultBlacklists" to include "ubsan_blacklist.txt"?

Jul 25 2017, 1:31 PM
shenhan created D35849: [UBSan] Provide default blacklist filename for UBSan.
Jul 25 2017, 11:27 AM