Page MenuHomePhabricator

sheldonneuberger-sc (Sheldon Neuberger)
User

Projects

User does not belong to any projects.

User Details

User Since
Tue, Nov 16, 9:56 PM (2 w, 4 d)

Recent Activity

Tue, Nov 23

sheldonneuberger-sc added a comment to D114058: [clangd] Add ObjC method support to prepareCallHierarchy.

Made suggested changes, ready for another review.

Tue, Nov 23, 3:07 PM · Restricted Project, Restricted Project
sheldonneuberger-sc updated the diff for D114058: [clangd] Add ObjC method support to prepareCallHierarchy.
  • revert whitespace change
Tue, Nov 23, 3:06 PM · Restricted Project, Restricted Project
sheldonneuberger-sc updated the diff for D114058: [clangd] Add ObjC method support to prepareCallHierarchy.
  • inline test helper for readability
  • fix indentation
Tue, Nov 23, 3:03 PM · Restricted Project, Restricted Project

Wed, Nov 17

sheldonneuberger-sc retitled D114058: [clangd] Add ObjC method support to prepareCallHierarchy from [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate to [clangd] Add ObjC method support to prepareCallHierarchy.
Wed, Nov 17, 9:00 PM · Restricted Project, Restricted Project
sheldonneuberger-sc added a comment to D114058: [clangd] Add ObjC method support to prepareCallHierarchy.

Thanks for the detailed comments. I moved the patch into the clangd callsite. I also added a couple ObjC tests for CallHierarchy (I basically parameterized two of the existing tests).

Wed, Nov 17, 8:36 PM · Restricted Project, Restricted Project
sheldonneuberger-sc updated the diff for D114058: [clangd] Add ObjC method support to prepareCallHierarchy.
  • fix test name
Wed, Nov 17, 8:35 PM · Restricted Project, Restricted Project
sheldonneuberger-sc updated the diff for D114058: [clangd] Add ObjC method support to prepareCallHierarchy.
  • clang-format
Wed, Nov 17, 8:32 PM · Restricted Project, Restricted Project
sheldonneuberger-sc updated the diff for D114058: [clangd] Add ObjC method support to prepareCallHierarchy.
  • move change to clangd callsite
  • add tests
Wed, Nov 17, 8:31 PM · Restricted Project, Restricted Project

Tue, Nov 16

sheldonneuberger-sc published D114058: [clangd] Add ObjC method support to prepareCallHierarchy for review.
Tue, Nov 16, 11:24 PM · Restricted Project, Restricted Project