Page MenuHomePhabricator

sheisc (Changwei Zou)
User

Projects

User does not belong to any projects.

User Details

User Since
May 17 2022, 1:59 AM (6 w, 6 d)

Recent Activity

May 17 2022

sheisc added a comment to D125789: FIX the assembly format of the x86 backend to make both clang and gcc happy.

Is it gcc that needs a fix or binutils?

May 17 2022, 8:59 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
sheisc added a comment to D125789: FIX the assembly format of the x86 backend to make both clang and gcc happy.

I think another way is to report the issue to GCC. From the perspective of the user, GCC should support both {%k1} {z} and {%k1}{z}. Then we don't need the clange on LLVM.

Yes. It is a good idea.
However, it appears that there is no such white space in the instructions as described in Intel's manuals.
So I don't know which one should be the correct format.
Anyway, not a big issue.
I found this problem when using the fuzzer (i.e. AFL) to build Firefox.

Yeah. This is an interesting question. I didn't notice the difference between LLVM and GCC. I think either way changing here or GCC is OK :)

May 17 2022, 8:44 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
sheisc added a comment to D125789: FIX the assembly format of the x86 backend to make both clang and gcc happy.

I think another way is to report the issue to GCC. From the perspective of the user, GCC should support both {%k1} {z} and {%k1}{z}. Then we don't need the clange on LLVM.

May 17 2022, 8:27 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
sheisc abandoned D125789: FIX the assembly format of the x86 backend to make both clang and gcc happy.

I guess a lot of lines of tests need to update

$ grep -rn " {z}" llvm/test/CodeGen/X86/ | wc -l
7797
May 17 2022, 8:21 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
sheisc updated the diff for D125789: FIX the assembly format of the x86 backend to make both clang and gcc happy.
May 17 2022, 8:15 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
sheisc requested review of D125789: FIX the assembly format of the x86 backend to make both clang and gcc happy.
May 17 2022, 7:23 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project