Page MenuHomePhabricator

serhiy.redko (Serhiy Redko)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 3 2019, 4:42 PM (98 w, 1 d)

Recent Activity

Mon, Oct 18

serhiy.redko planned changes to D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided..
Mon, Oct 18, 10:47 AM · Unknown Object (Project)
serhiy.redko updated the diff for D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided..
  • return error in case debug configuration contains incompatible fields with 'launchCommands'/'attachCommands'
Mon, Oct 18, 1:06 AM · Unknown Object (Project)

Sun, Oct 10

serhiy.redko updated the diff for D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided..
  • added printing of unused target related fields from launch.json in case launchCommands/attachCommands fields are provided.
  • updated help info in for launch/attach fields according to review request.
Sun, Oct 10, 11:39 PM · Unknown Object (Project)

Jan 20 2021

serhiy.redko planned changes to D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided..

Thanks for review and your input, @clayborg

Jan 20 2021, 9:54 AM · Unknown Object (Project)

Jan 19 2021

serhiy.redko added reviewers for D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.: clayborg, wallace, kusmour, tatyana-krasnukha, labath, aadsm.
Jan 19 2021, 12:56 PM · Unknown Object (Project)
serhiy.redko requested review of D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided..
Jan 19 2021, 12:51 PM · Unknown Object (Project)

Dec 5 2019

serhiy.redko added a comment to D71034: [lldb-vscode] Added support for ‘totalFrames’ field in StackTraces response .

Basically I also was confused with that field which is marked as optional in schema and initially I thought this is VSCode UI issue that expects that field to be present for DAP implementations that provide support for 'supportsDelayedStackTraceLoading' capability.
Then I read the following in specification for 'supportsDelayedStackTraceLoading' and concluded that for DAP that supports 'supportsDelayedStackTraceLoading', 'totalFrames' field is mandatory.

Dec 5 2019, 5:57 PM · Unknown Object (Project)

Dec 4 2019

serhiy.redko updated the summary of D71034: [lldb-vscode] Added support for ‘totalFrames’ field in StackTraces response .
Dec 4 2019, 2:48 PM · Unknown Object (Project)
serhiy.redko created D71034: [lldb-vscode] Added support for ‘totalFrames’ field in StackTraces response .
Dec 4 2019, 2:48 PM · Unknown Object (Project)