Page MenuHomePhabricator

seldridge (Schuyler Eldridge)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 21 2020, 7:51 AM (82 w, 1 d)

Recent Activity

Nov 30 2021

seldridge committed rG63f417ef3996: [ADT] Remove 0-width Asserts in APInt.getZExtValue (authored by seldridge).
[ADT] Remove 0-width Asserts in APInt.getZExtValue
Nov 30 2021, 2:03 PM
seldridge closed D114768: [ADT] Remove 0-width Asserts in APInt.getZExtValue.
Nov 30 2021, 2:03 PM · Restricted Project
seldridge updated the diff for D114768: [ADT] Remove 0-width Asserts in APInt.getZExtValue.

Fix comment. :)

Nov 30 2021, 1:47 PM · Restricted Project
seldridge updated the diff for D114768: [ADT] Remove 0-width Asserts in APInt.getZExtValue.

Update commit message/diff summary to reflect reduced scope.

Nov 30 2021, 1:09 PM · Restricted Project
seldridge updated the diff for D114768: [ADT] Remove 0-width Asserts in APInt.getZExtValue.

Add test of zero-width ZExt behavior.

Nov 30 2021, 12:42 PM · Restricted Project
seldridge abandoned D114811: [ADT] Allow zero-width zext.

Opened a second revision when I meant to drop a commit from https://reviews.llvm.org/D114768. Whoops. 🤦

Nov 30 2021, 11:42 AM · Restricted Project
seldridge updated the diff for D114768: [ADT] Remove 0-width Asserts in APInt.getZExtValue.

Drop SExt commit. This is somewhat controversial and, after further
examination on my end, seemingly not needed. I can revive this if it
becomes necessary for CIRCT.

Nov 30 2021, 11:41 AM · Restricted Project
seldridge requested review of D114811: [ADT] Allow zero-width zext.
Nov 30 2021, 11:35 AM · Restricted Project
seldridge updated the diff for D114768: [ADT] Remove 0-width Asserts in APInt.getZExtValue.

Run clang-format

Nov 30 2021, 6:55 AM · Restricted Project

Nov 29 2021

seldridge added a reviewer for D114768: [ADT] Remove 0-width Asserts in APInt.getZExtValue: lattner.
Nov 29 2021, 10:38 PM · Restricted Project
seldridge published D114768: [ADT] Remove 0-width Asserts in APInt.getZExtValue for review.

This diff removes restrictions around zero/sign extension of zero-width APInts. Specifically, there is a restriction introduced in https://reviews.llvm.org/D109555 that disallows zero extension of zero-width APInts. Additionally, there are some old asserts inside MathExtras, added in https://reviews.llvm.org/D22442, which assert on sign extension of any zero-width number (which are used pervasively inside APInt code to implement its sign extension). This is attempting to better enable the CIRCT project to rely on APInt to represent zero-width wires without introducing lots of additional guards to work around APInt methods which assert when used. More information on what specifically this is attempting to solve for CIRCT is here: https://github.com/llvm/circt/issues/2255

Nov 29 2021, 10:37 PM · Restricted Project