Page MenuHomePhabricator

sebmarchand (Sébastien Marchand)
User

Projects

User does not belong to any projects.

User Details

User Since
May 14 2020, 8:50 PM (8 w, 1 d)

Recent Activity

May 19 2020

sebmarchand added a comment to D80042: [gn build] Add a flag to provide the path to zlib on Windows..

Looks like we need something like this:

May 19 2020, 1:43 PM · Restricted Project
sebmarchand added a comment to D80042: [gn build] Add a flag to provide the path to zlib on Windows..

Ha shoot, looks like you're fixing this in https://github.com/llvm/llvm-project/commit/f8cccd126b4780a42c00ba84848a66a1c8567183 ?

May 19 2020, 1:43 PM · Restricted Project
sebmarchand added a comment to D80042: [gn build] Add a flag to provide the path to zlib on Windows..

Thanks! I don't think that I can commit this though, the doc says "If you do not have commit access, someone has to commit the change for you (with attribution)" , could you please do that? Thanks!

May 19 2020, 10:55 AM · Restricted Project
sebmarchand added a comment to D80042: [gn build] Add a flag to provide the path to zlib on Windows..

Thanks for the patch! The way I thought this would look is to have the arg in http://llvm-cs.pcc.me.uk/utils/gn/build/libs/zlib/enable.gni#3 and then change the lower declare_args block to have llvm_enable_zlib = host_os != "win" || zlib_path != "". Does that make sense?

May 19 2020, 8:07 AM · Restricted Project
sebmarchand updated the diff for D80042: [gn build] Add a flag to provide the path to zlib on Windows..

Address Nico's comments.

May 19 2020, 8:07 AM · Restricted Project

May 15 2020

sebmarchand added a reviewer for D80042: [gn build] Add a flag to provide the path to zlib on Windows.: thakis.
May 15 2020, 3:47 PM · Restricted Project
sebmarchand added a comment to D80042: [gn build] Add a flag to provide the path to zlib on Windows..

Hey Nico,

May 15 2020, 3:47 PM · Restricted Project
sebmarchand updated the diff for D80042: [gn build] Add a flag to provide the path to zlib on Windows..
May 15 2020, 3:47 PM · Restricted Project
sebmarchand updated the diff for D80042: [gn build] Add a flag to provide the path to zlib on Windows..
May 15 2020, 3:47 PM · Restricted Project
sebmarchand created D80042: [gn build] Add a flag to provide the path to zlib on Windows..
May 15 2020, 3:47 PM · Restricted Project

May 14 2020

sebmarchand created D79981: [PoC] llvm-profdata - Normalize the PGO data before writing them to disk.
May 14 2020, 9:13 PM · Restricted Project