Page MenuHomePhabricator

seanklein (Sean Klein)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 29 2016, 11:14 AM (184 w, 5 d)

Recent Activity

May 3 2016

seanklein added a comment to D19734: [X86] Add -malign-double support.

Yeah, I think I do. Thanks for the review! This is my first patch to Clang.

May 3 2016, 6:49 PM
seanklein updated the diff for D19734: [X86] Add -malign-double support.

Moved AlignDouble to Language Options.

May 3 2016, 2:46 PM
seanklein added a reviewer for D19734: [X86] Add -malign-double support: rnk.
May 3 2016, 1:54 PM
seanklein updated the diff for D19734: [X86] Add -malign-double support.

lib/Driver/Tools.cpp change no longer necessary

May 3 2016, 11:49 AM
seanklein updated the diff for D19734: [X86] Add -malign-double support.

Updated to avoid changing:

  1. Datalayout
  2. The LLVM backend
  3. cl::opts
May 3 2016, 11:33 AM
seanklein updated D19734: [X86] Add -malign-double support.
May 3 2016, 11:29 AM

Apr 29 2016

seanklein added a comment to D19734: [X86] Add -malign-double support.

I want to push back just a little bit on adding more ABI tweaking flags. If users need some data to be more
aligned, they can already apply alignment attributes to the performance-sensitive declarations instead of
changing all record layout everywhere.

Apr 29 2016, 1:29 PM
seanklein updated D19740: [X86] Add -malign-double support.
Apr 29 2016, 1:12 PM
seanklein retitled D19740: [X86] Add -malign-double support from to [X86] Add -malign-double support.
Apr 29 2016, 1:07 PM
seanklein updated D19734: [X86] Add -malign-double support.
Apr 29 2016, 1:07 PM
seanklein retitled D19734: [X86] Add -malign-double support from to [X86] Add -malign-double support.
Apr 29 2016, 11:56 AM