Page MenuHomePhabricator

sdowney (Steve Downey)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 6 2016, 4:58 PM (293 w, 16 h)

Recent Activity

Apr 4 2016

sdowney added a comment to D18191: [clang-tidy] Add check for function parameters that are const& to builtin types.

At least in my codebase, skipping templates is too strong. I run across ones where the const& parameter is not one controlled by a template. It's often a size_t.

Apr 4 2016, 8:28 AM

Mar 17 2016

sdowney updated the diff for D18191: [clang-tidy] Add check for function parameters that are const& to builtin types.

Add tests for FixIts

Mar 17 2016, 5:21 PM
sdowney updated the diff for D18191: [clang-tidy] Add check for function parameters that are const& to builtin types.

Add tests with functions generated with MACROS

Mar 17 2016, 4:20 PM
sdowney added a comment to D18191: [clang-tidy] Add check for function parameters that are const& to builtin types.

There is utility in the definition of a function in saying that an argument is const int i instead of int i. The const-ness declares the intent that this local variable is not going to be modified. However, there is that oddity in C++ that allows a declaration to say void f(int i); and the implementation to say void f(const int i) { ... }.

I think I would like the fixit to preserve the const-ness of the argument while still stripping it of it's reference.

Mar 17 2016, 3:46 PM
sdowney updated the diff for D18191: [clang-tidy] Add check for function parameters that are const& to builtin types.

Add more test cases, covering templates, template specializations, function definitions, member function templates.

Mar 17 2016, 3:34 PM

Mar 15 2016

sdowney retitled D18191: [clang-tidy] Add check for function parameters that are const& to builtin types from to [clang-tidy] Add check for function parameters that are const& to builtin types.
Mar 15 2016, 9:53 AM

Feb 9 2016

sdowney added a comment to D16963: Copy LibASTMatchersReference.html to gen'd docs.

I'll push up a review with the one line link addition later. Thanks!

Feb 9 2016, 9:18 AM

Feb 7 2016

sdowney retitled D16963: Copy LibASTMatchersReference.html to gen'd docs from to Copy LibASTMatchersReference.html to gen'd docs.
Feb 7 2016, 7:56 AM