Page MenuHomePhabricator

schroedersi (Simon Schroeder)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 4 2017, 10:40 AM (128 w, 2 d)

Recent Activity

Jan 22 2019

schroedersi added a comment to D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface.

Ping. It would indeed be very helpful to have information about the kind of an operator :-)

Jan 22 2019, 4:04 AM · Restricted Project
Herald added a reviewer for D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface: serge-sans-paille.
Jan 22 2019, 3:57 AM · Restricted Project

Dec 7 2017

schroedersi added a comment to D30946: [ScopePrinting] Added support to print full scopes of types and declarations..

Ping

Dec 7 2017, 6:41 AM

Nov 23 2017

schroedersi added a comment to D30946: [ScopePrinting] Added support to print full scopes of types and declarations..

Ping

Nov 23 2017, 7:32 AM

Oct 31 2017

schroedersi added a comment to D30946: [ScopePrinting] Added support to print full scopes of types and declarations..

Ping

Oct 31 2017, 4:04 AM

Oct 23 2017

schroedersi added a comment to D30946: [ScopePrinting] Added support to print full scopes of types and declarations..

Ping

Oct 23 2017, 10:34 AM

Oct 9 2017

schroedersi added a comment to D30946: [ScopePrinting] Added support to print full scopes of types and declarations..

Any feedback is appreciated!

Oct 9 2017, 9:13 AM

Sep 27 2017

schroedersi added a comment to D30946: [ScopePrinting] Added support to print full scopes of types and declarations..

Ping :)

Sep 27 2017, 7:15 AM

Sep 7 2017

schroedersi added a comment to D30946: [ScopePrinting] Added support to print full scopes of types and declarations..

Hello Richard, what do you think about the printing context changes? Are they what you expected?

Sep 7 2017, 11:17 AM

Aug 28 2017

schroedersi added a comment to D30946: [ScopePrinting] Added support to print full scopes of types and declarations..

Ping :)

Aug 28 2017, 4:43 AM

Aug 21 2017

schroedersi added a comment to D30946: [ScopePrinting] Added support to print full scopes of types and declarations..

Ping :)

Aug 21 2017, 3:47 AM

Jul 18 2017

schroedersi added a comment to D30946: [ScopePrinting] Added support to print full scopes of types and declarations..

Ping :)

Jul 18 2017, 8:35 AM

Jul 9 2017

schroedersi added a comment to D30946: [ScopePrinting] Added support to print full scopes of types and declarations..

Ping :)

Jul 9 2017, 2:41 PM

Jun 29 2017

schroedersi updated the diff for D30946: [ScopePrinting] Added support to print full scopes of types and declarations..

I forgot to add the previous changes in Diff 104649 (it only contains the incremental diff of the printing context changes). This diff contains all changes between trunk and the current patch state. I apologize!

Jun 29 2017, 8:29 AM
schroedersi updated the diff for D30946: [ScopePrinting] Added support to print full scopes of types and declarations..

I'd be interested to see how much complexity that adds, if you're prepared to give it a try.

Thanks for your feedback :). I added a printing context and moved TemporarySuppressScope from PrintingPolicy to the printing context. The printing context is currently passed around by value. This is not ideal because changes to the context made inside a function are not available in the caller but it is sufficient for the temporary suppress scope functionality. And it gives an overview of the amount of code changes.

Jun 29 2017, 7:54 AM

Jun 14 2017

schroedersi added a comment to D30946: [ScopePrinting] Added support to print full scopes of types and declarations..

Would it help the acceptance of the patch if I add a fourth option LegacySuppressScope (or similar) that emulates the current/pre-patch SuppressScope==true? This way the patched type printing would be a real superset of the current/non-patched type printing (except for some small changes to SuppressScope==false/DefaultScope as seen in the diff of tests p6.cpp and comment-cplus-decls.cpp).

Jun 14 2017, 3:53 AM

Jun 12 2017

schroedersi added a comment to D30946: [ScopePrinting] Added support to print full scopes of types and declarations..

Ping :)

Jun 12 2017, 7:03 AM

Jun 1 2017

schroedersi added a comment to D30946: [ScopePrinting] Added support to print full scopes of types and declarations..

Ping :)

Jun 1 2017, 2:29 AM
schroedersi updated the summary of D30946: [ScopePrinting] Added support to print full scopes of types and declarations..
Jun 1 2017, 2:26 AM

May 24 2017

schroedersi added a comment to D30946: [ScopePrinting] Added support to print full scopes of types and declarations..

Ping :)

May 24 2017, 9:44 AM

May 13 2017

schroedersi added a comment to D30946: [ScopePrinting] Added support to print full scopes of types and declarations..

Also the mutable state in PrintingPolicy is really really ugly, is there no better way for this? :(

May 13 2017, 6:04 AM
schroedersi updated the diff for D30946: [ScopePrinting] Added support to print full scopes of types and declarations..
  • Ran clang-format (current trunk version) on the changes (except on some test files)
  • Adapted patch to current trunk version
May 13 2017, 5:43 AM

Mar 14 2017

schroedersi created D30946: [ScopePrinting] Added support to print full scopes of types and declarations..
Mar 14 2017, 9:40 AM