Page MenuHomePhabricator

schandra (sunita chandrasekaran)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 14 2014, 11:08 AM (410 w, 1 d)

Recent Activity

Aug 4 2017

schandra added a comment to D34701: [openmp-target-tests] OpenMP 4.5 Target data test cases.

Hi Jonas

Did you have further comments on this commit?

Thanks
Sunita

Sorry that it's taken so long! Still not sure about the Fortran test as clang will currently not be able to handle this.

Additionally, these tests currently won't pass because omp_is_initial_device() will return 1 when offloading to the host, correct? See D35719 why we had to disable libomptarget for 5.0.

Find some more comments inline. In general, the tests should be brought to a consistent coding style (braces, end-comments, comment style and so on).

Aug 4 2017, 7:31 AM

Jul 27 2017

schandra added a comment to D34701: [openmp-target-tests] OpenMP 4.5 Target data test cases.

Hi Jonas

Jul 27 2017, 12:50 PM

Apr 21 2015

schandra added a comment to D8752: Validation using OpenMP validation suite - adding support for cmake Part 2 of 2.

Hi Jonathan
Thanks for your comments, in the past week or so we have been cleaning up
the bundle more based on some more comments, so we will have new patches
for y'all to review.
However reply inline:

Apr 21 2015, 4:34 PM

Mar 31 2015

schandra retitled D8752: Validation using OpenMP validation suite - adding support for cmake Part 2 of 2 from to Validation using OpenMP validation suite - adding support for cmake Part 2 of 2.
Mar 31 2015, 3:11 PM

Feb 15 2015

schandra updated subscribers of D7637: OpenMP Validation Suite for testing LLVM OpenMP Implementation, Patch 1 of 2.
Feb 15 2015, 6:41 PM
schandra updated subscribers of D7638: OpenMP Validation Suite for testing LLVM OpenMP Implementation, Patch 2 of 2.
Feb 15 2015, 6:40 PM

Feb 13 2015

schandra updated D7637: OpenMP Validation Suite for testing LLVM OpenMP Implementation, Patch 1 of 2.
Feb 13 2015, 9:09 PM
schandra retitled D7638: OpenMP Validation Suite for testing LLVM OpenMP Implementation, Patch 2 of 2 from to OpenMP Validation Suite for testing LLVM OpenMP Implementation, Patch 2 of 2.
Feb 13 2015, 9:08 PM
schandra retitled D7637: OpenMP Validation Suite for testing LLVM OpenMP Implementation, Patch 1 of 2 from OpenMP Validation Suite for testing LLVM OpenMP Implementation to OpenMP Validation Suite for testing LLVM OpenMP Implementation, Patch 1 of 2.
Feb 13 2015, 9:07 PM
schandra updated D7637: OpenMP Validation Suite for testing LLVM OpenMP Implementation, Patch 1 of 2.
Feb 13 2015, 9:05 PM
schandra retitled D7637: OpenMP Validation Suite for testing LLVM OpenMP Implementation, Patch 1 of 2 from to OpenMP Validation Suite for testing LLVM OpenMP Implementation.
Feb 13 2015, 9:01 PM

Aug 19 2014

schandra added a comment to rL213510: [OPENMP] Parsing/Sema of the OpenMP directive 'critical'..

Lines: 730, 748, 769 in test/OpenMP/nesting_of_regions.cpp
Not sure if the comment is purposely in there or a note to somebody.

Aug 19 2014, 1:57 PM
schandra added inline comments to rL213510: [OPENMP] Parsing/Sema of the OpenMP directive 'critical'..
Aug 19 2014, 1:16 PM